Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp386251rwe; Thu, 1 Sep 2022 00:46:11 -0700 (PDT) X-Google-Smtp-Source: AA6agR4YzMwlMu7/zG59cTGbc4RF+hidqBaNOH359a8UYU2q/+J3jf0CeRnULSHZUaIkbB1Zkxkl X-Received: by 2002:a17:90a:8b82:b0:1fa:973c:1d34 with SMTP id z2-20020a17090a8b8200b001fa973c1d34mr7337072pjn.31.1662018371150; Thu, 01 Sep 2022 00:46:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662018371; cv=none; d=google.com; s=arc-20160816; b=1K+EzijgoOgQRpfhcUUsxC9U9gs+9ROqHCGs6r5EizROeEKoesnA08aQqb9uGLh0bn 1Xgzl4HSbg+BEQo02S+mXeoPGRGOkImZYsajkpE/weE9NEKivTOK0ZVrxZrg5nEL7DPS tlHNZFaLn2l3qV0EcZDqoU+sxwW9k/xTs5ou7h2XdtNnDGDnbo0ipx8wFbp4KRGIswRL 3ak+pdxj4REw9j9+JnoCrfgWORt0tr07PE94xubXD3C2ua1S4s2nMIguj6OOfHMqP3wc Qf4G5af3SRr2jBz/WI3ro4DYM+8QKYkqPWNlR9/JRdRM0zSAfSEqL85VCea28zQeOt/W UWjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Tx/ZqonWjTRNyHxqCfN+aNIf+SBTGqvK/IVfisx4Ops=; b=sYHaXhDzD8TqimKFYjZQr1Tsw1pMjFVdDYap7KtYpAXM/m4sxcdcwZnS3BR39yHww3 4+c8TFCNfm/4HaONacAM953QDDxVu7A83uJZ/yk/mkqnXKNtbcwCFip3hC/wu7cMzrOl i4fpaEwWAeRyajl8vAPCs5PM/YhyYfqnuWfIVYBJawEnxgYjxIpUCfybRq71uY0z5yA2 T4jDIEeBbCgVmzOCmTPsjYSQXvrjJizOZop/egQ+1HvotJV1haAZLZOxzkqEv415S0Qx OO6SgjHdn1wv15BDFMVXX3TU14411uNm25shK3RBil378gvEuAXP7gkw5L9ihdddauFQ pMFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=OlpRaO3b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h15-20020a056a001a4f00b0050df0383302si8684048pfv.255.2022.09.01.00.45.59; Thu, 01 Sep 2022 00:46:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=OlpRaO3b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233405AbiIAHmU (ORCPT + 99 others); Thu, 1 Sep 2022 03:42:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233109AbiIAHmR (ORCPT ); Thu, 1 Sep 2022 03:42:17 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D11E91090B1; Thu, 1 Sep 2022 00:42:14 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id o4so16382290pjp.4; Thu, 01 Sep 2022 00:42:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=Tx/ZqonWjTRNyHxqCfN+aNIf+SBTGqvK/IVfisx4Ops=; b=OlpRaO3btNemHo8Hy8MkXH11Gpg5gv+ND42di1JE7LK9uxDZPpGaJelBy1QsMT97dg ncNKpbYtnG36jID3aLritQq3/qzsEmLQa0Xju5TxsQwS+5Yn8w/Xyd5JOO5LXA+jbAnw pMCYwJjq5fB6NO8jbgYa52bZC5iyIlYO3fprRjLEMxfYD/wSk1mI7rjPuoih7lJxXcd+ I3wbxx/W9n2l28LbSPWNPXLP85xDVpJ3+pWvfY0Z87eDQdff8aM5K80zfQI8nZfJizR7 9VZRRz0r6673InjxUokrMoyuzJXtNCKASD8sUDR9FN0aicA4mEcDt0YD/p4wjjgSso+h GGrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=Tx/ZqonWjTRNyHxqCfN+aNIf+SBTGqvK/IVfisx4Ops=; b=LqcRj6FYwVGppI1oFyz2SocjbfN6QOGLc659GHQr1XC5EprSCO3TdW9nN5l+l8/53d tkO7n0+hUTp8h+Y5cfjVT1hf3ODxKSYOOu9rBmfMZq+gHJnJAvNOuSM9PKjdBGwZwA7w AetJiBWvZLeCMWr1W4sQthvOP+pgHNo8p1fgkYsUTZ2k4eYJE7xCUXZzEXNaH9iZ3VQb EY16cZfF/eljt7zQuiERfVA4T70TI+K8qSV6aOj/xrT+mOb060qwUOBKO1ocWWxDysgN 4UP4BuSDUtGRrAM3pk/+710b+xiECk/aMRIuUSU4cTjdl8Yn1csL+dGx8X2IJ78DI6x7 RSqQ== X-Gm-Message-State: ACgBeo1rFvoF+CoK1oILnGdqO8hvvpBE07w8jNkg8EzV0o2om/pJkRbX Tc4+RUQBAD+VBEcp+YAsyfw= X-Received: by 2002:a17:90b:3c8f:b0:1fd:e29c:d8d8 with SMTP id pv15-20020a17090b3c8f00b001fde29cd8d8mr7419769pjb.5.1662018134321; Thu, 01 Sep 2022 00:42:14 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id e16-20020a17090ab39000b001fbb6d73da5sm2618732pjr.21.2022.09.01.00.42.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Sep 2022 00:42:13 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: ye.xingchen@zte.com.cn To: jgg@ziepe.ca Cc: dennis.dalessandro@cornelisnetworks.com, leon@kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, ye xingchen , Zeal Robot Subject: [PATCH linux-next] RDMA/hfi1: Remove the unneeded result variable Date: Thu, 1 Sep 2022 07:42:09 +0000 Message-Id: <20220901074209.313004-1-ye.xingchen@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: ye xingchen Return the value set_link_state() directly instead of storing it in another redundant variable. Reported-by: Zeal Robot Signed-off-by: ye xingchen --- drivers/infiniband/hw/hfi1/verbs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c index ec4f316a28e1..e6e17984553c 100644 --- a/drivers/infiniband/hw/hfi1/verbs.c +++ b/drivers/infiniband/hw/hfi1/verbs.c @@ -1447,12 +1447,10 @@ static int shut_down_port(struct rvt_dev_info *rdi, u32 port_num) struct hfi1_ibdev *verbs_dev = dev_from_rdi(rdi); struct hfi1_devdata *dd = dd_from_dev(verbs_dev); struct hfi1_pportdata *ppd = &dd->pport[port_num - 1]; - int ret; set_link_down_reason(ppd, OPA_LINKDOWN_REASON_UNKNOWN, 0, OPA_LINKDOWN_REASON_UNKNOWN); - ret = set_link_state(ppd, HLS_DN_DOWNDEF); - return ret; + return set_link_state(ppd, HLS_DN_DOWNDEF); } static int hfi1_get_guid_be(struct rvt_dev_info *rdi, struct rvt_ibport *rvp, -- 2.25.1