Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp393610rwe; Thu, 1 Sep 2022 00:58:50 -0700 (PDT) X-Google-Smtp-Source: AA6agR5h69wW4UoSjdgGNYcES+k+kMCle5r3TDQYcc6Zqr75wEqEc5DeJ4utpntNdwuwodJApoKR X-Received: by 2002:a17:907:1627:b0:741:5338:936 with SMTP id hb39-20020a170907162700b0074153380936mr15488349ejc.619.1662019130411; Thu, 01 Sep 2022 00:58:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662019130; cv=none; d=google.com; s=arc-20160816; b=FzDgbfqSznPz7tdP9UniKLYZNO/n+AkqStLT7yEYRhfP1WdQQ295pGV30XD8VDWxbI VqCJR1R93Xq9Uxpvws0aw4bXPCQtAo/GmNT7WPXuAA/rB5JoF81p0pzG+LROUj2LdS1i t7C6ZLsF76z6Qiz+lwy01hepWPk54lPQRoAYoIeJl1KVGeO3WkAXHY2UFFcNfv8pVqIM byyZvn6YHLzc6q4RTi4VDIYCZ93sGyUiXwwxXYqwQRSi4VkYMUkjijF1n6BU7C9wsPkQ nj4I+TOxAx5rGg7W5j6UCYCfYUD1TbVXYesgZe811UUID6akyky+GSKgx8nz7cnnrp8H cKog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=4cqtgf3CE6gqD+/8No1Sv4RAv/qxkU/ySF3M8q/0Q60=; b=KhgxdFAY3BQ2YoqiIffbriAhUW0WXKATg7rxpAcZ6avA5tT0H7ZkuI0FmAwDIuWGEb MPpA7ZjKWBzQpCt++iZ8/YWjIpq3KNea9AAFkiCe9AAA6H4B3o3vnFPKTKzZY0RVGI6s VglU7qdDlaKOw2RApVkWNymjIKOVI8GruGNWXhpkL+B4lcHOrZAc6+dKDULK74qg8PW4 FjhaP0gm7eynOY1fPZRU5Fq2W4pr6SQoYWdtrXq2Felu3xEVdS5xQAbPACQhSEGAuhqr qEGGDxgGNBEfJHwMO4xVthnnEuARDh8RbHGfXUL9WXONI74ERqZf0mJLvGvJks5wqQJo 67iA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cw17-20020a170906479100b00730ed690a72si13618881ejc.630.2022.09.01.00.58.24; Thu, 01 Sep 2022 00:58:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233435AbiIAHNC (ORCPT + 99 others); Thu, 1 Sep 2022 03:13:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233574AbiIAHM5 (ORCPT ); Thu, 1 Sep 2022 03:12:57 -0400 Received: from cstnet.cn (smtp84.cstnet.cn [159.226.251.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A3A49123C2A for ; Thu, 1 Sep 2022 00:11:46 -0700 (PDT) Received: from localhost.localdomain (unknown [124.16.138.126]) by APP-05 (Coremail) with SMTP id zQCowADnb0khWxBja30gAA--.56086S2; Thu, 01 Sep 2022 15:11:30 +0800 (CST) From: Jiasheng Jiang To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, kuninori.morimoto.gx@renesas.com Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jiasheng Jiang Subject: [PATCH] ASoC: rsnd: Add check for rsnd_mod_power_on Date: Thu, 1 Sep 2022 15:11:27 +0800 Message-Id: <20220901071127.3448059-1-jiasheng@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: zQCowADnb0khWxBja30gAA--.56086S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Jw45uF4UCF4DtFWxJw15XFb_yoW3Xwb_Ga 1fWw1rZrW2krySyFyDGw4S9rWI9ry7CFyUWFWftr1Ut3yUXryfJayvqryfCryrWw1kur9x uayUA34xCrWSyjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbzxFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1l42xK82IYc2Ij64vI r41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8Gjc xK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0 cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8V AvwI8IcIk0rVWrZr1j6s0DMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7Cj xVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7VUbXdbUUUUUU== X-Originating-IP: [124.16.138.126] X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/ X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As rsnd_mod_power_on() can return negative numbers, it should be better to check the return value and deal with the exception. Fixes: e7d850dd10f4 ("ASoC: rsnd: use mod base common method on SSI-parent") Signed-off-by: Jiasheng Jiang --- sound/soc/sh/rcar/ssi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c index 43c5e27dc5c8..7ade6c5ed96f 100644 --- a/sound/soc/sh/rcar/ssi.c +++ b/sound/soc/sh/rcar/ssi.c @@ -480,7 +480,9 @@ static int rsnd_ssi_init(struct rsnd_mod *mod, ssi->usrcnt++; - rsnd_mod_power_on(mod); + ret = rsnd_mod_power_on(mod); + if (ret < 0) + return ret; rsnd_ssi_config_init(mod, io); -- 2.25.1