Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ff5ccb8b-adc7-8d74-6693-0e94785084a2@redhat.com>
Date:   Thu, 1 Sep 2022 09:37:58 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] mm: remove BUG_ON() in __isolate_free_page()
Content-Language: en-US
To:     Kefeng Wang <wangkefeng.wang@huawei.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org
Cc:     linux-kernel@vger.kernel.org
References: <20220901015043.189276-1-wangkefeng.wang@huawei.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20220901015043.189276-1-wangkefeng.wang@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 01.09.22 03:50, Kefeng Wang wrote:
> Drop unneed comment and blank, adjust the variable, and the most
> important is to delete BUG_ON(). The page passed is always buddy
> page into __isolate_free_page() from compaction, page_isolation
> and page_reporting, and the caller also check the return, BUG_ON()
> is a too drastic measure, remove it.

Why not WARN_ON_ONCE then? But yeah, maybe this really isn't of any
value anymore.

-- 
Thanks,

David / dhildenb