Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Date:   Thu, 1 Sep 2022 09:54:23 +0200
From:   Robert Richter <rrichter@amd.com>
To:     Jonathan Cameron <Jonathan.Cameron@huawei.com>
CC:     Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>
Subject: Re: [PATCH 14/15] cxl/acpi: Enumerate ports in RCD mode to enable
 RCHs and RCDs
Message-ID: <YxBlL64H4InIPGT7@rric.localdomain>
References: <20220831081603.3415-1-rrichter@amd.com>
 <20220831081603.3415-15-rrichter@amd.com>
 <20220831131634.00007870@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220831131634.00007870@huawei.com>
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 07:54:29.2869
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 97cf7577-638f-45be-a222-08da8bef32e9
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT097.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6218
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 31.08.22 13:16:34, Jonathan Cameron wrote:
> On Wed, 31 Aug 2022 10:16:02 +0200
> Robert Richter <rrichter@amd.com> wrote:

> > diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c
> > index 88bbd2bb61fc..56b2d222afcc 100644
> > --- a/drivers/cxl/acpi.c
> > +++ b/drivers/cxl/acpi.c
> > @@ -471,13 +471,52 @@ static int cxl_setup_component_reg(struct device *parent,
> >  	return 0;
> >  }
> >  
> > +static int cxl_enumerate_rch_ports(struct device *root_dev,
> > +				   struct cxl_port *cxl_root,
> > +				   struct pci_host_bridge *host,
> > +				   resource_size_t component_reg_phys,
> > +				   int port_id)
> > +{
> > +	struct cxl_dport *dport;
> > +	struct cxl_port *port;
> > +	struct pci_dev *pdev;
> > +
> > +	dport = devm_cxl_add_dport(cxl_root, &host->dev, port_id,
> > +				   component_reg_phys);
> > +	if (IS_ERR(dport))
> > +		return PTR_ERR(dport);
> > +
> > +	port = devm_cxl_add_port(root_dev, &host->dev,
> > +				 component_reg_phys, dport);
> > +	if (IS_ERR(port))
> > +		return PTR_ERR(port);
> > +
> > +	pdev = pci_get_slot(host->bus, PCI_DEVFN(0, 0));
> > +	if (!pdev)
> > +		return -ENXIO;
> > +
> > +	/* Note: The endpoint provides the component reg base. */
> 
> I'm not sure what this comment means.  Which component reg base?

There is no component_reg_phys provided here, so the addr is
CXL_RESOURCE_NONE.

Will improve the comment.

> 
> > +	dport = devm_cxl_add_dport(port, &pdev->dev, 0,
> > +				   CXL_RESOURCE_NONE);
> 
> Trivial: No need to wrap the above.

Right.

Thanks,

-Robert