Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ccde957b-20b1-2fd6-5c90-ad9ee4b8924c@nokia.com>
Date:   Thu, 1 Sep 2022 10:41:58 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] ARM: kasan: Only map modules if CONFIG_KASAN_VMALLOC=n
Content-Language: en-US
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     kasan-dev@googlegroups.com,
        Lecopzer Chen <lecopzer.chen@mediatek.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Alexander Potapenko <glider@google.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Vincenzo Frascino <vincenzo.frascino@arm.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20220827213009.44316-1-alexander.sverdlin@nokia.com>
 <CACRpkdYgZK1oaceme6-EEuV3F=m1L5B3Y8t6z7Yxrx842dgrFw@mail.gmail.com>
From:   Alexander Sverdlin <alexander.sverdlin@nokia.com>
In-Reply-To: <CACRpkdYgZK1oaceme6-EEuV3F=m1L5B3Y8t6z7Yxrx842dgrFw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2ZGUUpKR3BEdzZxZDNUQkk4WjZsZ21QbzlsUDZ6LzU0UnFocDVOdkdFdCtF?=
 =?utf-8?B?dXQ5L00yb0w2RzhuNHhjelA0dkIxWlJQUEMyUTZVMVNJK2hEb1dZZTZGZldQ?=
 =?utf-8?B?VnJtd1JMN1RrYjByeCszaEs5WEYvREFaajhPRS9pZ0RqZ0JJVzR6U2FkOWFL?=
 =?utf-8?B?dlZSalN2MTRjdjgvaFp6UzJvU1h2dVArR0JPUU5LU0hPUUhKQXI2SGpEWmFM?=
 =?utf-8?B?WDh4QkdHaGdvamNTOGx2NFF4M2NVbFhrenFUa05nMXVQNEN0WjhEUlNZZUlt?=
 =?utf-8?B?Zjc3MXVJUFk2RUhXUVBvaGNhN2dEa1pWTThqTE9TeldsRGFndVJzSzVFK0wv?=
 =?utf-8?B?ejJtU0pDQjVlbXZlQU03NklvanJta1hHQXdJOVdaY3IrbkRqeGVnKzQ0VnBs?=
 =?utf-8?B?MkNRalZwREh2K2crZG5QNVhMM1k4eS96eWNaVW9yamZhdFdiZGJNczE2TEh3?=
 =?utf-8?B?K2dKNitSUDI5cm85OTg3djkyY0lRZUtrSHZOd20xZGswUkdsakVnZEpKQlRr?=
 =?utf-8?B?bU9iMWJRcDIwVTYvN3Y2ZmRLM1NXcmpPZHBMaHBnYTM2UUszSE56WWpZOVdt?=
 =?utf-8?B?dGJCRlZiaTkwOFBnWFVhU0phejUrTVRvRUJ2c3hTZ09uV0RsYzNyaU1XSW9W?=
 =?utf-8?B?NkprRHE5NVFvZkdla29SVFJ1SW15WjdySHE0Y09jY2JEMEs4ejRHeFpmbEZ4?=
 =?utf-8?B?b0dCZ1RGOW0wRTRSMUVHSno0KzZCd3JUZjhsRU5tTUxtY0lEbnBTLzJQV2tK?=
 =?utf-8?B?SkdLSGRtcUZmTU5ZMFduYmU1azE1WTE2a0MwdExaQzVPTkxxTU4zYzNGWlk4?=
 =?utf-8?B?WFpWUjdKdlRTSGRLK0RSRjRlN2RRVmpCWk1zV2FPM2pFenkxdXVuQ01vbjZ1?=
 =?utf-8?B?a3ZUK0JySkhKdGhoRHAydXBrZTFzYWZ2dEVKU3V3WFhnOGpZblV4WS9RRzNm?=
 =?utf-8?B?ZENEcWcwTlo3R3hTVTA2NXc3OHFBLzd6YmEwWkx1NVUyTHJIYW9Vb3FBQTlZ?=
 =?utf-8?B?bFg4RU1uSDBvaWNXK2VQbWtJbU1EdzRaR2dVdFZDQUFMQXNENG1lUjBWK2s4?=
 =?utf-8?B?UkRybElhaEF2TW9GbnhkZ3pkNVFFMFp5YXl4V2NEaDViVW1vQi9CZmFPS1Iw?=
 =?utf-8?B?dkVhMS9jc3N6QS9vbGd6UUtIQndEeURKVnJXUUV1eHB1WHVueXVLcWl4S0Fw?=
 =?utf-8?B?UDhTVGtkVURWTDNzNmpMYVlQZlVNL3Q3aHNqdDJYb0p4K0xkUXovYmRxNlAz?=
 =?utf-8?B?Y1VvdjMzWjNCUGhIWEV4YWJIcnd2cm5Jc1FneHFOSWdFMG5TQWlJaU8xNmVM?=
 =?utf-8?B?YnlQK1R1NmlJSFJzSWZjLzQvN0dGWEozdm9FV1RLckd5ZGRVOEJGWVN6aDJ1?=
 =?utf-8?B?QTRuZzJnUzlxNWY0VFBJUllndWFyZ3A3MmtoZDhWSVFPeFFBemxvR1paSFk3?=
 =?utf-8?B?OVFLRGthM0hFVFNEUnFSUkJxc1ExN3hJbEdxSlU3VUdYNjhGVHIzcGI0MTJi?=
 =?utf-8?B?bjdzRW9HT3JPdU52eG5rOE1UNEtXakVsMXBlMVVyYW9TRGI5VzIvdlN0aUFG?=
 =?utf-8?B?WEV3a2Z1NkM5VnViQ2Z6ZmlHcUVkQmFOK2t4bDdjVW9xRGZwOTB3YXlxdU5s?=
 =?utf-8?B?bEFORkk5RmFZWXM1SVgvazd1ci9jQ1JhU1Z4OHpZMzk0UU5URmxIQzcrNnlB?=
 =?utf-8?B?Q2ZGdEVxNzdEbEI2TmRyY2JUS1F5Tzl6eExvRlZBa1NBc1ZERDJ5UTNhZFNz?=
 =?utf-8?B?N1NZOXlVUzVsMW03QzdDNHg4Sm1jd2VnQUIwN0RkckgveC85VHhad3RxUGIr?=
 =?utf-8?B?Zk8yYTB1TGpacjBTNW5FTi9rYTEzbnJtVXY4QnJYZlU5Q0dFMmdzaWYvVFFG?=
 =?utf-8?B?dGxXS1BGYmIxODZTRjdNeWlySk1QUVlvRm4vS2lubDVEZFM4YVZkVVZNdmxJ?=
 =?utf-8?B?dWFKU3liOE9ieC9CUEFsVTFFUUZCMzdIb0c4OWQwN2ROdFZjQzlHbjdMNlFI?=
 =?utf-8?B?RjVVOVl3WE80azBZUjNjOVhMV1RDcWI3aVFEZngzcDV4Y29LK3hjOUtmRnFz?=
 =?utf-8?B?TEErd0tKdVMzUFYzMWVsSGx0bTk2S0U3M1prcW9qV2RTQ1FscGF2RE5pak5S?=
 =?utf-8?B?QVV0N3ZOS3EreG1EWVRZTW1sQ0FHeXhXRlk2SDdoNlkzN0YzV2tjaVZiTTFy?=
 =?utf-8?B?bVE9PQ==?=
X-OriginatorOrg: nokia.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR07MB8230
X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Linus,

On 31/08/2022 11:30, Linus Walleij wrote:
>> -       create_mapping((void *)MODULES_VADDR, (void *)(PKMAP_BASE + PMD_SIZE));
>> +       if (!IS_ENABLED(CONFIG_KASAN_VMALLOC) && IS_ENABLED(CONFIG_MODULES))
>> +               create_mapping((void *)MODULES_VADDR, (void *)(MODULES_END));
> So the way I understand it is that modules are first and foremost loaded into
> the area MODULES_VADDR .. MODULES_END, and then after that is out,
> they get loaded into VMALLOC. See arch/arm/kernel/module.c, module_alloc().

yes, but both areas are managed by __vmalloc_node_range().
 
> If you do this, how are the addresses between MODULES_VADDR..MODULES_END
> shadowed when using CONFIG_KASAN_VMALLOC?

That's the thing, __vmalloc_node_range() doesn't differentiate between address
ranges and tries first to recreate [already existing] shadow mapping, and then
vfree() unconditionally frees the mapping and the page.

vmalloc() KASAN handling is generic, module_alloc() implemented via vmalloc()
is however ARM-specific. Even though we could teach vmalloc() about MODULES_VADDR
and MODULES_END (and don't call kasan_ instrumentation on these), but, this is
ARM-specifics that it's used for this range.
 
>> +       create_mapping((void *)PKMAP_BASE, (void *)(PKMAP_BASE + PMD_SIZE));
> (Splitting this in two steps if probably good in any case.)
> 
> Pls keep me on CC for Kasan ARM patches, thanks! (Maybe I should add some
> MAINTAINERS blurb.)

-- 
Best regards,
Alexander Sverdlin.