Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp466891rwe; Thu, 1 Sep 2022 02:36:21 -0700 (PDT) X-Google-Smtp-Source: AA6agR4nHbvUvfW+XIE8gOi8lYU2wV9KjNNwXmWmRf8JrA2AT0Dk14spL8WsFVgwWSwsxAo4EMY8 X-Received: by 2002:a17:90b:35c5:b0:1fd:9087:6a70 with SMTP id nb5-20020a17090b35c500b001fd90876a70mr7806895pjb.158.1662024981613; Thu, 01 Sep 2022 02:36:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662024981; cv=none; d=google.com; s=arc-20160816; b=qJ053BRGmu05kgejQ2cdCUcwvyV9Y6sRTbA7VeWiDVLWHueVMzmGSmbYt6Kwx5Fple 3q9Gz8OfAdEJgAjpq8p+/PXDRYAu6FDhrAwvafwt4VaxJ0xUmLy34rf3gS1o0lUySVcS jX/PceFhMSKJBpPiavXqNDOMkUzYWYJcDi7JW7gXQemZGdI+DV5E2bCed0i0GNXLbzFD YN+ppXXa3F9gqpDVz+AMdEig2QZ6GvtSjh2292TpjDCQSj6kkkETzHt9DilTG2G/tRhp dwxUhXAyUpUGNkQYKirwUNhmfLm1eWsCrgajpP941SLnhDkTQZqeG55+G+Egh2TgEqbr GRgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=JE5EdXExU9KB2vgJJhQ6V2iSs8d1y3Mi7fJ+Qjt9Auc=; b=TjDbJMJPnLwRQ+Ck8A99ilP/VdkqwO9sv7Jp6YXtCxIV0+1JpPSEdKtbEqC3AfojjF kAx++Zwd26xN7DzntdE1Q6BrNfPseV7KtujPiIxZOz2d1ESSohcRLMWH6jtgLA8tM4jK FF0Bnes0jma/P1clmRGH+ZvWtHJBgaIjloUlJ935G37FbQf2mo6+qNbEnM6hiCOEqrwZ up0fS13zzaUyM0x1Wqrjde9yraQxtGsT55U98rP1vbtWT/QViydLxzmu8WD3yjshtAkp ogQkrDlfspgtdo7TWk9gSxUMz5cg/7BBycZhe8a1rFAId9EU/Otcu1etXBQoQqAr+KO6 XnYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="aB2V/BEr"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d4-20020a170903230400b0016a2a8ac8e0si1996665plh.531.2022.09.01.02.36.10; Thu, 01 Sep 2022 02:36:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="aB2V/BEr"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233439AbiIAICD (ORCPT + 99 others); Thu, 1 Sep 2022 04:02:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232762AbiIAICB (ORCPT ); Thu, 1 Sep 2022 04:02:01 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FA99121424 for ; Thu, 1 Sep 2022 01:01:59 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id m7so14339963lfq.8 for ; Thu, 01 Sep 2022 01:01:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=JE5EdXExU9KB2vgJJhQ6V2iSs8d1y3Mi7fJ+Qjt9Auc=; b=aB2V/BErUKMHkn2ek+qBlKawiRb+bkfxMbWiz40Nt14zziORYJF95FPu6AP71lX8e9 Dq+xkIoWRMeRwuCQ8sRA0XAnX/tNVCIEHAHmbBph4/o0bT5/AIy1KXewrl85KZf+i1KH 2AC7ylvXvi3i611Q/YagrkP2nGljcjbRuIgE8RboPsabxMUUg+xBA/IWYfNruvRijGIa H96paO6sca481TlKtsgLNNR4bk0LF5MYZJPtztf/D9KOfX0wy/T1JTSRf7GFSntFIRrj xUmfOFScRCWDls5Df7UlbH96vkkEkJxequIlOIqRi+256pFmoDr7stoBXjvLiBt5Y08P Go4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=JE5EdXExU9KB2vgJJhQ6V2iSs8d1y3Mi7fJ+Qjt9Auc=; b=f/c9jMFYPlgAUCXglxGCSdsGy+lVHbzMihN4wR6vRe+1pE+WvD77BKX66nqdJp6OEI z7BSbMBceyYmBYOGDEo4XSJ9i2U/yJbLmyTBSJtN0JKGF+LUSjoU88eBqqfon9eYaRwg xIhSiseu2lmM6+vGoqe5XtrjGtyAZtJ2pvAvL2gvgH7buWSO8dt31B6gm4/ZEbV3/naf DRVjxlFIOYVQnHyInQPWAjKhdErPtklp6xlmf2vjKLyl3qhW6K9ZG++DVKKAG7l9VGs6 kyrjV1HGMwbh76FV4+xz6WS1graEjZWYrhEzC1VlIrdyqU0iHHRPtumvlfrLdHb4YO+k gYTQ== X-Gm-Message-State: ACgBeo3mHIS3ME41oDDgy8/PTCDyH2SWUv+t8TJV/VjD8zZM+kWEe5YZ zgS+ghOHoWHc+w6zQCEnZVHjcA== X-Received: by 2002:a05:6512:3dac:b0:494:903a:1f9b with SMTP id k44-20020a0565123dac00b00494903a1f9bmr1877630lfv.498.1662019317892; Thu, 01 Sep 2022 01:01:57 -0700 (PDT) Received: from [192.168.28.124] (balticom-73-99-134.balticom.lv. [109.73.99.134]) by smtp.gmail.com with ESMTPSA id l19-20020a2e9093000000b0025d5eb5dde7sm2344768ljg.104.2022.09.01.01.01.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Sep 2022 01:01:57 -0700 (PDT) Message-ID: <9863bdfc-1de2-62fb-19da-44a68bea3607@linaro.org> Date: Thu, 1 Sep 2022 11:01:56 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 7/7] spi: spi-zynqmp-gqspi: Add tap delay support for GQSPI controller on Versal platform Content-Language: en-US To: Amit Kumar Mahapatra , broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: git@amd.com, michal.simek@amd.com, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, akumarma@amd.com, Naga Sureshkumar Relli References: <20220901054731.7705-1-amit.kumar-mahapatra@xilinx.com> <20220901054731.7705-8-amit.kumar-mahapatra@xilinx.com> From: Krzysztof Kozlowski In-Reply-To: <20220901054731.7705-8-amit.kumar-mahapatra@xilinx.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/09/2022 08:47, Amit Kumar Mahapatra wrote: > @@ -1165,6 +1214,7 @@ static int zynqmp_qspi_probe(struct platform_device *pdev) > struct spi_controller *ctlr; > struct zynqmp_qspi *xqspi; > struct device *dev = &pdev->dev; > + const struct of_device_id *match; > struct device_node *np = dev->of_node; > > ctlr = spi_alloc_master(&pdev->dev, sizeof(*xqspi)); > @@ -1176,6 +1226,13 @@ static int zynqmp_qspi_probe(struct platform_device *pdev) > xqspi->ctlr = ctlr; > platform_set_drvdata(pdev, xqspi); > > + match = of_match_node(zynqmp_qspi_of_match, pdev->dev.of_node); > + if (match) { > + const struct qspi_platform_data *p_data = match->data; There is a helper for that. Use it. Best regards, Krzysztof