Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp522293rwe; Thu, 1 Sep 2022 03:44:40 -0700 (PDT) X-Google-Smtp-Source: AA6agR51wkSIEXQ4tUMkF6Zpci9NQYddQzp9byONqrx5glCKSfOaBW7wJbkJk1uaheNMBRHpGmyG X-Received: by 2002:a05:6402:25c6:b0:43b:7797:d953 with SMTP id x6-20020a05640225c600b0043b7797d953mr28659043edb.254.1662029080502; Thu, 01 Sep 2022 03:44:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662029080; cv=none; d=google.com; s=arc-20160816; b=eWBODfikFUhSWhs6EGSKnlH2Zy0tgVpSXNE0DW/PxvqBq/Wod8Kr6i9k4t+9PcXUrj G8l4F1ceXPe+mKchtodyzajjir/QzkVI5YyrSWT22HuAKMcz1u5L8ssHXZ3qzbUE9YBo 6uy2hJ47bm3wISl92ipPY3/6Wq+EiD9YkHGRIYP6aJGCa0Amodr2p2jcyjicQDcMukkI sGwM376xShvUVCkMOgVDtpxVM8wZeIQ08kZx+t++kLamHHw0F6447RU8oeFQ8F6pjoc5 Uf7ylKgbj6wR5LaH7hz1pMMWv+dX7ckXNXKFDSHjqslZJzbyh/veHEirfkkshh/ABIpD GjJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=JZsOEoaLbu+zMt+js3fg+tvUdsK77yRjrUzilGdmEFQ=; b=XFhmSc2Up8IAorWh/6aYdxDrOiJIsgCtYE0VyvRplpJgiyE8Wr95HHqcwvY5C02FQ1 9PHizu+QO78n7WoINvOMFWpsPzbqVmliNOvVBdtAx9ENz1zVibOj9mnILvz4IXyv7v+o lPyAdleW3COAo9BCAkj/NggCliynfdPNxa7bgkL5cxMqXF6m4Ci2otvzkH3E+GEzFK3j usM74iUH+TCg5+rFl2jxKt/nPc5fgyRGkTVO5dvTjWh5wRYj6BW2dI8w/4xJugUMXfhG ckNcN7b6IGkpwux+nXqCrCSN2hMKobXsFSHjLQHY8PoOeP+/EldbARIw7noVO5/nWyP4 qFlg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q13-20020a50aa8d000000b004477899842dsi1494358edc.499.2022.09.01.03.44.13; Thu, 01 Sep 2022 03:44:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234179AbiIAK2z (ORCPT + 99 others); Thu, 1 Sep 2022 06:28:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234044AbiIAK2h (ORCPT ); Thu, 1 Sep 2022 06:28:37 -0400 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58FED27B16 for ; Thu, 1 Sep 2022 03:28:36 -0700 (PDT) Received: from localhost.localdomain (unknown [83.149.199.65]) by mail.ispras.ru (Postfix) with ESMTPSA id E5B9B40D403D; Thu, 1 Sep 2022 10:28:31 +0000 (UTC) From: Valentina Goncharenko To: Jaroslav Kysela Cc: Valentina Goncharenko , Takashi Iwai , Eliot Blennerhassett , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: [PATCH] ALSA: asihpi - Remove useless code in hpi_meter_get_peak() Date: Thu, 1 Sep 2022 13:28:14 +0300 Message-Id: <20220901102814.131855-1-goncharenko.vp@ispras.ru> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The hpi_meter_get_peak() function contains the expression "hm.obj_index = hm.obj_index", which does not carry any semantic load. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 719f82d3987a ("ALSA: Add support of AudioScience ASI boards") Signed-off-by: Valentina Goncharenko --- sound/pci/asihpi/hpifunc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/pci/asihpi/hpifunc.c b/sound/pci/asihpi/hpifunc.c index 1de05383126a..24047fafef51 100644 --- a/sound/pci/asihpi/hpifunc.c +++ b/sound/pci/asihpi/hpifunc.c @@ -2020,7 +2020,6 @@ u16 hpi_meter_get_peak(u32 h_control, short an_peakdB[HPI_MAX_CHANNELS] HPI_CONTROL_GET_STATE); if (hpi_handle_indexes(h_control, &hm.adapter_index, &hm.obj_index)) return HPI_ERROR_INVALID_HANDLE; - hm.obj_index = hm.obj_index; hm.u.c.attribute = HPI_METER_PEAK; hpi_send_recv(&hm, &hr); -- 2.25.1