Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp570425rwe; Thu, 1 Sep 2022 04:35:01 -0700 (PDT) X-Google-Smtp-Source: AA6agR7ADFA93JVB9CAE9rjP7FRqEeH1neUYACbDB9Ng7tTTcfmFzWprtjTvCQE0WQaFsY8LrXYs X-Received: by 2002:aa7:cdc5:0:b0:447:91ef:a3cd with SMTP id h5-20020aa7cdc5000000b0044791efa3cdmr27484023edw.168.1662032101677; Thu, 01 Sep 2022 04:35:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662032101; cv=none; d=google.com; s=arc-20160816; b=BoPLaTy+ByL8JWau9eLIiMPK/4KNvrQcgBeEC92tHF3StbVN6YQCHdBoAPPFNdbBAk YkLROfCYnvV9Zc9IYs8jre47EGpriNC5sLxY+FQme/8sFOozNmNr+10jOCgT4NtSv243 +ZQFNRC+Z1oaJX2dIxYrdywXRcWiigALrnXzd+O4bXc9zL+j2T+Ljr4L465JmF9K1u9H jUzK+xT7jj6B1Q28DZSCVtfIJNW1u82BHpAOurZeJzdvZuvb6SCc5atYy5RdS/ujO/c1 h51Twoog/dAaLkea7f+KzbyCuXceBdxwaoYCHUZ5c60UdmLth0stsD3ovFiYgDY9JeX8 Ms3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=XXk0/pr+kfIP/a+RlyoQZ9btl+mQ+uNJUbSHTisPSHw=; b=nh58X6oRiD6u6VfwMOnlx32dZZiuiXhPc7B/NdWLXoxrfKYhggQmYfjRDTUgIPPXOu ePzZ3JMB85OGTeriqk4LZescF8oibpBTt1UD+l/IYc04vym8TxV4t0h+e0XSjDULl4iU 35vPeXTurHv8aIIrMUuL9evjr9wVwz7gWG7yiuuotnTYisiLxqICSSaU6CJvO/te25sI sxxdwrisCpNVr6XokceNQd6VHQwiPqsy69PAegJVhLCvof4T5carT2NWNvF/OznUbIOB 1ZFCvOvmY82ryEW5ule9ul7ETpWGY8cjzpp/9mEOCxxRQax7b/ys5x8nUkPfF6amx70k l8PQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sh7-20020a1709076e8700b00731646a574esi13313085ejc.839.2022.09.01.04.34.35; Thu, 01 Sep 2022 04:35:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233923AbiIAKy3 (ORCPT + 99 others); Thu, 1 Sep 2022 06:54:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233399AbiIAKy1 (ORCPT ); Thu, 1 Sep 2022 06:54:27 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B9D6130A12; Thu, 1 Sep 2022 03:54:27 -0700 (PDT) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4MJHrh6JYJz1N7k9; Thu, 1 Sep 2022 18:50:44 +0800 (CST) Received: from huawei.com (10.175.103.91) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 1 Sep 2022 18:54:25 +0800 From: Zeng Heng To: CC: , , Subject: [PATCH -next] xfs: missing space in xfs trace log Date: Thu, 1 Sep 2022 19:02:05 +0800 Message-ID: <20220901110205.565167-1-zengheng4@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500022.china.huawei.com (7.185.36.162) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add space between arguments would help someone to locate the key words they want, so break quoted strings at a space character. Such as below: [Before] kworker/1:0-280 [001] ..... 600.782135: xfs_bunmap: dev 7:0 ino 0x85 disize 0x0 fileoff 0x0 fsbcount 0x400000001fffffflags ATTRFORK ... [After] kworker/1:2-564 [001] ..... 23817.906160: xfs_bunmap: dev 7:0 ino 0x85 disize 0x0 fileoff 0x0 fsbcount 0x400000001fffff flags ATTRFORK ... Signed-off-by: Zeng Heng --- fs/xfs/xfs_trace.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index f9057af6e0c8..cb7c81ba7fa3 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -1170,7 +1170,7 @@ DECLARE_EVENT_CLASS(xfs_dqtrx_class, __entry->ino_res_used = qtrx->qt_ino_res_used; __entry->icount_delta = qtrx->qt_icount_delta; ), - TP_printk("dev %d:%d dquot id 0x%x type %s flags %s" + TP_printk("dev %d:%d dquot id 0x%x type %s flags %s " "blk_res %llu bcount_delta %lld delbcnt_delta %lld " "rtblk_res %llu rtblk_res_used %llu rtbcount_delta %lld delrtb_delta %lld " "ino_res %llu ino_res_used %llu icount_delta %lld", @@ -1602,7 +1602,7 @@ TRACE_EVENT(xfs_bunmap, __entry->caller_ip = caller_ip; __entry->flags = flags; ), - TP_printk("dev %d:%d ino 0x%llx disize 0x%llx fileoff 0x%llx fsbcount 0x%llx" + TP_printk("dev %d:%d ino 0x%llx disize 0x%llx fileoff 0x%llx fsbcount 0x%llx " "flags %s caller %pS", MAJOR(__entry->dev), MINOR(__entry->dev), __entry->ino, -- 2.25.1