Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Sep 2022 11:54:25 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Lee Steve <steve.lee.analog@gmail.com>
Cc:     lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
        linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        krzk@kernel.org, ryans.lee@analog.com
Subject: Re: [PATCH] ASoC: max98390: Remove unnecessary amp on/off conrtol
Message-ID: <YxCPYbPsEyZmuHOI@sirena.org.uk>
References: <20220826023504.6183-1-steve.lee.analog@gmail.com>
 <Yw+OCnOgYUOWdIEx@sirena.org.uk>
 <CA+Fz0PZStYOZhNpRQCCVKxaDmPPq_PwvWrxfWbq=sBNKrZzzNg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Cck+RFJ0eKZVFr+e"
Content-Disposition: inline
In-Reply-To: <CA+Fz0PZStYOZhNpRQCCVKxaDmPPq_PwvWrxfWbq=sBNKrZzzNg@mail.gmail.com>
Precedence: bulk


--Cck+RFJ0eKZVFr+e
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Sep 01, 2022 at 02:57:19PM +0900, Lee Steve wrote:
> On Thu, Sep 1, 2022 at 1:36 AM Mark Brown <broonie@kernel.org> wrote:

> > I can't see anything which ensures that this is the case?  Should there
> > be a check which returns an error if the output is not enabled, or
> > should the function check the current state and preserve it at the end?
> > I can see that this would fix problems with it being disabled when
> > callibrating.

>  As your comment, this can fix amp being disabled when calibrating.
> And this also fix the case that music play right after calibration.
> Actually, calibration process should start mute playback before
> trigger this function.
> AMP disable/enable control in calibration function can break sync with
> userspace enable/disable control.

Right, so that sounds like there should be something which checks the
current state and doesn't start callibration unless the device is in a
sensible state.

--Cck+RFJ0eKZVFr+e
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmMQj2AACgkQJNaLcl1U
h9DP7wf9GATVAcXHSK80KY9ZOA+wsUyGyhrWjapV4h1Cs8h62KfnYLN+9v64Qkfj
j1pfKF+FSvEmfd7UglMjhIxPLvpY6nkBrprGFxGonBKJkPN/B6eQXpHJropn0hgU
zSgyVWNexi/JQCdRZlzGKq2eZasgSUr30XbmTo+IS0+ZOVjnYpbOu6bQgWw7Xcpb
CiwCyQympPrbatTJjcksnqpxIILphXddI854GV+6JDro0Ff+sVwh/Wy9KlpmJTmO
zQ3UeW/1ikooxqlk1nuAXmUQbwF71zaF4MBXfwih1ZOiuRCRUqHOSatHwXQDyfjY
iXLCGJBx6yVVMbRp0emPUWNdN3Vu/A==
=O3of
-----END PGP SIGNATURE-----

--Cck+RFJ0eKZVFr+e--