Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220831052734.3423079-1-song@kernel.org> <20220831160111.a6e7d17785ca21ce7c43981c@linux-foundation.org>
 <CAPhsuW4SGguyoFKpN8S=jFCWfLiDM-f5QwV7UPwkQ=LjQEXaNg@mail.gmail.com>
In-Reply-To: <CAPhsuW4SGguyoFKpN8S=jFCWfLiDM-f5QwV7UPwkQ=LjQEXaNg@mail.gmail.com>
From:   Uladzislau Rezki <urezki@gmail.com>
Date:   Thu, 1 Sep 2022 14:16:55 +0200
Message-ID: <CA+KHdyUDGkUBtnAcvu+NB=S7chp_1N3XviTkkMoP-8LrLJQgbg@mail.gmail.com>
Subject: Re: [PATCH] mm/vmalloc: Extend find_vmap_lowest_match_check with
 extra arguments
To:     Song Liu <song@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Linux-MM <linux-mm@kvack.org>,
        open list <linux-kernel@vger.kernel.org>,
        Song Liu <songliubraving@fb.com>, Baoquan He <bhe@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

This is only for debug purpose.

Even without this patch, the debug path would work correctly. The
difference is just only in
whether roots are hardcoded or passed over function paramter.

--
Uladzislau Rezki

On Thu, Sep 1, 2022 at 2:47 AM Song Liu <song@kernel.org> wrote:
>
> On Wed, Aug 31, 2022 at 4:01 PM Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > On Tue, 30 Aug 2022 22:27:34 -0700 Song Liu <song@kernel.org> wrote:
> >
> > > find_vmap_lowest_match() is now able to handle different roots. Make
> > > similar changes to find_vmap_lowest_match_check() and
> > > find_vmap_lowest_linear_match() to handle different trees.
> >
> > What are the runtime effects of this change?
>
> The code is gated by DEBUG_AUGMENT_LOWEST_MATCH_CHECK. It
> is only compiled when the developer enables it explicitly. Therefore,
> there isn't
> any runtime effect.
>
> Thanks,
> Song


-- 
Uladzislau Rezki