Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Sep 2022 16:41:48 +0300 (EEST)
From:   =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To:     Kumaravel.Thiagarajan@microchip.com
cc:     andy.shevchenko@gmail.com,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        u.kleine-koenig@pengutronix.de, johan@kernel.org,
        wander@redhat.com, etremblay@distech-controls.com,
        macro@orcam.me.uk, geert+renesas@glider.be, jk@ozlabs.org,
        phil.edworthy@renesas.com, Lukas Wunner <lukas@wunner.de>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-serial <linux-serial@vger.kernel.org>,
        UNGLinuxDriver@microchip.com
Subject: RE: [PATCH v1 tty-next 1/2] 8250: microchip: pci1xxxx: Add driver
 for the quad-uart function in the multi-function endpoint of pci1xxxx
 device.
In-Reply-To: <BN8PR11MB3668BAC07D493EE02AEAEB14E97B9@BN8PR11MB3668.namprd11.prod.outlook.com>
Message-ID: <63f48d1-f716-5040-c8d1-486087bd1c5e@linux.intel.com>
References: <20220830180054.1998296-1-kumaravel.thiagarajan@microchip.com> <20220830180054.1998296-2-kumaravel.thiagarajan@microchip.com> <CAHp75VfraADCTmZATWTSsYtC5uk5bc=WDVVm0jtUVO90xdFd9g@mail.gmail.com>
 <BN8PR11MB3668BAC07D493EE02AEAEB14E97B9@BN8PR11MB3668.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 1 Sep 2022, Kumaravel.Thiagarajan@microchip.com wrote:

> > > +       const unsigned int standard_baud_list[] = {50, 75, 110, 134, 150, 300,
> > > +                                               600, 1200, 1800, 2000, 2400, 3600,
> > > +                                               4800, 7200, 9600, 19200, 38400, 57600,
> > > +                                               115200, 125000, 136400, 150000, 166700,
> > > +                                               187500, 214300, 250000, 300000, 375000,
> > > +                                               500000, 750000,
> > > + 1000000, 1500000};
> > 
> > Why?!
>
> The standard baud rates are handled within serial8250_do_set_termios 
> which is invoked from within mchp_pci1xxxx_set_termios in first place. 
> Hence if it matches with any of the standard baudrates,
> it can return immediately.

Care to explain why the baudrates in your table don't match those in 
tty_baudrate.c? ...It makes no sense to me that you call these "standard 
baud rates".


-- 
 i.