Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Sep 2022 16:16:34 +0300
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
To:     Dmitry Rokosov <ddrokosov@sberdevices.ru>
Cc:     "broonie@kernel.org" <broonie@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "rafael@kernel.org" <rafael@kernel.org>,
        "jic23@kernel.org" <jic23@kernel.org>,
        kernel <kernel@sberdevices.ru>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] regmap: introduce value tracing for regmap bulk
 operations
Message-ID: <YxCwstzaKm7qhCWV@smile.fi.intel.com>
References: <20220816181451.5628-1-ddrokosov@sberdevices.ru>
 <CAHp75VfSOL5R1JdH-RS4PEXT1dEwuFGsmUPfkAp7zdDEMGzzjw@mail.gmail.com>
 <20220831004530.zhvd7ehndqwmqgve@Rockosov-MBP>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220831004530.zhvd7ehndqwmqgve@Rockosov-MBP>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Aug 31, 2022 at 03:45:30AM +0300, Dmitry Rokosov wrote:

...

> > > +               if (val)
> > > +                       memcpy(__get_dynamic_array(buf), val, val_len);
> > 
> > I'm probably missing something, but what this condition prevents from?
> 
> In general, this condition prevents memcpy from being executed when
> tracepoint is called with a null pointed buffer.

If we got a NULL pointer here, we already in a lot of troubles.
I believe the check is not needed.

Otherwise the function prints garbage.

I will send a series to remove that and clean up the file.

-- 
With Best Regards,
Andy Shevchenko