Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp762626rwe; Thu, 1 Sep 2022 07:18:25 -0700 (PDT) X-Google-Smtp-Source: AA6agR5DRw1SU0Bl1oAhMeL2hmtQZcs4rKdc7sODdrSel/nTTjZa2qPdVQTFJww5brm1z2k/LMeI X-Received: by 2002:a17:907:97cd:b0:731:5d0:4434 with SMTP id js13-20020a17090797cd00b0073105d04434mr22581821ejc.603.1662041905210; Thu, 01 Sep 2022 07:18:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662041905; cv=none; d=google.com; s=arc-20160816; b=dR9wzRWes0FLO94c1gPT1xsEtoSAFaQho78h8hLq61zx5thbrOXBRFMLZ9jEaC9N5u WwSHdOIRAQlUsmO5070mHwsz4++tuBVov9UUB6RHI9MB7PeB8rM+wdyDzMpu7P0zcyn9 8PKl7Sw4HKudT6opCLAYMz0TRB++hu9JfroCWwkTfGFlfWve7W8nE+c6aaRTuZfvp9ns mEYMcMUe5E+7b1Wl5hI8VEOn8AQkTChJthIebXS4YEHL5gqrT+xer9asyaOhX7RkLSiO G+vf1xv2855PLDTUKpKUZNqnpg1lLgfnr76IIlZyTyA+e+wqkyP01XX9G8WoyKRnJ874 8ceg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ErJ0HYTeWtEwPWkKjxUMjvfOzkq3x7pnzQs4DfaztQI=; b=JkMJArgsZdUUDAzVJ1q2xj4Hi14MQ+i1r2NjlVQSf89vRHyIKNO26cUEVsdlPrQj96 61DH3LKgiO33/FvGQvFStvaoOn2P5Rd6NJBK0ZDpzsFQ4uDIHGKS3r3YAS6sPPVXrxI9 +kcdbFaaxTUISj1YiO7dRtH7Aq7Dgh7m45RtESIh+uMcmwtGKYQj6yrSHFUDFGKCD+bL J0RCLe4ZmmcrUS6oeyjLThd8vU+0pEgm6rK8OBfxaWOPdRLDQDRCL0e+L0VEH5oFYZcy LSHYRb+EjsCCxhNAZf4hM+EazPwUQuFWlvGbKTO9pWdzA8zVqpwEoWCDmdBf18boLBCm AhPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=gVBhlXo+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j21-20020a50ed15000000b0044712896b73si1486756eds.452.2022.09.01.07.17.58; Thu, 01 Sep 2022 07:18:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=gVBhlXo+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233971AbiIANxg (ORCPT + 99 others); Thu, 1 Sep 2022 09:53:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231351AbiIANxe (ORCPT ); Thu, 1 Sep 2022 09:53:34 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB84B311 for ; Thu, 1 Sep 2022 06:53:32 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id n65-20020a17090a5ac700b001fbb4fad865so2641948pji.1 for ; Thu, 01 Sep 2022 06:53:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=ErJ0HYTeWtEwPWkKjxUMjvfOzkq3x7pnzQs4DfaztQI=; b=gVBhlXo+kWUOUAdPW/8QSC/spoR7aDlJ+7CKxJMA9X4LfDMCbY0jOUYmO6zAh3erUc oDX28M1zm7XifH6YMEdep0LvM0DAR1RzZHK1dKgbF41FQwrbtMpSsXNHw8GmdWQmPLoR feQD2gsEzTxU2EY8Nh9t0hdI4ycnocSPLPo1OcTMrlIpjH6dPDOFTlzq+GCed9ZkdD7O 2QH4VVZY1+/PuOV8c/EZxWWqQTLedlbdpCU4hEVh2OKSofLAKmn/mCoi53a+yjT8c/Kj z+FG2shz1RwkAqnaACpuZdnx6ThYZcxNI1PMQxDakoPYcFYBvOhi+ZLBfGSZ+ygoClXr 2mHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=ErJ0HYTeWtEwPWkKjxUMjvfOzkq3x7pnzQs4DfaztQI=; b=iwk19bbmfzEIN/AvxCKgq33P7jGULspxMcrpnfCV9I4mxjijWr/c4ZzcEOHFkFzjUQ W7ufrHCwtIO3LmdNwU076rMBIUxUYpverdxm6RnMD7Rlhl99e2jXrXHCUdGw1B/LkpTn sa+rw97Dt8+TpZai6a94XMk4StMZ9muHstv4xxisiMIEo+0T1t2UEcd8yeKxipzB9eHs 8z44cGevyjg6asNT/MnCS+cZUYCNLRsulWmrlrbulkrtk5cK1RzxD6u1PcXv1yGyIuXf fx1+GzgbrtIfBEsKHryyDWaJTnY0QybToAOKRruMmLb6z4zMgzzsexpDlYXw/xPPhyU7 mYQQ== X-Gm-Message-State: ACgBeo3sysQO7Ce1kMcYozMf700ae3jQ0yaMbVsEwIOeLW1tn9wJI8jX DHquWDeYZqM9pWl/qFD7Q8xMz1ydyKHQYQ== X-Received: by 2002:a17:902:7845:b0:16e:d647:a66c with SMTP id e5-20020a170902784500b0016ed647a66cmr29779570pln.64.1662040412275; Thu, 01 Sep 2022 06:53:32 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id k88-20020a17090a3ee100b001fd86f8dc03sm3359852pjc.8.2022.09.01.06.53.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Sep 2022 06:53:31 -0700 (PDT) Date: Thu, 1 Sep 2022 13:53:28 +0000 From: Sean Christopherson To: Maxim Levitsky Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Suravee Suthikulpanit , Li RongQing Subject: Re: [PATCH 03/19] Revert "KVM: SVM: Introduce hybrid-AVIC mode" Message-ID: References: <20220831003506.4117148-1-seanjc@google.com> <20220831003506.4117148-4-seanjc@google.com> <17e776dccf01e03bce1356beb8db0741e2a13d9a.camel@redhat.com> <84c2e836d6ba4eae9fa20329bcbc1d19f8134b0f.camel@redhat.com> <59206c01da236c836c58ff96c5b4123d18a28b2b.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 01, 2022, Maxim Levitsky wrote: > There was actually a patch series that was fixing it, but you said, just like me, > that it is not worth it, better to have an errata in KVM, since guest should not use > this info anyway. I didn't object to it, and neither I do now, but as you see, > you also sometimes agree that going 100% to the spec is not worth it. > > > I hope you understand me. Yep. And rereading what I wrote... I didn't intend to imply that you personally aren't operating in "good faith" or whatever is the right terminology. What I was trying to explain is why I sometimes speak in absolutes. When there is a bug/regression and KVM is clearly violating spec, it's not a matter of opinion; KVM is broken and needs to be fixed. Of course, one could argue that that's an opinion in and of itself...