Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Thu, 1 Sep 2022 16:02:53 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     =?utf-8?Q?Micha=C5=82?= Winiarski <michal.winiarski@intel.com>
Cc:     dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org,
        linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Gow <davidgow@google.com>,
        Javier Martinez Canillas <javierm@redhat.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Jonathan Corbet <corbet@lwn.net>, Helge Deller <deller@gmx.de>,
        =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>
Subject: Re: [PATCH] drm: Simplify testing on UML with kunit.py
Message-ID: <20220901140253.6ebvykv35kyc3v3w@houat>
References: <20220901133621.353270-1-michal.winiarski@intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="lymi6tif3g4nxejp"
Content-Disposition: inline
In-Reply-To: <20220901133621.353270-1-michal.winiarski@intel.com>
Precedence: bulk


--lymi6tif3g4nxejp
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Sep 01, 2022 at 03:36:21PM +0200, Micha=C5=82 Winiarski wrote:
> DRM depends on IOMEM and DMA, introduce an additional Kconfig to pull in
> IOMEM and DMA emulation on UML.
> Since --kconfig_add usage is no longer needed, remove it from
> documentation.
>=20
> Signed-off-by: Micha=C5=82 Winiarski <michal.winiarski@intel.com>
> ---
>  Documentation/gpu/drm-internals.rst | 7 +------
>  drivers/video/Kconfig               | 4 ++++
>  2 files changed, 5 insertions(+), 6 deletions(-)
>=20
> diff --git a/Documentation/gpu/drm-internals.rst b/Documentation/gpu/drm-=
internals.rst
> index 5fd20a306718..c264a9587d21 100644
> --- a/Documentation/gpu/drm-internals.rst
> +++ b/Documentation/gpu/drm-internals.rst
> @@ -228,16 +228,11 @@ follows:
> =20
>  .. code-block:: bash
> =20
> -	$ ./tools/testing/kunit/kunit.py run --kunitconfig=3Ddrivers/gpu/drm/te=
sts \
> -		--kconfig_add CONFIG_VIRTIO_UML=3Dy \
> -		--kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=3Dy
> +	$ ./tools/testing/kunit/kunit.py run --kunitconfig=3Ddrivers/gpu/drm/te=
sts
> =20
>  .. note::
>  	The configuration included in ``.kunitconfig`` should be as generic as
>  	possible.
> -	``CONFIG_VIRTIO_UML`` and ``CONFIG_UML_PCI_OVER_VIRTIO`` are not
> -	included in it because they are only required for User Mode Linux.
> -

I'm all for removing that part of the documentation, but because
6fc3a8636a7b, in 6.0 should address this entirely? Why would we need
that other symbol?

Maxime

--lymi6tif3g4nxejp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYxC7jQAKCRDj7w1vZxhR
xQglAP9zmZdegnfQtBGMTWrj4fjVJG3GP2M4l3bTsoldBLBhWwEAvG3BsOVQM1Lq
eqk061Y9Ou0biCjvdHK/I9lNIvRPiAM=
=uNx+
-----END PGP SIGNATURE-----

--lymi6tif3g4nxejp--