Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Sep 2022 16:49:09 +0200
From:   =?utf-8?Q?Micha=C5=82?= Winiarski <michal.winiarski@intel.com>
To:     Maxime Ripard <maxime@cerno.tech>
CC:     <dri-devel@lists.freedesktop.org>, <linux-doc@vger.kernel.org>,
        <linux-fbdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Gow <davidgow@google.com>,
        Javier Martinez Canillas <javierm@redhat.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Jonathan Corbet <corbet@lwn.net>, Helge Deller <deller@gmx.de>,
        =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>
Subject: Re: [PATCH] drm: Simplify testing on UML with kunit.py
Message-ID: <20220901144909.6rihfj4mgklk3ddf@nostramo.hardline.pl>
References: <20220901133621.353270-1-michal.winiarski@intel.com>
 <20220901140253.6ebvykv35kyc3v3w@houat>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220901140253.6ebvykv35kyc3v3w@houat>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWFNeTlaM0VxQUsvZ1A0QzFVeFdQWnBGVXd1WUlGd0hKSHlLWFQ4dFJIcm1Y?=
 =?utf-8?B?YjMybXV0REV4SUk1WVNDVXNhZnlyMC9qeGJvQk9EVmY1UDczUGZOeW5hWVlv?=
 =?utf-8?B?TTQxV01pUE9aRGc1R2RnSmF0WmZVdUNTR0VydDl0K3c3ekdxSWVFdG5HdGdv?=
 =?utf-8?B?cnl1cThIMXhhUWFmRHRMOTF1QlZ0UEkzV3MwVEFaTUxCTVpFU0lHSEhpK3Bh?=
 =?utf-8?B?V01sZVIvcS95aDBJNWt3YWVIZXRCOW92djkrZ2g5NTdrMkV2THM2RS83SHgy?=
 =?utf-8?B?K3d6eHVac3FBN3hXR0xwcFdNUkk0cTBMTGduSzhZazJvbmdBcVloQzZBOHlr?=
 =?utf-8?B?MjF6eThoVjRDUkk1aUtYMDM1MlJiMVVEV1pXQlBZWlZvRzdRUWFvdlRpcGRn?=
 =?utf-8?B?OWVKc3pNblpZL0JaRlhGZm9mNGFmcEgvY2JCT3BaUzNCYjEvR0hJUHZUdElm?=
 =?utf-8?B?dkhkeWFzTmxXR214TGg4T1M0VDZGQnBZdVcrK0V6Zyt2UWJjZFg3Zlg4YlQ5?=
 =?utf-8?B?Um9hT3RCNVJMc2FQRysrdG96ejJXbTcxOHJnVnkrUTdZa3FZakVmSHJ1anFN?=
 =?utf-8?B?dWwxSERndTU1N1RqamxZVXZubmxVczlLaEV6VFZCNENPdmV1S2p6aFJIdU9w?=
 =?utf-8?B?bUVSUmx0bG80Wjh5dVlKcmloQWgwbVRpdmhJYUhFbDZvUVdHWVA3ZXE4Rjg1?=
 =?utf-8?B?SmdnaFQrRkNZaGJWd0w5cThOdDU5aWpJWXg2YzRRcG85Wi8wTmtCLytIWENq?=
 =?utf-8?B?dWRxRDRzS2xMTUppV1FobGgxWXZUY1FldjdKY2hkanpqVTE5Sk14RU1uMFU3?=
 =?utf-8?B?SUNqNldiOXdRQWR6bEdJMDFodm56U3hyOW53dktGMC9ybVdNd3d2UytoWHdw?=
 =?utf-8?B?OC9JbFVNVVpMV0l3U0lMOGE3d0J6Z1p6ZzFSTmFJdjhkMkJ0QUMwN000QkRq?=
 =?utf-8?B?RytSM2xKQkx6bnBNeVpySTFMWE1OdEtZS3NBVzFwSVpnN29XWktJR25VVEdo?=
 =?utf-8?B?amZia3lDVmhuUXVMaExFVnE0SVJ6Tml5T0EzenRHTDRydXBvZC9ENWdJa05F?=
 =?utf-8?B?WGdVbFlHMXBacXUrSnp3dDZWNkZYMUtvOVRHeUlJN1JjTE53MXBkMDdSZVUw?=
 =?utf-8?B?QXoxMWF4Q2xEVHQwU2JUdjdPcEV4YzkzanpkdkROVjI2Q0tVV1VPTFFIaDVX?=
 =?utf-8?B?K3YwaUJNTk5jWHRTL1MwcUxMdk1rWTkxSTZYMDRDNk9VQlk5S3dwbGY4QitK?=
 =?utf-8?B?dWNHeHUvTW8wTEw1aDM5MXdRVG1OKzFQcTk0ajhCYTMvOEdsYXJnN1NYa2l1?=
 =?utf-8?B?Q1ZpcmUvT3ZqZEZFODlGWFJGdlFOYWJwbU5UZ0tNcWxnUm0rU2g2NzdrbC9M?=
 =?utf-8?B?SCtMR2NGV0VzUVk3VnpKWW5TVDNTWGV0NnJ0eng3RExpUFpGbWhwWXd3dk9L?=
 =?utf-8?B?OEFrQU1zcENKNHJackZoSTZ6QzVuM09lanQzenQ3R3lNTytUKzBsRHRGUG5G?=
 =?utf-8?B?bmhXNkVwSy9hSE9KOUVMOUt2MFhUUFZMRzRJVmJzYW8za1RkZDdaK3pUSC9G?=
 =?utf-8?B?NjZwTm4rTkhzMDlLaWcyV1g3b3FIcEVHMnVUQW5XS2Y0OU5DZWN0Q2cyVlV1?=
 =?utf-8?B?b0JpdlZDVzhtWm8xT2hJWC9WQkdZeEo0biswZ3l4WmFsRVpMalc0TmxXNU1Q?=
 =?utf-8?B?c2dRdzRoSmJhTnZnQW14NHkyYlNxRU94dUx5WXdIWVphb3Fsdkp4K0J2NENt?=
 =?utf-8?B?blphQkZ3NUQwT25qSC9TTDlOVnhoTHVvSlRWVDBUTG1WRDZISlNxcU5BLzNs?=
 =?utf-8?B?WlFxc1VEd3h4OXF5Tk1FUXl0dE83UnZMaTc0bTJwUGh1OHZkd3BKMk80OHNz?=
 =?utf-8?B?QTNENXR3YXhPdU5jVzc4MUFFT0ZVMEF1NDFTYjFjUTFmSHhLSDVhQVY2bCtt?=
 =?utf-8?B?Rk0rT0NJOENMQVZHYjdtc1QxZUt6MUREeE95OTUyUTBKSWZjWkhsQzNhTGo4?=
 =?utf-8?B?ZmxPMWJ3SVcyeHlRbTd2OUZiSFE5aENTTis1SkZ3bW96QkRDaUNtWnQyM0hS?=
 =?utf-8?B?SDVJQWhhZHhmajlzbDZYUDhyUHNKL2Rpek8xbTIrTWdYeU9MaXlkMTJNdUJR?=
 =?utf-8?B?ZCtqTHduby8zRFVBb1E3a05mM0NwNGtoV1ZvaGNtR2VtTWpCdUxKeXdyZnRE?=
 =?utf-8?B?aVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3fb50caf-78fc-4eab-6dd7-08da8c29255a
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5373.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 14:49:17.6296
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vxaCmgpQ2T0Fb/bKDR5xz5LlNLRzYME1wXQQxIpOdFeHH/98zjxEbznvgrU0NkmPu0+pFdkQYzm3wC3bOkMHTEBhLyBudQ/lQQJKgFyEF+o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6511
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 01, 2022 at 04:02:53PM +0200, Maxime Ripard wrote:
> Hi,
> 
> On Thu, Sep 01, 2022 at 03:36:21PM +0200, Michał Winiarski wrote:
> > DRM depends on IOMEM and DMA, introduce an additional Kconfig to pull in
> > IOMEM and DMA emulation on UML.
> > Since --kconfig_add usage is no longer needed, remove it from
> > documentation.
> > 
> > Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
> > ---
> >  Documentation/gpu/drm-internals.rst | 7 +------
> >  drivers/video/Kconfig               | 4 ++++
> >  2 files changed, 5 insertions(+), 6 deletions(-)
> > 
> > diff --git a/Documentation/gpu/drm-internals.rst b/Documentation/gpu/drm-internals.rst
> > index 5fd20a306718..c264a9587d21 100644
> > --- a/Documentation/gpu/drm-internals.rst
> > +++ b/Documentation/gpu/drm-internals.rst
> > @@ -228,16 +228,11 @@ follows:
> >  
> >  .. code-block:: bash
> >  
> > -	$ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests \
> > -		--kconfig_add CONFIG_VIRTIO_UML=y \
> > -		--kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=y
> > +	$ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests
> >  
> >  .. note::
> >  	The configuration included in ``.kunitconfig`` should be as generic as
> >  	possible.
> > -	``CONFIG_VIRTIO_UML`` and ``CONFIG_UML_PCI_OVER_VIRTIO`` are not
> > -	included in it because they are only required for User Mode Linux.
> > -
> 
> I'm all for removing that part of the documentation, but because
> 6fc3a8636a7b, in 6.0 should address this entirely? Why would we need
> that other symbol?

We don't. I wasn't aware that 6fc3a8636a7b exists and had this one in my tree
prior to 6.0.
(well... technically we do need those other symbols and don't need VIRTIO, but
since CONFIG_UML_PCI_OVER_VIRTIO pull in those two, it also works).
Since docs were not updated, I didn't see any conflicts when rebasing.

Sorry for the noise, please ignore this patch.

-Michał

> 
> Maxime