Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp816180rwe; Thu, 1 Sep 2022 08:04:11 -0700 (PDT) X-Google-Smtp-Source: AA6agR67whfBbqrCw+hk2guwxGcHGVQz/3bBr8I5sPZKPsQVf1V26+cPObxnMOXBL1mZ1Rk7M+RZ X-Received: by 2002:a17:903:41c6:b0:174:3acf:8294 with SMTP id u6-20020a17090341c600b001743acf8294mr30600912ple.118.1662044651613; Thu, 01 Sep 2022 08:04:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662044651; cv=none; d=google.com; s=arc-20160816; b=xqZj6P8oUCOlwWICONUYuToGFrjkM3g05b1MBpRLS0zkGhUYpAO61ZhZIjagx/uc4S NOlCFsv5Jun8vlP0ci0iDArTXk8xyC1esjjldOJN20xuZrSAzzTljuQr9Z8G6u7s9gOK 0CwbaHk1Vvmm8dV+mT83GzG93vWqDX9iPoMgw52O3RKiaOCe+XDqoRGOvmUIXdBOZdz3 AQlNTWzbLNEo5HNyMQZz/oQFxZK0F8sVsI7TZK4o18qZhOxce/dgwp/oF8Hp8y5q2b9S eBYX1sKTc9UYfc96IawLRxd/o0hcB4OKo5Ch+kfxXBDVfxbUBgguucQ/7/2GdNdhg8D9 qPTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=3EiTdDvrKaD/IhEiKjmxY5HGYoEYPN+BKjgkg1/V7IY=; b=b9FD+Ak/L3QQA3fH+o+P7aaieuuFk1CXh+PbymgfsV8SMYqvjhW+C049c7QbPouwOZ LxHj8Zf5oR9y+yPsC3L3550Rf1ksjdk7xwiTUiivpi8wlvN8jSNalhn6MyAW96WvTa8T P7zcN59eECLuAulM0UU70X1neW/+QW0w0L+9GrL7Mm/PIGnIBi0zRt5Oo4pO0r8ALMb7 lvfpsQr52B/wHl3MoBnEW9mcN9OQzLH1GNrOlijI5N7a4VsOzZS6MMNXUQ4fQ9e7bgWX tb6wfinEojoaL4EldGIolR69Z7yiIqnZPeA5iL+MXqwi2Dyk7XO+29p2JjTLPshq3pIf K8vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TRQP8KRW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v191-20020a6389c8000000b00429f03c0f79si7630099pgd.316.2022.09.01.08.03.58; Thu, 01 Sep 2022 08:04:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TRQP8KRW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234672AbiIAOWe (ORCPT + 99 others); Thu, 1 Sep 2022 10:22:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234667AbiIAOWH (ORCPT ); Thu, 1 Sep 2022 10:22:07 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C00B6D9D6 for ; Thu, 1 Sep 2022 07:22:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6D2D2B8271D for ; Thu, 1 Sep 2022 14:22:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7F5AC433D6; Thu, 1 Sep 2022 14:22:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662042123; bh=rZYMHPLOEfxBZxG74ihdGSUM2bYekoe8btdJtlFb58c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TRQP8KRWHpibzu4UK6pi1mWHfftp/WhaqSp6/z3fFjPRpIOk+QECdyhJuCVhBoSI2 HR5crMF3r7joz8yv3ynNzBEC59r3/cHx2T//Y8q7Aslvty+lNNdEmZ14ls5x3hF79T vD0+YYeDnpbXRg6LzmoMWiKlSTGARjlt7cvOJ3iY= Date: Thu, 1 Sep 2022 16:22:00 +0200 From: Greg KH To: Jiasheng Jiang Cc: hdegoede@redhat.com, arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] virt: vbox: Add check for device_create_file Message-ID: References: <20220901131506.3550180-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220901131506.3550180-1-jiasheng@iscas.ac.cn> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 01, 2022 at 09:15:06PM +0800, Jiasheng Jiang wrote: > As device_create_file() can return error number, > it should be better to check the return value and > deal with the exception. > Moreover, this driver should be using an attribute group. > > Fixes: 0ba002bc4393 ("virt: Add vboxguest driver for Virtual Box Guest integration") > Signed-off-by: Jiasheng Jiang Your subject line is now incorrect :( Also, please properly thread your patches when you send them. I saw a 2/2 but no v3 on that. The whole series is versioned and needs to be connected. thanks, greg k-h