Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7abac73e-d7e2-f457-7a72-9fecb532ddd5@redhat.com>
Date:   Thu, 1 Sep 2022 16:55:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] platform/x86: dell-wmi: Add WMI event 0x0012 0x0003 to
 the list
Content-Language: en-US
To:     =?UTF-8?Q?Pali_Roh=c3=a1r?= <pali@kernel.org>,
        Matthew Garrett <mjg59@srcf.ucam.org>,
        Mark Gross <markgross@kernel.org>
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220827133040.15932-1-pali@kernel.org>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20220827133040.15932-1-pali@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 8/27/22 15:30, Pali Rohár wrote:
> It looks like that on Dell Latitude E6440 is WMI event 0x0012 0x0003 sent
> when display changes brightness. When it happens kernel prints
> "dell_wmi: Unknown WMI event type 0x12" message into dmesg.
> 
> So ignore it for now to not spam dmesg.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
>  drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
> index e07d3ba85a3f..0a259a27459f 100644
> --- a/drivers/platform/x86/dell/dell-wmi-base.c
> +++ b/drivers/platform/x86/dell/dell-wmi-base.c
> @@ -344,6 +344,9 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = {
>   * They are events with extended data
>   */
>  static const struct key_entry dell_wmi_keymap_type_0012[] = {
> +	/* Backlight brightness change event */
> +	{ KE_IGNORE, 0x0003, { KEY_RESERVED } },
> +
>  	/* Ultra-performance mode switch request */
>  	{ KE_IGNORE, 0x000d, { KEY_RESERVED } },
>