Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6009c921-0133-f83b-fbce-1c5ee55cb733@intel.com>
Date:   Thu, 1 Sep 2022 08:31:39 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [Intel-gfx] [PATCH v7 05/15] drm/i915/gsc: add GSC XeHP SDV
 platform definition
Content-Language: en-US
To:     Tomas Winkler <tomas.winkler@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
CC:     <intel-gfx@lists.freedesktop.org>,
        Alexander Usyskin <alexander.usyskin@intel.com>,
        <linux-kernel@vger.kernel.org>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Vitaly Lubart <vitaly.lubart@intel.com>
References: <20220806122636.43068-1-tomas.winkler@intel.com>
 <20220806122636.43068-6-tomas.winkler@intel.com>
From:   "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
In-Reply-To: <20220806122636.43068-6-tomas.winkler@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d1R3UjBVZ3ZuS3JQU1FnSHFtQy9TdldpLzlsNkZ0ZlFtTkVvbWc0VFc3NGhi?=
 =?utf-8?B?TlV4STdnMDdEakV3cHBHUlppVlkwemswZys0TFRPNEtHRDF5WE5lOGFTM3FI?=
 =?utf-8?B?R0F6bVYxcXd5dDg0cWMvekg1dWRnaFR6c1pIVTUxMmdEdGlGUlZkSW1uNjVm?=
 =?utf-8?B?aVo4dHVFNi8vZS80U3pYWjN0WHZVRHgyTGZiSUIwc0UvZGNsWE5nSFQ4UWh5?=
 =?utf-8?B?ZzRtK3ZpYWJLa3lsY2wxaUFISGhpT29lSHlZK09wR2cvTnU3d2FPM3Q0eDJx?=
 =?utf-8?B?d2ZyMFM2Z1JNL1RzYmw1Y09oRkN2ZEdnZnYyV2hjSDlxcHlLL3NpOFhQOE4w?=
 =?utf-8?B?b3RONjUvYXMyWVdTbFNhTkh5WnNqNW13SUVKRGllVjlIZnhDMTVHTys0Zm1C?=
 =?utf-8?B?OHlQSkN1NFozS2RXdm4yNXpocFdlcHR5c29vOU11M25XQUFEU1ljaFYvWFB3?=
 =?utf-8?B?REpnbzFJRlhCcG9CZ1pkTk55LzY4YU9GUXMvWlZzY01mVXpEczNDZjU1Kzk0?=
 =?utf-8?B?K29IYW9Ea2Q3UDhFYnJNWU1xdDVYdkdsM1pGZytlb3NzU1h6R054ajRqekFM?=
 =?utf-8?B?cGdNNVlNcUhQUXJPNnpHSlFnU09yYzZyeko2enNYeCs3Nk9QY0l6TVg0ajkx?=
 =?utf-8?B?NXZmcm1lUWVsRDJzMGxweGdMNENTNVNGNzNTR2VnRFNNOW5DOHZKeFVxb0w3?=
 =?utf-8?B?YXJJeE9uM2xKL2lwdXNiUWR3SHV2RWFlMUlIa05jUHd5NDBJdEdWbVB6QVFI?=
 =?utf-8?B?blYxME1xZUU5SnNKRUlJUmNoekRQUHQzT3JhRWx0ck13cFliQmV6WWpsdkgr?=
 =?utf-8?B?bkNJeTZyWmZDU1dRenlPZjNzRkN3NG1wcUR4RStNOWFod3ZLa1hxdzBKSVMw?=
 =?utf-8?B?a2tkdkZiV0JvNThQbFhLQmU0aUZQZU81QXJDSkt4SnpYWkFFQlRGRHlyVFBD?=
 =?utf-8?B?Q1VpczlqbDJ4NXdzTFhSNmh2NENYL0FDNW5ZTWRDaHpqTTFJTzV3UHUvczBl?=
 =?utf-8?B?c2xBOVI4clVnZm4zOUZSSG8vM1d2RGo5VWlONzB3V3owWkdnSTlyazZzanJG?=
 =?utf-8?B?TTNRbzlnYzBSY0dyVUxaUWRWdVJuN2JQcFZoK2MzaERLMVlxaXJuYzRrdDQv?=
 =?utf-8?B?MGs0VVloUFVxakhOTGFkeHo3Vzd0Vk13UjN5djI3TWljTk5VYnp2MTRZSlg4?=
 =?utf-8?B?cG9GQlhlc3p0RG9BMTFtTCtKTGsyUCs1Z0JWeml2cHRqcjVWYlBmdkdaYjA4?=
 =?utf-8?B?YkFCaVA1U0RYNkxWd0kxUzZNR1VuR0RWNWtLNitjWW90L1Irczk4N0Z0cThD?=
 =?utf-8?B?QUNzVzRmK25MMm1OcmZDTUxKVDAyaFBxMTNDWHBQRzM3d3U4K09wTG9kMXpC?=
 =?utf-8?B?emhrU1BSbUNySWJZU04wZzcwNDhnUG5nQ3dSVjRXSmJBUTVmQStIKzA0NFUv?=
 =?utf-8?B?b3ZPWW14dE1QZmpiaFdkdXExTUU5ZnE5UTNWcU5MRk03MDc0OG1RQVZtV3FQ?=
 =?utf-8?B?Rk54QnNqdzhJcGZQOE9mODkxV2xEVXZFMnViQXhOVEdtL0g2M0pid0RxeEhr?=
 =?utf-8?B?bTI0RWpqaVA4WFVCb2Uyd0RGSmxlcmNEN0tNaDBzVHRBcjluSkEyNlhnVUU5?=
 =?utf-8?B?dlhQeng3U0liaEVYdHRGQnY4VkZzTzhxRlZkMSt4WmJSbU4rVm00SUNWbm9D?=
 =?utf-8?B?VmxYcmZZZFpLOFN0QzlBWHJoLzFqdnZweHJ1TVVMNjNuQ1pzUmtNMklmcjFX?=
 =?utf-8?B?MllHejBvMjJBYW93WTlLT3pUbzY2TS9od1hFbkFnNngwM3ZoMEI1QXZnYVlp?=
 =?utf-8?B?Wkt0eVdVdHNOdEE5VlQrQ09mL0hyS2VuMG1BbUEyMHJ5ay9SNDJxZUZTNEdU?=
 =?utf-8?B?RGorTS9OTEUyZC9xKzJrK2VxanpySy93V0lheFBDcXZpT3J2VFFWYXVGWTZo?=
 =?utf-8?B?VTNscElHY1BENGdVOVowdTlUdjdsbXI1dXduUGtvYjJ3dW1nM291NzBZMVZn?=
 =?utf-8?B?L2FOM00yaW9GYTRXRS8vU2RaRWVFVWxpLzdqYWVyVEVZWG1IbXEzT21qOVFV?=
 =?utf-8?B?S0tLazg0Q2dDQXpMYkVZc2RhOTM3Q1hnb250N1lJYXdHaTJsMm9uSllmVGQ3?=
 =?utf-8?B?SEt0QzFEMEJsVy9pZ2tlQUc1TWgzbktEeER0YkpHZFVpMnNySk1aSG8wZkFv?=
 =?utf-8?Q?u6WLuhM2bSc+AL0fXFVN0HA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 98c92f99-c899-44bb-a845-08da8c2f11b1
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5488.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 15:31:41.9253
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yIoLlhbBYq1LPvnX8crxClVbQfxPjBS+FA3sSgCgmWsUcbg7cfNeSodguRRKSS7yb3z1KbHnsrEWFCdJNp70V23QCsSlQtMbPNgNk3GnH1k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2156
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/6/2022 5:26 AM, Tomas Winkler wrote:
> From: Alexander Usyskin <alexander.usyskin@intel.com>
>
> Define GSC on XeHP SDV (Intel(R) dGPU without display)
>
> XeHP SDV uses the same hardware settings as DG1, but uses polling
> instead of interrupts and runs the firmware in slow pace due to
> hardware limitations.
>
> Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   drivers/gpu/drm/i915/gt/intel_gsc.c | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gsc.c b/drivers/gpu/drm/i915/gt/intel_gsc.c
> index 73498c2574c8..e1040c8f2fd3 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gsc.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gsc.c
> @@ -56,6 +56,19 @@ static const struct gsc_def gsc_def_dg1[] = {
>   	}
>   };
>   
> +static const struct gsc_def gsc_def_xehpsdv[] = {
> +	{
> +		/* HECI1 not enabled on the device. */
> +	},
> +	{
> +		.name = "mei-gscfi",
> +		.bar = DG1_GSC_HECI2_BASE,
> +		.bar_size = GSC_BAR_LENGTH,
> +		.use_polling = true,
> +		.slow_firmware = true,
> +	}
> +};
> +
>   static const struct gsc_def gsc_def_dg2[] = {
>   	{
>   		.name = "mei-gsc",
> @@ -107,6 +120,8 @@ static void gsc_init_one(struct drm_i915_private *i915,
>   
>   	if (IS_DG1(i915)) {
>   		def = &gsc_def_dg1[intf_id];
> +	} else if (IS_XEHPSDV(i915)) {
> +		def = &gsc_def_xehpsdv[intf_id];
>   	} else if (IS_DG2(i915)) {
>   		def = &gsc_def_dg2[intf_id];
>   	} else {