Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i1568416f:Fastmail
Date:   Thu, 1 Sep 2022 17:19:29 +0200
From:   Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= 
        <marmarek@invisiblethingslab.com>
To:     SeongJae Park <sj@kernel.org>
Cc:     jgross@suse.com, roger.pau@citrix.com, mheyne@amazon.de,
        xen-devel@lists.xenproject.org, axboe@kernel.dk, ptyadav@amazon.de,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] xen-blk{front,back}: Fix the broken semantic and
 flow of feature-persistent
Message-ID: <YxDNgfyqypzWJrgH@mail-itl>
References: <20220831165824.94815-1-sj@kernel.org>
 <20220831170817.94903-1-sj@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="Pi/sglFMMbnoUUwn"
Content-Disposition: inline
In-Reply-To: <20220831170817.94903-1-sj@kernel.org>
Precedence: bulk


--Pi/sglFMMbnoUUwn
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Thu, 1 Sep 2022 17:19:29 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: SeongJae Park <sj@kernel.org>
Cc: jgross@suse.com, roger.pau@citrix.com, mheyne@amazon.de,
	xen-devel@lists.xenproject.org, axboe@kernel.dk, ptyadav@amazon.de,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] xen-blk{front,back}: Fix the broken semantic and
 flow of feature-persistent

On Wed, Aug 31, 2022 at 05:08:17PM +0000, SeongJae Park wrote:
> On Wed, 31 Aug 2022 16:58:21 +0000 SeongJae Park <sj@kernel.org> wrote:
>=20
> > Changes from v1
> > (https://lore.kernel.org/xen-devel/20220825161511.94922-1-sj@kernel.org=
/)
> > - Fix the wrong feature_persistent caching position of blkfront
> > - Set blkfront's feature_persistent field setting with simple '&&'
> >   instead of 'if' (Pratyush Yadav)
> >=20
> > This patchset fixes misuse of the 'feature-persistent' advertisement
> > semantic (patches 1 and 2), and the wrong timing of the
> > 'feature_persistent' value caching, which made persistent grants feature
> > always disabled.
>=20
> Please note that I have some problem in my test setup and therefore was u=
nable
> to fully test this patchset.  I am posting this though, as the impact of =
the
> bug is not trivial (always disabling persistent grants), and to make test=
ing of
> my proposed fix from others easier.  Hope to get someone's test results o=
r code
> review of this patchset even before I fix my test setup problem.

I can confirm it fixes the issue, thanks!

Tested-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingslab.com>

> Juergen, I didn't add your 'Reviewed-by:'s to the first two patches of th=
is
> series because I changed some of the description for making it clear whic=
h bug
> and commit it is really fixing.  Specifically, I wordsmithed the working =
and
> changed 'Fixed:' tag.  Code change is almost same, though.
>=20
>=20
> Thanks,
> SJ
>=20
> >=20
> > SeongJae Park (3):
> >   xen-blkback: Advertise feature-persistent as user requested
> >   xen-blkfront: Advertise feature-persistent as user requested
> >   xen-blkfront: Cache feature_persistent value before advertisement
> >=20
> >  drivers/block/xen-blkback/common.h |  3 +++
> >  drivers/block/xen-blkback/xenbus.c |  6 ++++--
> >  drivers/block/xen-blkfront.c       | 20 ++++++++++++--------
> >  3 files changed, 19 insertions(+), 10 deletions(-)
> >=20
> > --=20
> > 2.25.1
> >=20

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--Pi/sglFMMbnoUUwn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmMQzYEACgkQ24/THMrX
1yyDYwf/VfKN646vVgi2jJoF6YTtEC9WtaCKnkgp9Bhbx6MBspI0VMcMqlUW4iON
qs/hnpOCkht7ZawoVqnlK6mb+u6M4W7MFSMNXWSXYvyiCs4fn0dYKm+V630g0eY2
jf7RIMbtjMs7D6GCEmg/FRYft2igtwVu/DQrrJeYXB13QgwXb2/5+PdwlDugMJE1
2ZUeCBQH680TnNsfw68eF4LY7+nZAqaC357Ns/5ANz0GR+M+CxG6B2zPsk7hd5ab
pQt15XHMlzSeJNo2TpDWpZ3Rq4mKDzXL2V55S4eqq82rGymLYTaWzZzNGNmEhEtD
abuZg0mXO7/n/yrWpUclPsSC5TwaXA==
=NzXu
-----END PGP SIGNATURE-----

--Pi/sglFMMbnoUUwn--