Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Thu, 1 Sep 2022 17:02:16 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     =?utf-8?Q?Micha=C5=82?= Winiarski <michal.winiarski@intel.com>
Cc:     dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org,
        linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Gow <davidgow@google.com>,
        Javier Martinez Canillas <javierm@redhat.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Jonathan Corbet <corbet@lwn.net>, Helge Deller <deller@gmx.de>,
        =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>
Subject: Re: [PATCH] drm: Simplify testing on UML with kunit.py
Message-ID: <20220901150216.gt4ozth6oz6cwgjt@houat>
References: <20220901133621.353270-1-michal.winiarski@intel.com>
 <20220901140253.6ebvykv35kyc3v3w@houat>
 <20220901144909.6rihfj4mgklk3ddf@nostramo.hardline.pl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="v37zbd2gmhxbbh3v"
Content-Disposition: inline
In-Reply-To: <20220901144909.6rihfj4mgklk3ddf@nostramo.hardline.pl>
Precedence: bulk


--v37zbd2gmhxbbh3v
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 01, 2022 at 04:49:09PM +0200, Micha=C5=82 Winiarski wrote:
> On Thu, Sep 01, 2022 at 04:02:53PM +0200, Maxime Ripard wrote:
> > Hi,
> >=20
> > On Thu, Sep 01, 2022 at 03:36:21PM +0200, Micha=C5=82 Winiarski wrote:
> > > DRM depends on IOMEM and DMA, introduce an additional Kconfig to pull=
 in
> > > IOMEM and DMA emulation on UML.
> > > Since --kconfig_add usage is no longer needed, remove it from
> > > documentation.
> > >=20
> > > Signed-off-by: Micha=C5=82 Winiarski <michal.winiarski@intel.com>
> > > ---
> > >  Documentation/gpu/drm-internals.rst | 7 +------
> > >  drivers/video/Kconfig               | 4 ++++
> > >  2 files changed, 5 insertions(+), 6 deletions(-)
> > >=20
> > > diff --git a/Documentation/gpu/drm-internals.rst b/Documentation/gpu/=
drm-internals.rst
> > > index 5fd20a306718..c264a9587d21 100644
> > > --- a/Documentation/gpu/drm-internals.rst
> > > +++ b/Documentation/gpu/drm-internals.rst
> > > @@ -228,16 +228,11 @@ follows:
> > > =20
> > >  .. code-block:: bash
> > > =20
> > > -	$ ./tools/testing/kunit/kunit.py run --kunitconfig=3Ddrivers/gpu/dr=
m/tests \
> > > -		--kconfig_add CONFIG_VIRTIO_UML=3Dy \
> > > -		--kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=3Dy
> > > +	$ ./tools/testing/kunit/kunit.py run --kunitconfig=3Ddrivers/gpu/dr=
m/tests
> > > =20
> > >  .. note::
> > >  	The configuration included in ``.kunitconfig`` should be as generic=
 as
> > >  	possible.
> > > -	``CONFIG_VIRTIO_UML`` and ``CONFIG_UML_PCI_OVER_VIRTIO`` are not
> > > -	included in it because they are only required for User Mode Linux.
> > > -
> >=20
> > I'm all for removing that part of the documentation, but because
> > 6fc3a8636a7b, in 6.0 should address this entirely? Why would we need
> > that other symbol?
>=20
> We don't. I wasn't aware that 6fc3a8636a7b exists and had this one in my =
tree
> prior to 6.0.
> (well... technically we do need those other symbols and don't need VIRTIO=
, but
> since CONFIG_UML_PCI_OVER_VIRTIO pull in those two, it also works).
> Since docs were not updated, I didn't see any conflicts when rebasing.
>=20
> Sorry for the noise, please ignore this patch.

I mean, the doc still isn't up to date, so please send that part of the
patch :)

Maxime

--v37zbd2gmhxbbh3v
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYxDJeAAKCRDj7w1vZxhR
xfn6AP9az1d/tvykqX2O94leJJ+WaUANxEmlxQ4simD8YMJHDwEA3+Lorxpg5ULV
d3Xg5NRITlDK7yxBCYTbbOdSjfgtggg=
=jMVD
-----END PGP SIGNATURE-----

--v37zbd2gmhxbbh3v--