Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d9b85490-94f2-611f-a228-ea9434a95805@linuxfoundation.org>
Date:   Thu, 1 Sep 2022 09:47:06 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [Suggested-by:Shuah Khan Patch 1/1] cpufreq: amd-pstate: Add
 explanation for X86_AMD_PSTATE_UT
Content-Language: en-US
To:     Meng Li <li.meng@amd.com>, Huang Rui <ray.huang@amd.com>,
        linux-pm@vger.kernel.org
Cc:     "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Nathan Fontenot <nathan.fontenot@amd.com>,
        Deepak Sharma <deepak.sharma@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        Jinzhou Su <Jinzhou.Su@amd.com>,
        Perry Yuan <Perry.Yuan@amd.com>,
        Xiaojian Du <Xiaojian.Du@amd.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Borislav Petkov <bp@alien8.de>, linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20220901143313.1491951-1-li.meng@amd.com>
 <20220901143313.1491951-2-li.meng@amd.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <20220901143313.1491951-2-li.meng@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/1/22 08:33, Meng Li wrote:
> This kernel module is used for testing. It's safe to say M here.
> It can be modprobed even without amd-pstate module.
> When the comparison test is performed, it can load other module
> like acpi-cpufreq to test cases, then compare the test  results.
> When only the test for amd-pstate is performed, it can tell the
> users they loaded a wrong module like acpi-cpufreq.
> 
> Signed-off-by: Meng Li <li.meng@amd.com>
> ---
>   drivers/cpufreq/Kconfig.x86 | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86
> index fdd819069d72..fd1582716c58 100644
> --- a/drivers/cpufreq/Kconfig.x86
> +++ b/drivers/cpufreq/Kconfig.x86
> @@ -58,6 +58,12 @@ config X86_AMD_PSTATE_UT
>   	help
>   	  This kernel module is used for testing. It's safe to say M here.
>   
> +	  It can be modprobed even without amd-pstate module.

It can also be built-in without X86_AMD_PSTATE enabled.
I would rephrase this as:

This config option can be enabled without X86_AMD_PSTATE enabled.

Also change the information below to sat enabled as opposed to module
as both these options can be built-in

> +	  When the comparison test is performed, it can load other module
> +	  like acpi-cpufreq to test cases, then compare the test results.
> +	  When only the test for amd-pstate is performed, it can tell the
> +	  users they loaded a wrong module like acpi-cpufreq.
> +
>   config X86_ACPI_CPUFREQ
>   	tristate "ACPI Processor P-States driver"
>   	depends on ACPI_PROCESSOR

Thank you - In addition to this patch please make change to the test
script as well when it fails detecting that X86_AMD_PSTATE is disabled
to say what user has to do to run the test.

This run-time message will be helpful to users.

thanks,
-- Shuah