Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Sep 2022 13:12:35 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     David Hildenbrand <david@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Sasha Levin <sasha.levin@oracle.com>,
        "Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Jerome Marchand <jmarchan@redhat.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Hugh Dickins <hughd@google.com>,
        John Hubbard <jhubbard@nvidia.com>,
        Peter Xu <peterx@redhat.com>, Yang Shi <shy828301@gmail.com>
Subject: Re: [PATCH v1] mm/gup: adjust stale comment for RCU GUP-fast
Message-ID: <YxDZ86XW3hPcJtPX@nvidia.com>
References: <20220901072119.37588-1-david@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220901072119.37588-1-david@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RhA4bmni8Jn4iAlYNDOVHxNlB9TBaabF32aUQHdi2LO5reGDg3w8EbvXt0WS?=
 =?us-ascii?Q?bDOgSQ/auquX1beSo4lOSykVP1MTPkEkmSe9taauzBQdWi0ZuWi2v9Z6+BNw?=
 =?us-ascii?Q?EBG5nvLPAb9WEihSbAvaaIxj5r80Q+7ok94ZhAriJ0dFcpMAWaD9L58fMyfY?=
 =?us-ascii?Q?V3Cj0zA6k1yx97SnASuohUGLvm6fKVN3d5G/X6UrJX0nWipH61L2zqWxVTq4?=
 =?us-ascii?Q?LO0ScYTIC47AcJ0ju+dgsn2LO3lkGTm5wHEB3OS2C23ObublR/1EsdVcagG/?=
 =?us-ascii?Q?Q+OpTbktEKGM2GhzenDmBJjjMkqiZhzwczArQkVno8LRq/8mR/sPkWuHpVdN?=
 =?us-ascii?Q?rs9MlpUD6aW+CyR95ZHYhekVNvWYTlf3+tMy6X+Q+5o6ntj5287y4CRIfGfg?=
 =?us-ascii?Q?Eih7c9+M2SlEN2EEklEIYoLDBPiReIGnChC5RH8srw55Ka20HaIH1u/8tUyl?=
 =?us-ascii?Q?TUmZqkZpPL7yh+ISRihmdPzyOj2h4pop6PQe7Ek3ruJmmlVhrlCAgdg55dSn?=
 =?us-ascii?Q?7+VWakI9gf3szs6yNpH51Cx5Xh5dT0H9YHhBwsSIuOePAsktStlfO7hGMi6v?=
 =?us-ascii?Q?APhGbqy8E640y0HrPpTOS8msVZo7egz192PYVZ28e9pohacPhpaa6rZhx/CV?=
 =?us-ascii?Q?hUO/qM8g76/l6BI9SWJiQRuW17qzpMXJUIEeCIhZAn7dfUgK7a8A0qrO/iEy?=
 =?us-ascii?Q?aP5eIfLSNmY80V0M1pvD9JzpMF4BnJ/O6S0GGHQzRs9r0herTzqqNyzPcE7s?=
 =?us-ascii?Q?Fv8KfxXX/s2ULBAjpi7/sr/ZNP7b0iQE4jl7xf7k6VzfAYpuSgfCzub9hzd+?=
 =?us-ascii?Q?zV0GCCU7vSt6YrXoL+9qLiF5HfH6NHiBOt/E5yYUjjFMGQNz59gDZziXZ0lv?=
 =?us-ascii?Q?euXoFMwjmbX/zuH/0PBbpNz3lR15Gq33CVgBC6F5f7otCsEsejcH3zpuI56F?=
 =?us-ascii?Q?/5KSie+z0kxNSXRXjhjSREWOoIlCdJ7U6DSwDxH5LtUeFA/75xusHD45pLND?=
 =?us-ascii?Q?F8QMI+AiPp6oyEyExPcPCgDjbKh4idlB/cRL2qdq01EV3E1Rb87AXYaIHrLw?=
 =?us-ascii?Q?32aAbszYbVAvNhhnvwPWFGOIbylbvj1bAxcphEBtEXVJsHX9X9D9PNDsVQno?=
 =?us-ascii?Q?WfCszSXPFbms2OCl6DoMEDAdEQ4J12SlT6Keax4Msqr5QdcM0XhG+O9Fhl00?=
 =?us-ascii?Q?WZHFyHRs0n69PBISd6Sxd3X9CSo6wTRgvTtIpjmXCr1Wj7CDAkwEYXXpyfTu?=
 =?us-ascii?Q?phRNNdJTFHOklX6GK/1VGRLvz/Q2VaW5soMwSGxHJ2zYFnN8ctPRnELrblpX?=
 =?us-ascii?Q?2VSI/DeIhxbiUEyU5lN4v5wuGdyKSFdSyXgbvwz0Q8m92x4scN+SnY9Grrgm?=
 =?us-ascii?Q?pkQk85Uhhvu8hIRSwAE/bOUk9tFPt+A7G8Y3cJFzs1Lsbv70JZxi2dHG9gJ+?=
 =?us-ascii?Q?5lpi/+ES81+fQpoCv1FRHCB/MnVOnxIYnx9rnhJbURZNz9zANRF7OQ0mzJBA?=
 =?us-ascii?Q?wROR4FeYd8JU1pWlCU2Ws+xuCYFus/RNRXNhakuYu+kgguMG0DrUSdvi2W6s?=
 =?us-ascii?Q?W8zOwIoKk62DKBQ8yWYBQkoud8z4FWOrAGTWu5X1?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f0e5e35-bb6a-4f36-dcc4-08da8c34c970
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 16:12:37.5119
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eVIzhl/4jKzdNjStRRY2zNsC4YXg6lvoDttuoschK1Ppem/dSyw2eO1d5TLIvDrr
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4573
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 01, 2022 at 09:21:19AM +0200, David Hildenbrand wrote:
> commit 4b471e8898c3 ("mm, thp: remove infrastructure for handling splitting
> PMDs") didn't remove all details about the THP split requirements for
> RCU GUP-fast.
> 
> IPI broeadcasts on THP split are no longer required.
> 
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Sasha Levin <sasha.levin@oracle.com>
> Cc: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Jerome Marchand <jmarchan@redhat.com>
> Cc: Andrea Arcangeli <aarcange@redhat.com>
> Cc: Hugh Dickins <hughd@google.com>
> Cc: Jason Gunthorpe <jgg@nvidia.com>
> Cc: John Hubbard <jhubbard@nvidia.com>
> Cc: Peter Xu <peterx@redhat.com>
> Cc: Yang Shi <shy828301@gmail.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>  mm/gup.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

The comment a bit above seems to need touching to:

 * protected from page table pages being freed from under it, and should
 * block any THP splits.

What is the current situation for THP splits anyhow? Is there are
comment in the fast pmd code explaining it?

But this seems OK too

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason