Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Sep 2022 17:56:50 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Vimal Kumar <vimal.kumar32@gmail.com>
Cc:     chinmoyghosh2001@gmail.com, Mintu Patel <mintupatel89@gmail.com>,
        Vishal Badole <badolevishal1116@gmail.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] PM: runtime: Add support to disable wakeup sources
Message-ID: <YxDWQjMlEGQH4yz3@kroah.com>
References: <20220821134533.22901-1-vimal.kumar32@gmail.com>
 <YwI7PM9wVF/H9hQL@kroah.com>
 <20220827114028.GA258@DESKTOP-KA7F9LU.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220827114028.GA258@DESKTOP-KA7F9LU.localdomain>
Precedence: bulk

On Sat, Aug 27, 2022 at 05:10:28PM +0530, Vimal Kumar wrote:
> On Sun, Aug 21, 2022 at 04:03:40PM +0200, Greg KH wrote:
> > On Sun, Aug 21, 2022 at 07:15:32PM +0530, Vimal Kumar wrote:
> > > User could find many wakeup sources available in the bsp, which
> > > they won't be using. Currently users can only get the status and
> > > list of enabled wakeup sources, but users can't disable it runtime.
> > > It's very difficult to find the driver for each wakeup sources from
> > > where it's getting enabled and make the changes for disabling it.
> > > 
> > > This will help users to disable any wakeup sources at runtime,
> > > avoiding any code change and re-compilation. A new class attribute
> > > "disable_ws" will be added in the wakeup calss. If user want to disable
> > > any wakeup sources, user need to find the wakeup dev node associated
> > > with the particular wakeup source and write the devnode name to the
> > > class attribute "disable_ws".

What userspace tool will use this new interface?

Who is supposed to interact with it?  Why is this even needed?  Who
would disable this dynamically, shouldn't the kernel handle this all
automatically with no need for usersapce to get involved?

What is the root problem here you are trying to solve?

thanks,

greg k-h