Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <417bdb98-e22b-5316-7f71-5797ac001a53@amd.com>
Date:   Thu, 1 Sep 2022 11:47:17 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.2
Subject: Re: [PATCH v2] drm/amd/display: fix indentation in
 commit_planes_for_stream()
Content-Language: en-US
To:     Hamza Mahfooz <hamza.mahfooz@amd.com>, linux-kernel@vger.kernel.org
Cc:     Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
        Jun Lei <Jun.Lei@amd.com>,
        Meenakshikumar Somasundaram <meenakshikumar.somasundaram@amd.com>,
        Alvin Lee <Alvin.Lee2@amd.com>,
        Martin Leung <martin.leung@amd.com>,
        Samson Tam <Samson.Tam@amd.com>, Alex Hung <alex.hung@amd.com>,
        Wenjing Liu <wenjing.liu@amd.com>,
        Joshua Aberback <joshua.aberback@amd.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
References: <20220901141511.50523-1-hamza.mahfooz@amd.com>
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
In-Reply-To: <20220901141511.50523-1-hamza.mahfooz@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVdUMXFvRlhmTjhVNGtaNEVxM1l0b054L1dqeTBTZGNlV1NIbW9TVnNDWlNk?=
 =?utf-8?B?ZTZNY1lLU29XVEdIUUJSb2U1eTRiMGU3TTlLR2cwa29KSk56dk9PMEY2MFJT?=
 =?utf-8?B?dWhNS1I3QWF0bytnS3JyUjBmNWxkbDlXVmZrcTE0U01EczFOYlR2U29VSzQ3?=
 =?utf-8?B?d21hVkdmNE02UWtwNVE5RWpPazkvNkJoT0pvNS9qbXBsc2pZY0MvQkZuRzUv?=
 =?utf-8?B?MVBTL0ZsOUQ5Q0FlVTBDN1BiWUk0MndjYWpSV2ZPNGdqWWsrdFhLNFdES2NE?=
 =?utf-8?B?a25walh5SWFTVFNuQUVycUNHbXRYVmU0clEvN09pK3lvcExBRmdiUEMrTWV6?=
 =?utf-8?B?dHM4VTNYbzNjcHlDQjhtSDIzU2pIZEVCTnpEUnhIdzV6TDA3aVdkMGNQNzU5?=
 =?utf-8?B?SzNrRitRR2VoZTY0T1RPR1NHVk83SjMwbGhHM042REdTY0wyU1F5SHM3TExi?=
 =?utf-8?B?dEVBaElJZmRHSzYyZWMvanZSQUw0a2NlRVpYTThRWWRuSDh5ZVFvN09FOTBC?=
 =?utf-8?B?NTVyM0dNNGoyMm1LNkJ6bWJVQy81Z1FzUkpzOE9PcU00NHpaS3M3VTZ3K3la?=
 =?utf-8?B?Nk9ZZ1gxNVpIbnJCTVRxSDRrSFRRTmFpeW8rMXBZVmhTU0hkVVp2T3FzWEl6?=
 =?utf-8?B?L0R5azd6UXBaTC9MOGkzUVZ5b0JaNVN1UUpUTUpqeGNPUnFrbGticTVOV3Rz?=
 =?utf-8?B?U1pybU9lK1NQMGZ2MytaV3JQbGpnK01IMm9mT3hVckI4UmVRQlBWUFBKdmNH?=
 =?utf-8?B?a1JhQ2VGTC9YWEN1WUNUTDExQnlGbUFtdU93U0kvSHVzWm5IWmg1NnhseitX?=
 =?utf-8?B?SmQ4eE0zTmZuQzBZeHRmTnNxZ2c5R3Q3K2hYQWlnSmlvaCtMQ000SldlQ3ll?=
 =?utf-8?B?S1VSK2dCMGI2a1NRNXhwcEFhS1VHbXRSQUJPdENsQk9RcVE0Y1VKOXVkTHp6?=
 =?utf-8?B?Ylo4VWJJUkRkRC9jdmRydi9YbU9lSWVmNHZoOVN3dFMreEJGcmJIdU5WSHBv?=
 =?utf-8?B?Z1BiZHBIWEZSOXRpQ0RORjFkTWJzdDcrWVdQWXp6czlWTkxqdHl0dER0VGM1?=
 =?utf-8?B?Zk1pajVIVUZ6dXhuSzBqS25UYjdvNVJBT0VsRXVQbXltc0p3STltVUFiRjFa?=
 =?utf-8?B?NjFBWlBnMGdDUEFya2p6dld5NERWRlFMMnNNVm04Y0loS3dGTG5PVWhpWU9K?=
 =?utf-8?B?UkR1ekpVSm9YSFdPTzczeVk3emNjY3VTazlVUmJQUWtVOVIzblZIZGJyS3pw?=
 =?utf-8?B?LzlTMWhzblNTK2lNZWR6TGtoc3FKS2RnTzZsL3BleTkveEE4SmZLVFNrdmdY?=
 =?utf-8?B?USt0d1h2STBMR2JOWmVmRktMWnBWdktsRUdWOHdhTGZEa2ZyQ3E2NE9kRjRw?=
 =?utf-8?B?NFVNZHVrdGlTc2NrbDNHNUMzTHlOYUtxUjFWbXVXcXNJV0gxNGcyOGN4TDNJ?=
 =?utf-8?B?M2VMWlN3akVWTGxHZUhFcG4rbkd1aW1YK0pzVkdXZ3p0NVV4T1hmTGs4K04y?=
 =?utf-8?B?dzNIbEtJamZQTEI3cC9meXV2eHVSSGxiWXNRcWZUWlhGb0N3dW5KMXVIY0hF?=
 =?utf-8?B?VXA1WEpnZGg3eUhHU1ZLNFBjb3pXSTBrVm96c2k3amszZjBrYzc5MS81UXdB?=
 =?utf-8?B?dEVLWjBQN015Z0dUYlNOTHo4NTJFVFE3SlNpTTIyMUZWaG10dkNmQXpXTEY5?=
 =?utf-8?B?eUU0UENIaDlrK2JEckFvTGN3NU52SmdNODVlU04rbk1MVVhYeWlWZlB6Q2VM?=
 =?utf-8?B?TTdNdFdGUWNZdTBsc3phWGFZMlZnckd3L0k1YUVIczIyTUxKaEt2d01ML1Ro?=
 =?utf-8?B?RkVKZXc1WFNJZHhGQkR0ZVI2M0lidWJMTFk5c2JmVWNLc2VHdy9lNTNBWmhx?=
 =?utf-8?B?NmpuN1VKWUcra1E4ZnFkRmQ5TzVGUkNWT1k3ODQyUXM3WVd2NFI2d0ZLMTlK?=
 =?utf-8?B?TmFGdmJjdkF4MEt3VS9CempVck5scFFZa0NqMFFkREwxaDVxdXkzODJ5WGtk?=
 =?utf-8?B?T2F6K1ErTXk2ZnQ4YmVpUW1Rd3gzTllQcjRPd21vM3FpQi9BbDlBbEUzQzVL?=
 =?utf-8?B?MWIvaFpqdW9GbE84Sk13cDgwZ1NTMEsrampmQmpmR2VFSGFZdGVkVEpHR0tQ?=
 =?utf-8?Q?gK//emWgp5iwSHxQgkU4yJH/r?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a6b9bbde-69ee-4403-e9c5-08da8c31406d
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2941.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 15:47:19.0765
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kOi2yCDz9r8RcMnEf8sYfpWXTZDwvNTBzIGnk1UXmpMPoHzxmXaJRn3v0KGuN4gyRT2tpjOiQCqZdWWIVrjONw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4244
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-09-01 10:15, Hamza Mahfooz wrote:
> Address the following warning:
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
>   3508 |         if (update_type != UPDATE_TYPE_FAST)
>        |         ^~
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
>   3510 |                 if (update_type != UPDATE_TYPE_FAST)
>        |                 ^~
> 
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
> v2: implement feedback from Alvin
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index b49237390cce..9860bf38c547 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -3507,9 +3507,10 @@ static void commit_planes_for_stream(struct dc *dc,
>   
>   	if (update_type != UPDATE_TYPE_FAST)
>   		dc->hwss.post_unlock_program_front_end(dc, context);
> -		if (update_type != UPDATE_TYPE_FAST)
> -			if (dc->hwss.commit_subvp_config)
> -				dc->hwss.commit_subvp_config(dc, context);
> +
> +	if (update_type != UPDATE_TYPE_FAST)
> +		if (dc->hwss.commit_subvp_config)
> +			dc->hwss.commit_subvp_config(dc, context);
>   
>   	/* Since phantom pipe programming is moved to post_unlock_program_front_end,
>   	 * move the SubVP lock to after the phantom pipes have been setup

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
and applied to amd-staging-drm-next.

Thanks
Siqueira