Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7ed45656-f28b-5aaa-8a5b-84f566eb3bfb@digikod.net>
Date:   Thu, 1 Sep 2022 17:53:23 +0200
MIME-Version: 1.0
User-Agent: 
Subject: Re: [RFC PATCH v1] checkpatch: Handle FILE pointer type
Content-Language: en-US
To:     Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>
Cc:     Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Shuah Khan <shuah@kernel.org>, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org
References: <20220901145948.1456353-1-mic@digikod.net>
 <4f958a0c7c0aa2fce613371348477c002aa58e90.camel@perches.com>
From:   =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= <mic@digikod.net>
In-Reply-To: <4f958a0c7c0aa2fce613371348477c002aa58e90.camel@perches.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 01/09/2022 17:49, Joe Perches wrote:
> On Thu, 2022-09-01 at 16:59 +0200, Mickaël Salaün wrote:

[...]

>> +# our $typeKselftestHarnessTypedefs = qr{(?x:
>> +# 	FIXTURE_(?:DATA|VARIANT)\($Ident\)
>> +# )};
> 
> But not this.  Random userspace typedefs should likely
> be kept in some local version of checkpatch.
> 
> Or maybe add a command line option like --additional_typedefs=<file>.

This is part of the kselftest harness API. Could we take this into 
account for files under tools/testing/selftests ?

> 
>>   our $typeTypedefs = qr{(?x:
>>   	$typeC99Typedefs\b|
>>   	$typeOtherOSTypedefs\b|
>> -	$typeKernelTypedefs\b
>> +	$typeKernelTypedefs\b|
>> +	$typeStdioTypedefs\b
>>   )};
>