Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <08097517-6547-a275-345d-b95cce7cd743@intel.com>
Date:   Thu, 1 Sep 2022 08:30:37 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [Intel-gfx] [PATCH v7 02/15] mei: add kdoc for struct
 mei_aux_device
Content-Language: en-US
To:     Tomas Winkler <tomas.winkler@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
CC:     <intel-gfx@lists.freedesktop.org>,
        Alexander Usyskin <alexander.usyskin@intel.com>,
        <linux-kernel@vger.kernel.org>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Vitaly Lubart <vitaly.lubart@intel.com>
References: <20220806122636.43068-1-tomas.winkler@intel.com>
 <20220806122636.43068-3-tomas.winkler@intel.com>
From:   "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
In-Reply-To: <20220806122636.43068-3-tomas.winkler@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnhPUzEvaHFkTFlmTlBoQXJkbjRxZ0h4NWxLMFlydXdxME1US0xOMDNTTTAw?=
 =?utf-8?B?bmRpTTZFQkQzTFQ0VnlOa1ZTVmo3S01LdUQ1ZmE1eGo5OFJIWFZtcWMvZDEz?=
 =?utf-8?B?YytlRFNYUGtaVWFabGdwa2FpaDF5bU4wSUp5ZXZleTFjZklwK1RaaUduTHln?=
 =?utf-8?B?N0MvU0NhelVVWHdPeFZWMVRGOFdWZ2J6VzdKVUNSeUxQOCtPdFlkRTVQYzcw?=
 =?utf-8?B?NWRCYzE4endYMjhSWEtSTStDUWMyRS9ZNG1YT3h2OTZkRXJMNlcvL0R0T3pO?=
 =?utf-8?B?eE9Sbi83MVc5WGNWSlo5blJoeEVPY1o4QzgvMmdWa2dXYmlKY0RYY1RtcTdu?=
 =?utf-8?B?TENDVVpSbnZxRUt0czlIREI0YmY0cnRDSmdkamowc3VPdDdtYWlFaGpVNUIw?=
 =?utf-8?B?eWdhQzVySWJOUDVBcXhsdWZBSlRnSTVNcWlwWDZJRW5GMHo0Z1hDODV4SGlT?=
 =?utf-8?B?Y29wSUVKOStETjJ2QUNoNEZoVHNkRGdCY1haYk90OTNIa2hJcnZyVmo0dDNU?=
 =?utf-8?B?L2U1LzNoOGdlcjNiRkROOE5PbXMyWmhvUkdWRllKN0hBVFk5Z2E1cFQvdnlv?=
 =?utf-8?B?dXJ4dEZqQUtmdjl0YURaK1huMHdmUHpsZDlpYzlDWkFraElKU3lVdTQ0WVFX?=
 =?utf-8?B?WWg5MVNqc0VocWxySFNMUWlnNkxMNjRUNlpNSHZEM0lqV1Q1a2pWQkRXOEJQ?=
 =?utf-8?B?ODNhWHhwM0t0dnVVZVdDUjhCbmh2c2Nka3lrdklTd1NMVThtSmZQY2Q1dm10?=
 =?utf-8?B?MGJqc0U3a25hVXYrUW5wWkNKd1ZMK2hrUnp2Z05idDVSanhvQ083M1VmczRZ?=
 =?utf-8?B?QVd1RjY5WlNxMU1KTkhjVG9qdjgvZVJmS3h5QjVJWUVld1hXWGFRU2pFTWhG?=
 =?utf-8?B?TjNuNll4NzIyRHhDYlpjZ1hHbXJHdEM2ZURHaEYwc1NOQUtzSjc0bmgrZEo1?=
 =?utf-8?B?WXVDQ0htbUlYN2VoOTh0RHVrVEpPOGpUMUkxWk9WRFRML0FxTGE4QUhkWkFi?=
 =?utf-8?B?ZVhkRVZaVGRGTFI4aFdaeFlhU1JDbU8va2hDcE9vVGJheFFDN3N6WDR2dlJy?=
 =?utf-8?B?cUloQ3cxS3E4ejU4MVZ5L1lORmRWZHdyZzJvQ3gvQUc3aGZFVGcrMUp1WUxm?=
 =?utf-8?B?dFlSYzB0ZjRmN21DanZzTVN5bmhXUHdGcWVPdmpTczVlMUVwTWNGV0RQVFpt?=
 =?utf-8?B?Qnh5aWZkOHloYnhqblBMQ0RRbmZueGZ2d1pkUFJaTUJKSHJXVURvYU9pemxO?=
 =?utf-8?B?K3Ezc2pYSTY2blJMbVpMb1gvYWlhaTN6TVJKY1NUcmxkbm9nNCtKenJPYkJG?=
 =?utf-8?B?aklPd1FsMUp1dDMrclVlSHV5c2x1V2dJdlByMkU2b3VTc01DTHUyVjNiK1Nk?=
 =?utf-8?B?OGdicHQ5U0ZNb2t1SitNUm5LVXRwcS8zUFczUkNmRXBGdytHSStqdjIxWStB?=
 =?utf-8?B?TDR5cVQ4ZHkvemFNTnFEd2h6WUU0bHlQd3h6cDFpY2tGaE4rOHlJUjU0eTB6?=
 =?utf-8?B?dlVUSWVBeFJwZURza1dPN05uampwMG94N29odVpBcTBGZFJsY0RVUW1pNWdp?=
 =?utf-8?B?bWw2K2UxMGJiS0J0U2NQS002dnVGUTV5ZXNZcWRHZkh4bmh4aFNxeTZ0dWR1?=
 =?utf-8?B?ZC9kSkNPTlh1dmU5S0JSOGtjZVFBb081RzVmMFRVK3FQRTFQL2tkQnRZTkxN?=
 =?utf-8?B?T2d2MFNDdVhTZU9NdVpMSHBsaVlCNTN4cGp1SzhnQkNkT2lHWWtvWmU5U2xB?=
 =?utf-8?B?c2tva0w5SEp2ei9hNmV0bzQvMjNUNjhRQnN3dzh4NXZXY0dFT282empwWWh2?=
 =?utf-8?B?U1JSV1gxdTRHdllxVktXazZ0MkFhNE5uK21oODFNbkdHSUVLNWQvMnJueTVM?=
 =?utf-8?B?ZnR4K2h4dXZLZm9sZmRWTllXdDFUOTc1bzZXN2ppN3BwMWw5bFI4SEJNZG1J?=
 =?utf-8?B?Mk5nS2tVdXB1ajRFTDcrd1ZTa1VCWnhlQ0tSMWx6U2pjeVphMTVnWmJYSTYv?=
 =?utf-8?B?V1d0NXZveTgxaG8wZkQrVDhXbEcrMk1wUVlGYzZuTXhmVXZDU1dSN0NiQUly?=
 =?utf-8?B?WXR5L1FtUDY2L1FyQVpBR0kwaFNsQlc3R2tOWDQxeFZVT29xa0pUaUdINi8y?=
 =?utf-8?B?TmJGUWNQNldNRkhINzREbVVpai9QMXhucDhEU2JpR3dWVzZZbU80azMvRSsv?=
 =?utf-8?B?OUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0613a3df-9ece-4d43-37b0-08da8c2eed87
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5488.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 15:30:41.0448
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V75HT4ByEmSkXgy2yNT/R0fshcXlbxyBghHGEqI+hj2Lkz66BMTFVjGSKyLoQHit4CcWmwwoK14XXyLXKp+KVXix0co1ZH7xh8F1JqmR7Dw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2156
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/6/2022 5:26 AM, Tomas Winkler wrote:
> struct mei_aux_device is an interface structure
> requires proper documenation.
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   include/linux/mei_aux.h | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/include/linux/mei_aux.h b/include/linux/mei_aux.h
> index 587f25128848..a0cb587006d5 100644
> --- a/include/linux/mei_aux.h
> +++ b/include/linux/mei_aux.h
> @@ -7,6 +7,12 @@
>   
>   #include <linux/auxiliary_bus.h>
>   
> +/**
> + * struct mei_aux_device - mei auxiliary device
> + * @aux_dev: - auxiliary device object
> + * @irq: interrupt driving the mei auxiliary device
> + * @bar: mmio resource bar reserved to mei auxiliary device
> + */
>   struct mei_aux_device {
>   	struct auxiliary_device aux_dev;
>   	int irq;