Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d50fec5e-eeb3-01e6-d81c-14032cf5e766@intel.com>
Date:   Thu, 1 Sep 2022 09:07:36 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [Intel-gfx] [PATCH v7 07/15] mei: gsc: wait for reset thread on
 stop
Content-Language: en-US
To:     Tomas Winkler <tomas.winkler@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
CC:     <intel-gfx@lists.freedesktop.org>,
        Alexander Usyskin <alexander.usyskin@intel.com>,
        <linux-kernel@vger.kernel.org>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Vitaly Lubart <vitaly.lubart@intel.com>
References: <20220806122636.43068-1-tomas.winkler@intel.com>
 <20220806122636.43068-8-tomas.winkler@intel.com>
From:   "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
In-Reply-To: <20220806122636.43068-8-tomas.winkler@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFlrYWkzVUoycTlWSEhVZC82TzV6OFBGRzFEcjZuWk04Y1I4N0d2Ly8vdWc5?=
 =?utf-8?B?S2xUZzBiZTQ4OVFzNUdnTmMrNFlBQTRVcFFmQyswRFdoS2lLazZvSmF0ZG9K?=
 =?utf-8?B?SUMrZS9mSnREYzBwTHlUOFZlOU9qTDJQOEk4aUJXZ05LcGZVWFdWaXpJalRJ?=
 =?utf-8?B?ZmhVMWEwS2Fub2lvRmRQMDRkVVdpYkxyNUZhZGNoeGR1dHM2eDRGeUp0eDI1?=
 =?utf-8?B?TnhMZmtNUUNlcTVZdHNkRU9WajNVKzdZQnppbDlUVVprTlgwWXRHRXlsdHlE?=
 =?utf-8?B?WnRPb2pDTHUraGI0NFY0KytNZXVZT2R1VzlhanFrK0lWWFYweGgwZmJmZS9S?=
 =?utf-8?B?Um1LWnBkUlBSTEpiLzFnY1NCcXNzRjREU215SzArV1cvb2FKeFJ5cUlCUFZq?=
 =?utf-8?B?NjVZVlhGY2lHTE9HWnhBbXdyWG9tNHF6SDZLdTM1TjI2aURnemFMSUhySTlM?=
 =?utf-8?B?MVQ4Mmk4bDgrb0E4d055OE5sRm5CdEFDTy9WWkJBa1RQUXlUQjljRHFFb2JS?=
 =?utf-8?B?MGRLRk10WlZmVnVJOS9YOEJjcm9zam9FZnVidGR4OHM1bDk1R3BLUERIWEFK?=
 =?utf-8?B?WjZncVpkWFpnODBnMGpZcEo4ZE9CWVdwRW04bDRjTzdpNjJvc3J0TXdDbnBC?=
 =?utf-8?B?QU03Q1c3anQ5N0JqZDk0TkhCVGJuTGk4TVV1cVVOTVRRMGhyaEdsbUZNTzEz?=
 =?utf-8?B?T3hvM1RXNE9rQkpON1VnaHNvSWhmOHkxa3pERU9KSFFDSlAwbXo3QVdWSjFu?=
 =?utf-8?B?RDR4WUFwdnUyS295UUh5ZkpvVmc3azZLTllpMjZxZ21XaXpVL2RvcjFRVWd4?=
 =?utf-8?B?QWprSFhXREtRRUh4ZmtlYVBGS3dTa0twN05lOU1SeCtFSldIK2g3UmVsZnhQ?=
 =?utf-8?B?OGRrRGpTZXViYVJTTEdJUEpnd29LQ1lNNVE1dkpMdGZxT0YrV3k5VTZlMUZx?=
 =?utf-8?B?K24wWStycXVlQ1hzVmRXVkhoaDVPMGprbG1FdXdJTVVRa0p3NmFiY2lyL1Fx?=
 =?utf-8?B?TEhidlR3bE54UmE1OXNxUlJsRllPc2lVcHEyanFWVnQvZmZGc2pWU1JDZnFl?=
 =?utf-8?B?UjFMamVLcFhXbmh3YWdWS2hncFc1NVRXL1kxcXlQbXNYZFFoZmRWeUQvWXl1?=
 =?utf-8?B?UnVmUDBEMDZhUjRlMjRuNzZBRDV0NDR3MzJyOE8rNnY1RzJoQS9nc3dhQ2lS?=
 =?utf-8?B?RVEwMnhnZHNEOElHUVgxenhqdDZ4cHFTQlk2RU14akR5WUsrYjFuMDFMT2V1?=
 =?utf-8?B?Vk5ObzNMU2xYdFlCWWVFcFBQN2RmRTB4dFA0Ky84TlcwNDRITmpPVkhqbDN3?=
 =?utf-8?B?ckJsUFhSNXFpSW5WR1pvRWgzTDF4SHgxTXlkcU83Zm9DNXJGbVdrVnl3OG5J?=
 =?utf-8?B?bkJ2NkxQcUR3akU5Tm9wUDFhNVd1Mm5yMlNQVVQ4NWtxQ2t5UHZHRm5mMDFp?=
 =?utf-8?B?L250UVJDVTJyTWc3RmI4ZXJ0a2hvVEtEM25ETWpSQXc2WGJsemRFY1pYVzR0?=
 =?utf-8?B?cDJwNHlZUTJ6U0pMdjJaT2FBeHVXSXNQK1F0UVB5M0dOSlNjUXhuQ0t4SnNm?=
 =?utf-8?B?UzRRNmtNT1ZFbDNwYWI2a3Bxb1dEVll2cXM1RjdWTUlERWpFb25EeGtlMXpX?=
 =?utf-8?B?SlpQeGQxRnd1aSszWWhRZHA3OXI5aXJscjhmQlg1cUNwZk81cTIyMmpmeFMv?=
 =?utf-8?B?WW80ZFVJR3VTZTkvd0twc0NTRE93YnhTZVpkeDBiVlhzTThJcm1EWWlVVUFQ?=
 =?utf-8?B?OUxEQUVralBSTGc2TW1zdlVwUnJpQWRUZDFzUWJJeVBhVExRU213ZTEvbll0?=
 =?utf-8?B?TE1tUnJlZDE0M1V0TTlHUGxLcmVqa3FMQ1BJdXBHSzBlVTBaV3hMd3RJaS9Q?=
 =?utf-8?B?QVRWdmFYdnZRZDVyM1BJWXJBMmdVVWlxUFpFMHlROXQ0cXFzcDgzRXhzUDRh?=
 =?utf-8?B?V0RFLys0OWRiVTh3Yi85RW93Y2lwWTNFT0lJKy8zQXdTcUVNdnFPdGRuY3Vs?=
 =?utf-8?B?MHh0bHQ5clNaZ1Q4RVRMQlYrbERiUDk3dWo0c2E3cjV3MlloclJZWEFFUXcv?=
 =?utf-8?B?eFpLcUxLYmY1T3EzS2RjWVVlM1ordS9QbmlZWHd4SHJJci9VajVYbExhT1Jo?=
 =?utf-8?B?TExWRjdhSjM4cG5sU3hHVDF5T28vV1QyaUMxRERiZEtvblVlWklpaE9IbkhU?=
 =?utf-8?Q?qFE/x8M3YlmZhb5mnUnVdCY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 76ea4f2f-f54f-4d98-f874-08da8c341780
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5488.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 16:07:38.8268
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RqnuCa8/iOkEh9G3o9uJowr7uzHm4mSc+ayK1CsXQ/bWtHpkIyFRJEZSblTI45Yk1tB/+1GDBJX8ros9hs24kN0HMP/fqeLGytt6Yl7GXgM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3807
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/6/2022 5:26 AM, Tomas Winkler wrote:
> From: Alexander Usyskin <alexander.usyskin@intel.com>
>
> Wait for reset work to complete before initiating
> stop reset flow sequence.
>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   drivers/misc/mei/init.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/misc/mei/init.c b/drivers/misc/mei/init.c
> index eb052005ca86..5bb6ba662cc0 100644
> --- a/drivers/misc/mei/init.c
> +++ b/drivers/misc/mei/init.c
> @@ -320,6 +320,8 @@ void mei_stop(struct mei_device *dev)
>   
>   	mei_clear_interrupts(dev);
>   	mei_synchronize_irq(dev);
> +	/* to catch HW-initiated reset */
> +	mei_cancel_work(dev);
>   
>   	mutex_lock(&dev->device_lock);
>