Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Sep 2022 18:10:25 +0200
From:   Samuel Thibault <samuel.thibault@ens-lyon.org>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, speakup@linux-speakup.org
Subject: Re: [patch 1/2] speakup-dummy: Add support for PUNCT variable
Message-ID: <20220901161025.5q7cwb4hpj2osnuk@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Greg KH <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org,
        speakup@linux-speakup.org
References: <20220823222501.483597563@ens-lyon.org>
 <20220823222514.929670068@ens-lyon.org>
 <YxDI0LWy/Gqwy1GT@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YxDI0LWy/Gqwy1GT@kroah.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
Precedence: bulk

Hello,

Greg KH, le jeu. 01 sept. 2022 16:59:28 +0200, a ecrit:
> On Wed, Aug 24, 2022 at 12:25:02AM +0200, Samuel Thibault wrote:
> > This allows to debug the update of the punctuation level.
> > 
> > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> > 
> > Index: linux/drivers/accessibility/speakup/speakup_dummy.c
> > ===================================================================
> > --- linux.orig/drivers/accessibility/speakup/speakup_dummy.c
> > +++ linux/drivers/accessibility/speakup/speakup_dummy.c
> > @@ -27,6 +27,7 @@ static struct var_t vars[] = {
> >  	{ INFLECTION, .u.n = {"INFLECTION %d\n", 8, 0, 16, 0, 0, NULL } },
> >  	{ VOL, .u.n = {"VOL %d\n", 8, 0, 16, 0, 0, NULL } },
> >  	{ TONE, .u.n = {"TONE %d\n", 8, 0, 16, 0, 0, NULL } },
> > +	{ PUNCT, .u.n = {"PUNCT %d\n", 0, 0, 3, 0, 0, NULL } },
> >  	{ DIRECT, .u.n = {NULL, 0, 0, 1, 0, 0, NULL } },
> >  	V_LAST_VAR
> >  };
> > @@ -42,6 +43,8 @@ static struct kobj_attribute pitch_attri
> >  	__ATTR(pitch, 0644, spk_var_show, spk_var_store);
> >  static struct kobj_attribute inflection_attribute =
> >  	__ATTR(inflection, 0644, spk_var_show, spk_var_store);
> > +static struct kobj_attribute punct_attribute =
> > +	__ATTR(punct, 0644, spk_var_show, spk_var_store);
> >  static struct kobj_attribute rate_attribute =
> >  	__ATTR(rate, 0644, spk_var_show, spk_var_store);
> >  static struct kobj_attribute tone_attribute =
> > @@ -69,6 +72,7 @@ static struct attribute *synth_attrs[] =
> >  	&caps_stop_attribute.attr,
> >  	&pitch_attribute.attr,
> >  	&inflection_attribute.attr,
> > +	&punct_attribute.attr,
> >  	&rate_attribute.attr,
> >  	&tone_attribute.attr,
> >  	&vol_attribute.attr,
> > 
> 
> Don't we also need a Documentation/ABI/ update for this new sysfs file?

It is already there actually, because it's the same variables fo various
syntheses, and this is just adding the support for punct (already known
in other syntheses) to the dummy synthesis.

Samuel