Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Sep 2022 09:55:21 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc:     Matthew Wilcox <willy@infradead.org>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, akpm@linux-foundation.org,
        songmuchun@bytedance.com, vbabka@suse.cz,
        william.kucharski@oracle.com, dhowells@redhat.com,
        peterx@redhat.com, arnd@arndb.de, ccross@google.com,
        hughd@google.com, ebiederm@xmission.com
Subject: Re: [PATCH 1/7] mm/hugetlb: add folio support to hugetlb specific
 flag macros
Message-ID: <YxDj+ZCKx3fpHQvI@monkey>
References: <20220829230014.384722-1-sidhartha.kumar@oracle.com>
 <20220829230014.384722-2-sidhartha.kumar@oracle.com>
 <Yw2E937l+GARR3Vb@casper.infradead.org>
 <12303882-dd84-485a-28cb-cefbaac4d960@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <12303882-dd84-485a-28cb-cefbaac4d960@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KMnaYFkw3is7hiGX+m9Kbh7fR9bTY5de55yuHPVfYqo8d+akE9nkRS7m4p/E?=
 =?us-ascii?Q?duPA+i+0w2PrxYrBzPInjuaYW7NdO778NEdbHg8iteQJwIzjULvL3KCSwoWE?=
 =?us-ascii?Q?6DuDwvda8umn4KceBKkT0oPkn/NY/rCIDTnh6zb/aBa93bUnEfJANSz0abnd?=
 =?us-ascii?Q?E0aWZsJzChqnRhVoXCFPwwcHuyFxj1vTKAAoyj69D1qVQ7PTLc0w4nQdrE2Y?=
 =?us-ascii?Q?Cn04Y1YlS2Fk5lBWkiBKwZ74Y3WjEPv/9HaTeSatbF2PwMq7JEFQf0+xR1JV?=
 =?us-ascii?Q?wqA8GiY1GKv6OLjp6JeihzwQ/cMQfUrgT+2UZW34NKAR9wurTRzYawhHtmVk?=
 =?us-ascii?Q?HvFwN80p+kBMtEcSCivY5w5pY+BAtsgYukeukq+ShZp82Cw+FyG+rarPGCOp?=
 =?us-ascii?Q?ygVYhsAl7++fCzkWos4fZNB8ywvAxk74UQ8naKHdOWlYZZV1TZLYEustZPbZ?=
 =?us-ascii?Q?DfoSKlIgjcb5JwqrRd/TtB43vU5k3EruEla3OZNddi3sxxnVCMFHO/SDQRwI?=
 =?us-ascii?Q?nzWrk24cM9JkvjafedsfJxD6h2Gnz1Kjyz/GuNSGwUXWyKq56vxN2X2+F7u4?=
 =?us-ascii?Q?5xjp7sM0iUlMZ6noDR25IAAGDh8Ka7y6jTJu/CTRDt7J93dRtvoj/hC7P00o?=
 =?us-ascii?Q?TiXVWBKqsvloRCCrvJp6uP2GzhWPy6bIdbj7pAlGqXlf8e8aDCjlDJWiPtJz?=
 =?us-ascii?Q?tlxC/Vu5jyCEfKL6g+fUcetaiu44XgmA3CIOee69OBGffBIpM9U4y5eZfzSL?=
 =?us-ascii?Q?hFf0bC6UtA+d4fD7MBigX5N6rXWfj9MTa05batdaGVeairvD7JYK1P1AKeBM?=
 =?us-ascii?Q?HijKYvto7g0lOl20RS+ubLkJrunE0OdoIwMgGgpuZoua0Ep0PHA5LI+lfW4t?=
 =?us-ascii?Q?C8c1pr/GhvaoiPF3mXilUUmrPYRhUSjzCj7l3rXpJ2LPxcgcRxgfULaHVny8?=
 =?us-ascii?Q?VAbQJ39L49v4HOZibznvjyHDP2/I+noXoAH6RaxP0hcRqRlwuD6bk/BxI8iq?=
 =?us-ascii?Q?T4lyrnzLa3PeltHVsyaEzN0QwIMkAvifAL+u9FqifIy1Q2MtKWNBV+v/C+ay?=
 =?us-ascii?Q?eQ4+l9Q0z7qJNB9hWD2NSZmCSJLUv8hKpwfwZlvMmyLtZYGbNrCEA5MV38Hq?=
 =?us-ascii?Q?tcBfkTagofYIKZZYnpEO4tyV7VUd+cu3BtYJEEhxyew3zyLf7nXkYGMbaMs4?=
 =?us-ascii?Q?E8owLMcEgbmJ0kyTqBXWyuChgZX1WGIcCCyXmPbRxV5215yycm/IU5zv+mSY?=
 =?us-ascii?Q?rdHBUvHeV3uBCHsOKcZbsJSETfwoS7eTrW9+lZwyW7ZqMTbfljj9S3NMMAxU?=
 =?us-ascii?Q?d9ZwplEFyBTTo6pWQn6UHf2fkwe+vZvX3dxb9Laq75Q9MNh77LrxRVH1njKp?=
 =?us-ascii?Q?pvka3xW1e6jLci22CYZmRKTrcSTqzIhXA/X36COZLMCXnvsBmPE4cLmRaJOz?=
 =?us-ascii?Q?Hdr/MW7VALKVXalaecjUjByeSCisEXb9hJhKEV/xZgjlKmLNIM2uRWAd+sl1?=
 =?us-ascii?Q?/qRFGAopH+XJS9oMeaso1bPttnz2F8yvcpN8U+TGwxLynkDSNqGaMLp2bTqQ?=
 =?us-ascii?Q?XIYx99ha4EPn1DxXfFu2Rcae+46HiXfTgO8svElR/rmveHEw8MJs683qXXsy?=
 =?us-ascii?Q?YQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c36dae4-c3c3-474e-54ad-08da8c3ac38b
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 16:55:24.5369
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZsytpslLccu/OTq5GyFUGz/SQ9UkZyL8HCEnElckkgL8QgKSuplHhQ9eTGmxr+bXxh9gP+o+9zY8FRTDmhJBaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4131
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-09-01_10,2022-08-31_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 spamscore=0
 adultscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2209010074
X-Proofpoint-GUID: nTjkDiGGwga5cRQlDUvmufYcV1-pzHCO
X-Proofpoint-ORIG-GUID: nTjkDiGGwga5cRQlDUvmufYcV1-pzHCO
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/30/22 11:09, Sidhartha Kumar wrote:
> 
> 
> On 8/29/22 8:33 PM, Matthew Wilcox wrote:
> > On Mon, Aug 29, 2022 at 04:00:08PM -0700, Sidhartha Kumar wrote:
> > >   #define TESTHPAGEFLAG(uname, flname)				\
> > > +static __always_inline								\
> > > +int folio_test_hugetlb_##flname(struct folio *folio)		\
> > One change I made was to have folio_test_foo() return bool instead of
> > int.  It helps the compiler really understand what's going on.  Maybe
> > some humans too ;-)
> > 
> 
> I went with returning an int to stay consistent with the page version
> of the macros which return an int. I'm fine with changing it to return
> a bool.

I believe the page test macros returned an int when I added the hugetlb
specific versions.  So, I just did the same.  Since they are now bool,
it makes sense to have these be consistent.
-- 
Mike Kravetz

> 
> > > +	{	void **private = &folio->private;		\
> > > +		return test_bit(HPG_##flname, (void *)((unsigned long)private));	\
> > I've made this tricky for you by making folio->private a void * instead
> > of the unsigned long in page.  Would this look better as ...
> > 
> > 	{							\
> > 		void *private = &folio->private;		\
> > 		return test_bit(HPG_##flname, private);		\
> > 
> > perhaps?
> 
> Ya this looks much better and passes the tests, will add to v2.
> 
> 
>