Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Sep 2022 11:01:37 -0700
From:   Isaku Yamahata <isaku.yamahata@gmail.com>
To:     "Huang, Kai" <kai.huang@intel.com>
Cc:     "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Yamahata, Isaku" <isaku.yamahata@intel.com>,
        "Gao, Chao" <chao.gao@intel.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "suzuki.poulose@arm.com" <suzuki.poulose@arm.com>,
        "isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>,
        "will@kernel.org" <will@kernel.org>,
        "anup@brainfault.org" <anup@brainfault.org>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "imbrenda@linux.ibm.com" <imbrenda@linux.ibm.com>
Subject: Re: [PATCH v2 04/19] Partially revert "KVM: Pass kvm_init()'s opaque
 param to additional arch funcs"
Message-ID: <20220901180137.GI2711697@ls.amr.corp.intel.com>
References: <cover.1661860550.git.isaku.yamahata@intel.com>
 <7f4a3ef13cc4b22aa77e8c5022e1710fd4189eff.1661860550.git.isaku.yamahata@intel.com>
 <7f3003465bc8e7a75d7e27a0928271210c5e2323.camel@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <7f3003465bc8e7a75d7e27a0928271210c5e2323.camel@intel.com>
Precedence: bulk

On Tue, Aug 30, 2022 at 10:39:48PM +0000,
"Huang, Kai" <kai.huang@intel.com> wrote:

> On Tue, 2022-08-30 at 05:01 -0700, isaku.yamahata@intel.com wrote:
> > From: Chao Gao <chao.gao@intel.com>
> > 
> > This partially reverts commit b99040853738 ("KVM: Pass kvm_init()'s opaque
> > param to additional arch funcs") remove opaque from
> > kvm_arch_check_processor_compat because no one uses this opaque now.
> > Address conflicts for ARM (due to file movement) and manually handle RISC-V
> > which comes after the commit.  The change about kvm_arch_hardware_setup()
> > in original commit are still needed so they are not reverted.
> > 
> > The current implementation enables hardware (e.g. enable VMX on all CPUs),
> > arch-specific initialization for the first VM creation, and disables
> > hardware (in x86, disable VMX on all CPUs) for last VM destruction.
> > 
> > To support TDX, hardware_enable_all() will be done during module loading
> > time.  As a result, CPU compatibility check will be opportunistically moved
> > to hardware_enable_nolock(), which doesn't take any argument.  Instead of
> > passing 'opaque' around to hardware_enable_nolock() and
> > hardware_enable_all(), just remove the unused 'opaque' argument from
> > kvm_arch_check_processor_compat().
> 
> This patch now is not part of TDX's series, so it doesn't make a lot sense to
> put the last two paragraphs here (because the purpose is different).  I think
> you can just use Chao's original patch.

Ok.
-- 
Isaku Yamahata <isaku.yamahata@gmail.com>