Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220901175022.334824-1-cezary.rojewski@intel.com> <20220901175022.334824-3-cezary.rojewski@intel.com>
In-Reply-To: <20220901175022.334824-3-cezary.rojewski@intel.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 1 Sep 2022 22:38:40 +0300
Message-ID: <CAHp75VdVqRyA=J0-HsHtgiAZhd8XxqxmMddTyV2u29TxvV9=Cw@mail.gmail.com>
Subject: Re: [PATCH v3 2/2] ASoC: SOF: Remove strsplit_u32() and tokenize_input()
To:     Cezary Rojewski <cezary.rojewski@intel.com>
Cc:     ALSA Development Mailing List <alsa-devel@alsa-project.org>,
        Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
        Jaroslav Kysela <perex@perex.cz>,
        amadeuszx.slawinski@linux.intel.com,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        =?UTF-8?Q?P=C3=A9ter_Ujfalusi?= <peter.ujfalusi@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Andy Shevchenko <andy@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Matthew Wilcox <willy@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Sep 1, 2022 at 8:40 PM Cezary Rojewski
<cezary.rojewski@intel.com> wrote:
>
> Make use of global user input tokenization helper instead of the
> internal one as both serve same purpose. With that, both strsplit_u32()

the same

> and tokenize_input() become unused so remove them.

...

>  #include <linux/debugfs.h>
>  #include <linux/module.h>
>  #include <linux/pm_runtime.h>
> +#include <linux/string_helpers.h>

I believe either blank line needs to be here (to split the sound / SOF
group of headers) or this should be put after 'so*'-ones

>  #include <sound/soc.h>
>  #include <sound/sof/header.h>
>  #include "sof-client.h"

...

>         struct sof_probes_priv *priv = cdev->data;
>         struct device *dev = &cdev->auxdev.dev;
>         struct sof_probe_point_desc *desc;
> -       size_t num_tkns, bytes;
> -       u32 *tkns;
> +       size_t bytes;
> +       u32 num_tkns, *tkns;

I would expect a longer line first.

>         int ret, err;

...

With the above addressed
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

-- 
With Best Regards,
Andy Shevchenko