Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bcdba86f-45ca-3e6f-e03c-5c991fd08235@intel.com>
Date:   Thu, 1 Sep 2022 13:56:10 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v7 10/15] mei: mkhi: add memory ready command
Content-Language: en-US
To:     Tomas Winkler <tomas.winkler@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
CC:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        "Alexander Usyskin" <alexander.usyskin@intel.com>,
        Vitaly Lubart <vitaly.lubart@intel.com>
References: <20220806122636.43068-1-tomas.winkler@intel.com>
 <20220806122636.43068-11-tomas.winkler@intel.com>
From:   "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
In-Reply-To: <20220806122636.43068-11-tomas.winkler@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFN5T1hCWmswWld2VUNYK3ppZWlWVjAzU0JRTXhSekZmYlJIdVlUQVNoc2Uv?=
 =?utf-8?B?dksvcVlrV2ZKYXRUUmpUNGtFYUl2VDBrVnNLeFB1b2p6THNYSnFKRnNTRTBp?=
 =?utf-8?B?dnI2WGlTZ2tzVHJiRWdLOTBvVzc3UlJRVkFsMGxMRlZZWm9mQ1JCSzZMOVA1?=
 =?utf-8?B?dmhKVWVvVFluTXNDM0hEWmxzU2FUbWV4S3dlSWJhaGZBTmpSNTRpVTJlQjY0?=
 =?utf-8?B?ZDN1akhaemZ5aDhLaGtISTBndm5OZHpobkZadmpXSmJrYjcvc0xyYksvRWE3?=
 =?utf-8?B?U3ZFSy83bUFNYURJT01haktidGptUmt4ZzlaNUQwVEFJaVZtL3Y3K0xmaG85?=
 =?utf-8?B?TEhNZndwVmgrMW1ZYjJLTzFzU3pPZDZqYW1XSTJ3RlExU3A4SytLeVVVOHlS?=
 =?utf-8?B?NGcvL0dob01Dc3hYYjBtQklHaEs3YVQxZCtKd1pqb0VlNVRSN1Vpb1ZkWFpP?=
 =?utf-8?B?cFU1VkpvMnFkWDlqNVR0eDYrYU83dzJ6N3RyRTdud2lqS0x6cmpxTEE0Qkk4?=
 =?utf-8?B?TGs1dkE1NWljdlhnb0NzWWxVdEtTVGtkUDJTS2tSZDBwcFpjZjc1eGRxdld6?=
 =?utf-8?B?TnlySThhTVM5Y1dRc2NYVXBPNlpMZERJSWNjRUpZd2taMGZFb0VleGNlMG82?=
 =?utf-8?B?Y1FMMk9GalYrbVh2RVdrTnFvb0tpdHFGcG85YzRkaE91blNIOGorODRSVVRu?=
 =?utf-8?B?blNrSy8wdlYyWVV3a3Q1eTA4RWV1dUE3MlJEeFpPSjRFbTUyK3pwSkxZKzky?=
 =?utf-8?B?NjFNOTB5RGs4dFVIWTZDVGd2OXpkdDJQdDVpWkpvNUtYVTVTcC9HSVU3eS95?=
 =?utf-8?B?THNqKzIxN3NTTXQ1TDFaZzU4aE4xRm5tWlpTR0pUR1hFTjVIWDJPc1M3RzNE?=
 =?utf-8?B?WFI1d09tVVlHQ01OaFlrdEQrNWovQ2J0NXcyRE1CT2svR2d2ejliQklVM0dJ?=
 =?utf-8?B?QzdqcXlwT2tLbjdZdzRMSEg1STVtcStjbU5QTitsY2hIT0MzMXgwRWduZUho?=
 =?utf-8?B?VzZLcVltdnA5ZEhtNnY0S2FoZ1FqYnlkUnN4NG4vSk45c2dKRUd3djI2eU5F?=
 =?utf-8?B?MFlQWmxnbHRnM3hWUnArVHRkR1A1aGdHa05BZUNQVGl4dzdiMVZ0ZHBDUnhx?=
 =?utf-8?B?K2cvY1QrZmVBRy8zWlorU3c0TXlXTGZ4c0NHK2hsSk9kQWYzTkpXdE9GejFp?=
 =?utf-8?B?UythaTVSaDRWZVhwRG10VnFtYXdTZkJ6ekJ4MFRucjZxUUs2Y3BxUUJrQi9Z?=
 =?utf-8?B?NGNQTmxGT3VUM2JmaXJ6VjQzN3NKNTgyU2IydE9qSjB5b2tHK091elJUMkJ0?=
 =?utf-8?B?SDl0UU0vUXVuNnZyMDFUY0NGM2cxS1NZbllpdWZXWENkRGFLd2hvaWY2NDlM?=
 =?utf-8?B?dVV5SnJLOTEwYWgrMW5vR1hFOWt0bzVzV1lFeE1SZWVINmxRdFAzei9Pc0Nk?=
 =?utf-8?B?Qk1RdENtMjBDQjloNHV2emVtL2tVV1lGQUcxUlI2emNoT2xSYmw1TyttQzQw?=
 =?utf-8?B?eWNhbHdGM0x5QnB3dXA2ZUdGMElPZk44aUhEMDdYdlJ2ejI3Q09jc1F4Ri9s?=
 =?utf-8?B?bzEvMjNNa3dHYjdMMk0yUW56aXBxQ1A1SDlCNEh3T0N0cHhoTmtWN0ZzNnpZ?=
 =?utf-8?B?M01kakxSK3FIYzBpTjg2Y2pQbzJPeWxnOGdoWkV1UXZxMzMyRFdOcmxRU0Z6?=
 =?utf-8?B?alFGRWZoeWJtTW8rTEV6OTFWbnYyVEVyUnZ4VVY0eUorVjBRazU2bHdGTmZC?=
 =?utf-8?B?UGF3K2hEN0RTcmMxTXBnV1VZOHpaellPVk11eVhNU2EyTlZWZDNMQzRObVhO?=
 =?utf-8?B?MjRQR1lidHNIK1daQ3J6Sndta0FCZFV6RzVtLzZRaDF4bkRIcFFYdkJuUWhN?=
 =?utf-8?B?aytleTF5b3NtMDhkMmY1c013aFFaRWxsWjFtb3BCZzdnaTliY3I3dEMxejRI?=
 =?utf-8?B?QnBaaVM2NkxVamhNNVRnaHdvc25lNEVtdktGRjNqMWxVNk8rOWZnZ2ZJUXhy?=
 =?utf-8?B?d3h6S05EU2xzYTJ5UlFtanFsNUY2SVBNUmNNRisreDlldUd1ZEk1YitXUzJT?=
 =?utf-8?B?NU5xVHV0YnF6Y25maFJ4VXY5WFU5eVdtWDNnZTdobHZpWlZNTTlpSzV5VW5K?=
 =?utf-8?B?ZjRRclBpaDZpdU9HeDgvRHpURHVheDhoWDVKM01vUnJuMEJSbHVVd3FJQkNk?=
 =?utf-8?Q?KH+OqKTVbONqXitk/Ui1/b8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b817d588-7596-4294-179f-08da8c5c6794
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5488.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 20:56:13.0547
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GE3SsbYSOSbWKiYnE2igHDQjN3U9FcSO3+Ss29fl6B9P4an1x5CER4dHIWYrcvWi7XuQTcos+MNuK+3HynUq2Md0SyZdSzaCP1CyqQgO6HE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4899
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/6/2022 5:26 AM, Tomas Winkler wrote:
> Add GSC memory ready command.
> The command indicates to the firmware that extend operation
> memory was setup and the firmware may enter PXP mode.
>
> CC: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>

Copyright date aside, this is:

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   drivers/misc/mei/mkhi.h | 14 +++++++++++++-
>   1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/mei/mkhi.h b/drivers/misc/mei/mkhi.h
> index 27a9b476904e..056b76e73d40 100644
> --- a/drivers/misc/mei/mkhi.h
> +++ b/drivers/misc/mei/mkhi.h
> @@ -1,6 +1,6 @@
>   /* SPDX-License-Identifier: GPL-2.0 */
>   /*
> - * Copyright (c) 2003-2020, Intel Corporation. All rights reserved.
> + * Copyright (c) 2003-2021, Intel Corporation. All rights reserved.
>    * Intel Management Engine Interface (Intel MEI) Linux driver
>    */
>   
> @@ -18,6 +18,13 @@
>   
>   #define MCHI_GROUP_ID  0xA
>   
> +#define MKHI_GROUP_ID_GFX              0x30
> +#define MKHI_GFX_RESET_WARN_CMD_REQ    0x0
> +#define MKHI_GFX_MEMORY_READY_CMD_REQ  0x1
> +
> +/* Allow transition to PXP mode without approval */
> +#define MKHI_GFX_MEM_READY_PXP_ALLOWED  0x1
> +
>   struct mkhi_rule_id {
>   	__le16 rule_type;
>   	u8 feature_id;
> @@ -42,4 +49,9 @@ struct mkhi_msg {
>   	u8 data[];
>   } __packed;
>   
> +struct mkhi_gfx_mem_ready {
> +	struct mkhi_msg_hdr hdr;
> +	u32    flags;
> +} __packed;
> +
>   #endif /* _MEI_MKHI_H_ */