Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp1204239rwe; Thu, 1 Sep 2022 14:24:10 -0700 (PDT) X-Google-Smtp-Source: AA6agR7hop8oUAN3bbEDz4Tj1815cfV6nKrHU8VqN2tie4dh7JVD8y45hbG4hdAFHAr6ii3GJG/N X-Received: by 2002:a65:6055:0:b0:42a:7b2b:dc71 with SMTP id a21-20020a656055000000b0042a7b2bdc71mr27554298pgp.23.1662067450314; Thu, 01 Sep 2022 14:24:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662067450; cv=none; d=google.com; s=arc-20160816; b=pAHH1B6bRBgJZp2pT6tSNjirPKyW27WJh2tO4kO15E6OQ1Nskaq2+elqvCKzUCb5c5 ZP58VvH2l8ZSmU24rTVEoTeX6SSvzcIpN+/kivbBWLdje0t9VmoCOVNF+n+GRxJWMvWh O6WVlEDtF+7E6bqXKLHD8oXp7C6zPneXaWbmhD7EQ/alWVM2o/4JRWTaVhP0gUh+bRaz rwraRzYJE+byarQ5bOw3TaF1lZT1dCYWlrnxde2rXeVSBYwyJWP3+fq69KyTKGUPFDDB Qb8l+yDiBwTAZwWbSBrQPpb3jdAv2XS/hU9Yy06zeK5cDyTp5NkZr1XGopCJRHuJtY3i GW/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=Bh20NUoo2fOXNGDb/JZVci9QFUqboRu1LC1ZZRHvZjM=; b=rBKIAJ3W95rXh0+PKh0LSi8jKR1eF30PGpzFWVF3uwLbrAUFq3kxtOmnAlsDtAFpvC YltAiuCEY3CBI5/HQXD/ccaewGCrTDvKIFsz2PocGJekRKBrQ6OevLDt3MmVc7/Hf5FR UsSFc7sPw2q7WfFePmHgzgzipK/OEG9ukAgRKJrj9ri87qSIMI+NqUmLHufnGANgPi9T EOPZsP2PpY0bXEbFu5h3z0LJXDPwJkEN5v02sD73cV0bWuwRhVOZ9Gc2yCqqJr25mU/z 1nlpelVsVYSlUtdBvBfXTnWr+ujCM4iAYJUQF0TlkO28qP42xPILPihb6uXa5kIiXhnT K1wA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L9f1ZUR7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m4-20020a17090a7f8400b001fa55447988si245515pjl.40.2022.09.01.14.23.58; Thu, 01 Sep 2022 14:24:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L9f1ZUR7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235006AbiIAVKV (ORCPT + 99 others); Thu, 1 Sep 2022 17:10:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231326AbiIAVKS (ORCPT ); Thu, 1 Sep 2022 17:10:18 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9626A3DF20; Thu, 1 Sep 2022 14:10:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 553DBB82939; Thu, 1 Sep 2022 21:10:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 048A8C433D7; Thu, 1 Sep 2022 21:10:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662066615; bh=uK3LHkBlUkCOueQhUHBS1Wh7J6xa+HkoKB/uvtNZ+7Q=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=L9f1ZUR7SZ2ptNG18dUDqMum9Fap9E17qwbmgSjukK3YTepFf8GsPzuF9NNOJxL7b SSp3LKlnUGUTZNAFWi0+E3xjFedJ5iZoyPXJFexRHIOdFb3ASH9gGctK+rJXxtxv9C 4ykMO6VdefnbMFyVf2I9LE4n3OGLs8DuXQzxeudV0OK7Z26CGXGurQd28+HZQ8u/SF u7248d220Op4gOjTE0qCRO8H+d4VkZmslrehBApd7/LUAqGiOzclovbUAeLCYckW+z pmGA7eLFhABYLTxCcvg6cjEjbntDigoqRUELQCC5zVH/qu8MFw+BRr1Ny32YtLei+1 JWC+HX3fcAnHA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id DB212E924DA; Thu, 1 Sep 2022 21:10:14 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] bpf: Remove useless else if From: patchwork-bot+netdevbpf@kernel.org Message-Id: <166206661488.11491.13732223075037979617.git-patchwork-notify@kernel.org> Date: Thu, 01 Sep 2022 21:10:14 +0000 References: <20220831021618.86770-1-jiapeng.chong@linux.alibaba.com> In-Reply-To: <20220831021618.86770-1-jiapeng.chong@linux.alibaba.com> To: Jiapeng Chong Cc: yhs@fb.com, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, abaci@linux.alibaba.com X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau : On Wed, 31 Aug 2022 10:16:18 +0800 you wrote: > The assignment of the else and else if branches is the same, so the else > if here is redundant, so we remove it and add a comment to make the code > here readable. > > ./kernel/bpf/cgroup_iter.c:81:6-8: WARNING: possible condition with no effect (if == else). > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2016 > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > > [...] Here is the summary with links: - bpf: Remove useless else if https://git.kernel.org/bpf/bpf-next/c/ccf365eac0c7 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html