Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c043ee8d-0961-f533-1085-274f3e7d08d4@intel.com>
Date:   Thu, 1 Sep 2022 14:19:47 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v7 12/15] mei: gsc: add transition to PXP mode in resume
 flow
Content-Language: en-US
To:     Tomas Winkler <tomas.winkler@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
CC:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        "Alexander Usyskin" <alexander.usyskin@intel.com>,
        Vitaly Lubart <vitaly.lubart@intel.com>
References: <20220806122636.43068-1-tomas.winkler@intel.com>
 <20220806122636.43068-13-tomas.winkler@intel.com>
From:   "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
In-Reply-To: <20220806122636.43068-13-tomas.winkler@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDA2MCtlR3dxTGxGOXE2SUJRQW96UmJPSXlxaDNXSnNPRUYzZEhqOWlCQUR5?=
 =?utf-8?B?dkFCTEdDc1pXcjVDSmNTVHdyMytVMk1wMkkvSXkxSGRWcHgxMVl2SWRESDJo?=
 =?utf-8?B?RGJrdS9FbW5CbFE2REZaRWE4b1IvWmNiVHRpNHNKWDJ5YTBVNGlhSDlZVDEr?=
 =?utf-8?B?RXlsK0VNb0lwYTJkZVJWNjNaNkliS2dycFl5U2VramFuMUZiWkN5R1VwWThh?=
 =?utf-8?B?Rm1QbEpKclNIbHZqL1FKK2ZETW9WMDUwRDFWYUsrWG9rTVUreGJJdjA1MEVi?=
 =?utf-8?B?MndCenV5b3FKYlpHbDlqUEsrVjlFNjRHUk04ejUxTmRZZ0xxcEgvakl1QzVZ?=
 =?utf-8?B?WFFyZmhNdnNTS0ROVHU2cjBLTUcyY0JUUGxsZFJZM2N4RW9lVkI2YWUrVE11?=
 =?utf-8?B?bjhXVzRmWlNieDZma25MQzcxd0o5dFUyeEI3RTlXSXFXaHh2OUFvbW4xU2NB?=
 =?utf-8?B?NzRuK2xNOUlTUzBudFQrOFppSmdGQ2gxMGwwd3l3OFFMbnBRZ0VDNHZpU09z?=
 =?utf-8?B?S3I3bkY3eTZiNllTeEs5aUwveXVObjBYc3JPbVZtV0NqbTViMStKK3RwMTdQ?=
 =?utf-8?B?eU9GVGFGblJteDl0U29IQjBsS0pSNW0zLzliWWhUc0xkN0t2Y3lkOW5iTGdH?=
 =?utf-8?B?Ni9nZE1IdXpXTW05UThvYW1HNVJGcmx0am0vcWxXaWFoTE5ZK0QyNllSZHoy?=
 =?utf-8?B?SXBxcVlBRGxUTm1OV0NDQS9qWmMxN2xOWjF0NjQrMGh3VytWUlNUWjJuNEs1?=
 =?utf-8?B?TlNNTUhrMldzbnpTcHRyUitBWU1XdE9FNU5jQVJzUyt1eEhyM1JIQnpOL210?=
 =?utf-8?B?VXhSbGhDeUJxbmtXU2VxcUphemdLakhlQlluelFXNnBnWXpjSExEU0hTR3Yz?=
 =?utf-8?B?dkNhWVRYbDhqT25WelE1TkZyQ0RtSEZ4dzV2UHdWQnYxNGNmUWNMWTVSdnZu?=
 =?utf-8?B?cWRHeE45c1JqOHFLazhyY1EzSHFlOFBYU2FCN1NaL1BOSUdwOXBJVWowRC9U?=
 =?utf-8?B?MVRhVC8wZUl0dHlaTVRRTXl3OUkvaFcwNG5SeW02T1VkdGZURXUxWm1jWjRH?=
 =?utf-8?B?Qk1INnlRRXRsbXZBVWRYUVQwU3JrWXdNbVFSVnBEUGQ3UU05clE3aVljdlZa?=
 =?utf-8?B?c2tSRkdWQVlWR3d6SlZ5RFFUc05NbnhIbWtXSXlyUmZKb0wwMVQ4VXVoV25O?=
 =?utf-8?B?eHFSYnpnVldKYWVPMlQ5STdEUEtNMEEySW0wTWtQM250K0hsZFBBVkd0U3pq?=
 =?utf-8?B?NmZCNzM1cmZnOU9qZ1EzeDRvaHdQUlVwM1N1T1dWd2FlL2pXVENzU25PTldC?=
 =?utf-8?B?Rm9BeDg2UmtlSnlqODhHUVAxTWF4RFBya0RiTmhPQUlkdGdNNCtzZHcyQ1o5?=
 =?utf-8?B?NXBEYWdNZnc1SzllRmlyM1lDVHYxQk9mQzlGZ3NhNlpWQVJnVTM1WWk4RkQx?=
 =?utf-8?B?V0VkaXZ2UjVXVG0yQkFielhrWFRmbk1DYnc0Z2VEazQrVnZNeUFXVlB4MEJK?=
 =?utf-8?B?OFJGQ3BCU2pnOXk5SlB2UUdhcVA4THlaNkhZV0FHTWVmYS9ZRURJektEcjIz?=
 =?utf-8?B?Q0pwK3FGSTlSTk8xYXFlcXoxOXpOcXhHeW5OVVkyZWxrVktJM3hQb09weGlm?=
 =?utf-8?B?MFcxNlBZK1owQ1NHUkhNVkxVeEFtald1czExcmpsb2RlckwrYXE2QVltRU5N?=
 =?utf-8?B?Z2pXNXIrUmozcEJVaTRXY2pCS2ZTSGhaMTgrR0VFQ1RWTFlQeUEySHdIUEsx?=
 =?utf-8?B?RkhZVFRSczNsWG9hVnhyUmRjcC9tNXhhTlc4SGpzWk11cjFoamFkTHA3Wm1a?=
 =?utf-8?B?Z0V4UFhFcWdMaGZ1R21Td3FZQW9LZ0RLRTl0amdhaUcvajZIVWZCRDJmcjBD?=
 =?utf-8?B?N3FuK2N0UjAxckh5UlM4SCtRbzF1OWkxL2dQaGpRWGRybGdoREhQbjRlVXYr?=
 =?utf-8?B?ZXJpR3N5NnUxTE9FL1BETTJHcWtRWDRzdkcydTIvVnFEOEdzSXNud09KQmdI?=
 =?utf-8?B?eUs0WkFvQXk3NGpoMWRNdnVPOXFxdVFobTgrZ09UbTVpd3BlZ1lLb0tDWmZO?=
 =?utf-8?B?cm1DYkN6bDIxYmdPK09RUnoveUxvOUZxZ3NKSzc2aCtpbnpFMHhwOHh4Zndx?=
 =?utf-8?B?ekNPNzY1SjM3SEljU09VVlk0a21XYzhjZFVzU0N1dWFlN081TGE5L0NPdnE2?=
 =?utf-8?Q?ELXHPrrRnVz15DGVlMLdpU8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 872ae640-47bf-4167-f334-08da8c5fb490
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5488.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 21:19:50.6932
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SL6gWuTYAwBNiRi+vPcWip0U0OynIKJKBSlWodUB9K8bWzqZrG/9uBNaYf1eQqFOd2a8tO7ct4bpugGCQUifpaJuRGMp7X4TKoekZJTNk4o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6930
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/6/2022 5:26 AM, Tomas Winkler wrote:
> From: Vitaly Lubart <vitaly.lubart@intel.com>
>
> Added transition to PXP mode in resume flow.
>
> CC: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   drivers/misc/mei/gsc-me.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/drivers/misc/mei/gsc-me.c b/drivers/misc/mei/gsc-me.c
> index 6b22726aed55..75765e4df4ed 100644
> --- a/drivers/misc/mei/gsc-me.c
> +++ b/drivers/misc/mei/gsc-me.c
> @@ -182,11 +182,22 @@ static int __maybe_unused mei_gsc_pm_suspend(struct device *device)
>   static int __maybe_unused mei_gsc_pm_resume(struct device *device)
>   {
>   	struct mei_device *dev = dev_get_drvdata(device);
> +	struct auxiliary_device *aux_dev;
> +	struct mei_aux_device *adev;
>   	int err;
> +	struct mei_me_hw *hw;
>   
>   	if (!dev)
>   		return -ENODEV;
>   
> +	hw = to_me_hw(dev);
> +	aux_dev = to_auxiliary_dev(device);
> +	adev = auxiliary_dev_to_mei_aux_dev(aux_dev);
> +	if (adev->ext_op_mem.start) {
> +		mei_gsc_set_ext_op_mem(hw, &adev->ext_op_mem);
> +		dev->pxp_mode = MEI_DEV_PXP_INIT;
> +	}
> +
>   	err = mei_restart(dev);
>   	if (err)
>   		return err;