Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <529143eb-6d50-7dba-de63-cccef05b898d@intel.com>
Date:   Thu, 1 Sep 2022 14:20:49 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [Intel-gfx] [PATCH v7 13/15] mei: debugfs: add pxp mode to
 devstate in debugfs
Content-Language: en-US
To:     Tomas Winkler <tomas.winkler@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
CC:     <intel-gfx@lists.freedesktop.org>,
        Alexander Usyskin <alexander.usyskin@intel.com>,
        <linux-kernel@vger.kernel.org>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Vitaly Lubart <vitaly.lubart@intel.com>
References: <20220806122636.43068-1-tomas.winkler@intel.com>
 <20220806122636.43068-14-tomas.winkler@intel.com>
From:   "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
In-Reply-To: <20220806122636.43068-14-tomas.winkler@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZitKUkNONG1FbmIwd2RQbDB4WDN0SFFJcEU5dDRnUmI5YjNaQlJ3RGN1TEV1?=
 =?utf-8?B?S0lySmFVeDdYSmMzWngrQ3cvZkxtOElhNkdFd3VXRDIyUEYwaXNwdW9xeXlv?=
 =?utf-8?B?NUVFSFNrVWY5bmY0ZGc1V1pYaTZJV3JPRytHemMxVEZzK0dVVnJGZEtMRkow?=
 =?utf-8?B?STJ6R3EyUzVWbG00bnUxbDJFWWJMVmtPbHNIQlFPb3pFQ1VLejFZUDZBTjhu?=
 =?utf-8?B?U3Y1UFExdVFHTmpMemlMVVVhWXR0NW5sbkJCRVBBblNBbmNGaWF4a09IZ0Nk?=
 =?utf-8?B?bWptVWpZcURvUzF5S1phSUFId2NyMTNBdkpSZE01bjdVd3JhTFlna2ltd2hP?=
 =?utf-8?B?ODNDU2U0bFpEcW5EbnVMNDUxc1ZoejVtNFEwdWErcUtKR2xkc0dVQ0RkVlhy?=
 =?utf-8?B?bHZyZHZtMVlSUEZlZFBTT1paQ2hGNnNucjAxM3ZOT2hIdXIyckgraTFsYUo2?=
 =?utf-8?B?OGFuVVdnZEdaVDFYVWNBOFcxY3pLL09xY3M3cGlhSm9HUE5pTi9TRDlrMkFO?=
 =?utf-8?B?UVVJeGhpWHVIenQwQ1JhMThuTHYyRUJuL1JRMmQveXRRVXRRZ0Z4NjNyTW5K?=
 =?utf-8?B?RGN6Witld3g2MUFLekNPOEowQUpvMW5vd2RuQ283OFhRR0l3UDE4M2w2bEdP?=
 =?utf-8?B?OHRaaDAzRW9SUWdVVGU3Q2ROcDlFNWt2N05ZV2hoRnZhM2Nmd0RrUjg3RG91?=
 =?utf-8?B?MXhwRVFKS2JRa0E0UktvZlBMVTFMUkRJam1IT3FlMmZpaHdWNGtrKytXeStu?=
 =?utf-8?B?aEtvRFZhbEZwYjJqTlN3WW5zdUsyWlR5aDFCZ2pnQ05pVFFza0VRZktEK2tx?=
 =?utf-8?B?a29VazB1Wms5VFZ3OTNSQ3RmS21TQTlxV3QybUgyeTlMc3B0R1lOWEhycTJE?=
 =?utf-8?B?endWdlVqUW10cFNxaXZoT3BjQm1HMXBIcTA2dVNBeXBXajUyazNFV2ZtR2Vl?=
 =?utf-8?B?dlBEMjRuTWFrcTJyaHovdFZwZHh1L01KNlNIb2FrUExqKy9Bdlk1YnJDVFZk?=
 =?utf-8?B?cUpwZkZkNFMraFp1VXFzblhFOXUyeDZvQUc0ejRHaXlNKzhCdC9Gd2hKWE9a?=
 =?utf-8?B?Z0dKdE8zUjExaEYvKzJZQmJMbEt1ZFJIT0FXaVBFcXV4Y21tSDQ0NzBkcDF0?=
 =?utf-8?B?SmUzY3pwaDQzMFdGMGN6Z2p0Yy9ucklXcXV1dE5hSThGVWoyVW5odGV5WlB5?=
 =?utf-8?B?MkxTeEd6bzdzTTF0QzlSSWdEZVFPYVViU25MblZabHlFOCtBeTJ5Qkg1bmx0?=
 =?utf-8?B?Yk5GK2IzZVFLeVNpaHk1ekY2OHRXNkxjZzhzaEJuTDJNeGNSZW9FTGFxWjFm?=
 =?utf-8?B?VnJia05oUVZLOFZxeDhKZElVS2ZlKzlpc3lrcFMyaDlSVkRNWGRYS2dYQmlS?=
 =?utf-8?B?L2daS28wKzQremt4ajNrWVFHSEI5MEF4d09LNEJtdHVRVTdzZkpsL01ncVRE?=
 =?utf-8?B?cUJJbzc3ZExYaDByMU9YaUxaTXZoVGJGMGl1OFBWSzVKbHh1RzcxRWswV0tt?=
 =?utf-8?B?K0prRlMzVXNQWko1MHZvdkNxMUhreFVIMUpwL01ySlBvSzkyZS9OQjdXOGls?=
 =?utf-8?B?V0xZdGdOVmpheHBJVGxJVzJOUFVRdXV0Nmw2TmQyaTdOd2daMFJnU0hjN1l1?=
 =?utf-8?B?UjZsL0FJVnBLQ25BZk12T3hLTHFmTmplN1BBRjN0K0txN1k0MGFxLzdyVURy?=
 =?utf-8?B?RFVBa2oyU1oxd0pvQVB4N0orWUljNmQrZ2N2L3pjRngwRGZjU0hyZmdPRkFw?=
 =?utf-8?B?MVVHbEQyUll2Unl6ek9ReWo4aXloZTlXcTBiZTYvcTRFdUsyc3dscEZrNTRD?=
 =?utf-8?B?RnNrc0h1Y0Y4TUNoem5aT3F6alVNNW5ZVVNyeldJbGJ0MEVKREdna1dNNzhC?=
 =?utf-8?B?YlQxaEJjMVgzOE5Qb0pmLzh3WDRyN0NmcmxlTy9uK2txbEg4bFYyZ21uU2dt?=
 =?utf-8?B?aHlZVW1FL2RYWXcvbUFCMDNjd0Qzd25JZkUvTWVWaHZFYXE3ZFZIelUvMGV5?=
 =?utf-8?B?Qk00S0RPMWZIT1VvV3p3bUJKTm11V052bEtOUjN6dGNLblpVZTI3WVZDajlN?=
 =?utf-8?B?NFl2RmN6Qkdzb2hJRUJWVXA4TXZ1S0VxVjFKekgwNWtKRHpRTWlpNmJYV2NT?=
 =?utf-8?B?dE1vbHFuWGdNalBmVE82Ym9Va3N6MFRiWVBKT3gyWHg0dmlBN25peFdQOTMr?=
 =?utf-8?Q?t2uvOkvETs+q3YrLXGQm0pY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ccc442e-2e5e-42d0-90f2-08da8c5fd904
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5488.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 21:20:51.8491
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: db76fRtB/lL0bWzVzz0rYhwMUSVZ3nxvoClHXP3IKKeHP+hbjfBkvA7lE3RbxBajn9XlUQrPcpOC9QdHzzE+5SBY7mVyZ/yCip+SWXMIeJ0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2553
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/6/2022 5:26 AM, Tomas Winkler wrote:
> Add pxp mode devstate to debugfs to monitor pxp state machine progress.
> This is useful to debug issues in scenarios in which the pxp state
> needs to be re-initialized, like during power transitions such as
> suspend/resume. With this debugfs the state could be monitored
> to ensure that pxp is in the ready state.
>
> CC: Vitaly Lubart <vitaly.lubart@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   drivers/misc/mei/debugfs.c | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
>
> diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c
> index 1ce61e9e24fc..4074fec866a6 100644
> --- a/drivers/misc/mei/debugfs.c
> +++ b/drivers/misc/mei/debugfs.c
> @@ -86,6 +86,20 @@ static int mei_dbgfs_active_show(struct seq_file *m, void *unused)
>   }
>   DEFINE_SHOW_ATTRIBUTE(mei_dbgfs_active);
>   
> +static const char *mei_dev_pxp_mode_str(enum mei_dev_pxp_mode state)
> +{
> +#define MEI_PXP_MODE(state) case MEI_DEV_PXP_##state: return #state
> +	switch (state) {
> +	MEI_PXP_MODE(DEFAULT);
> +	MEI_PXP_MODE(INIT);
> +	MEI_PXP_MODE(SETUP);
> +	MEI_PXP_MODE(READY);
> +	default:
> +		return "unknown";
> +	}
> +#undef MEI_PXP_MODE
> +}
> +
>   static int mei_dbgfs_devstate_show(struct seq_file *m, void *unused)
>   {
>   	struct mei_device *dev = m->private;
> @@ -112,6 +126,9 @@ static int mei_dbgfs_devstate_show(struct seq_file *m, void *unused)
>   	seq_printf(m, "pg:  %s, %s\n",
>   		   mei_pg_is_enabled(dev) ? "ENABLED" : "DISABLED",
>   		   mei_pg_state_str(mei_pg_state(dev)));
> +
> +	seq_printf(m, "pxp: %s\n", mei_dev_pxp_mode_str(dev->pxp_mode));
> +
>   	return 0;
>   }
>   DEFINE_SHOW_ATTRIBUTE(mei_dbgfs_devstate);