Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Sep 2022 15:13:20 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc:     Greg KH <gregkh@linuxfoundation.org>,
        Petr Mladek <pmladek@suse.com>, evgreen@chromium.org,
        arnd@arndb.de, linux-efi@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@gpiccoli.net, ardb@kernel.org,
        davidgow@google.com, jwerner@chromium.org
Subject: Re: [PATCH V3] firmware: google: Test spinlock on panic path to
 avoid lockups
Message-Id: <20220901151320.3cff1767f88cfb33f394e9cb@linux-foundation.org>
In-Reply-To: <794efe45-2fef-0d3f-b6d0-f2f451be850c@igalia.com>
References: <20220819155059.451674-1-gpiccoli@igalia.com>
        <YxDVPqVkdgQbAIvY@kroah.com>
        <f89cd87c-7d1c-d8e6-ed95-6876f0201872@igalia.com>
        <YxDX9+p+58q2sip2@kroah.com>
        <6bc5dbc3-2cdd-5cb8-1632-11de2008a85a@igalia.com>
        <YxDhiSDs4YcUrqV5@kroah.com>
        <85683284-db85-7e3a-57bd-750e1c204e3e@igalia.com>
        <YxD56RTI9v/P2QOL@kroah.com>
        <b050f00b-6c3a-a0d9-a3c1-175a724faf1c@igalia.com>
        <YxEBCVRgWE8VTZaf@kroah.com>
        <794efe45-2fef-0d3f-b6d0-f2f451be850c@igalia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 1 Sep 2022 16:02:08 -0300 "Guilherme G. Piccoli" <gpiccoli@igalia.com> wrote:

> On 01/09/2022 15:59, Greg KH wrote:
> > [...]
> > Ick, I don't know, this all feels odd.  I want someone else to review
> > this and give their ack on the patch before I'll take it so someone else
> > can share in the blame :)
> > 
> > thanks,
> > 
> > greg k-h
> 
> LOL, that's OK for me! Evan seems to be fine with it BTW.
> 
> Let's see if Petr can jump in, also adding Andrew here since he's
> usually merging stuff for panic.

Are the usual gsmi developers not operational?

Patch seems sensible to me, although the deadlock sounds pretty
theoretical.  A better code comment might be simply

	/*
	 * Panic callbacks are executed with all other CPUs stopped, so we must
	 * not attempt to spin waiting for gsmi_dev.lock to be released.
	 */

?