Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <793bd158-1e1b-2dad-5841-081d840d45d8@intel.com>
Date:   Thu, 1 Sep 2022 16:11:34 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.0
Subject: Re: [PATCH 4/6] selftests/sgx: Add SGX selftest
 augment_via_eaccept_long
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>
CC:     <linux-sgx@vger.kernel.org>,
        Haitao Huang <haitao.huang@linux.intel.com>,
        Vijay Dhanraj <vijay.dhanraj@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Shuah Khan <shuah@kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20220830031206.13449-1-jarkko@kernel.org>
 <20220830031206.13449-5-jarkko@kernel.org>
 <bd5285dd-d6dd-8a46-fca9-728db5e2f369@intel.com>
 <Yw7HOIfnaO0IcDiX@kernel.org>
 <7c85f675-db1a-eb5c-2575-759d662a0ecd@intel.com>
 <YxEvUm9jmHaAbdU2@kernel.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <YxEvUm9jmHaAbdU2@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NlROVU9UNDAyYjlZcnlDd1haMExKM3lrdzEwWG9qcDRNQjhsQjNzdHprYTM4?=
 =?utf-8?B?emV1SG5SdW5iSlFmU0VDa0FRdXlUOEZIWDVCYXJobmFoQkpHa25SbWtNZVFv?=
 =?utf-8?B?QnpmVzd3UTN1U2pYSjJRcW4vNGZyWE9uZDJFS21IVXJSR0hyNW0yYnNrdnJX?=
 =?utf-8?B?MExiSGxGM0xnSlBOQ1MrRlJxbytVOUJIT1I3TjBqUGUwWHgybjJNR0VsV0NO?=
 =?utf-8?B?ZXgyVDhic2FucTE3U1V5U3RheHZXS3luakRjNkhoOW9TR0hwTEs2OFdSUXJJ?=
 =?utf-8?B?THVMN1NKYkVnNEtOSmcxSDZWMTNaN1g1akw5aDVIRU5qS3JMMGRXSE9BN1JB?=
 =?utf-8?B?WTlGKzBMeVZMY1RRcWl6R3hBWkZqYnNKbzI3RFIxZ01xa3ltUFQ2Wi95bEZH?=
 =?utf-8?B?Z25IUDJmMjBlWlkzV3pSRTEvdXpwNUdrdm1FSld0ZW5IekEvc3VCRnd0TFhH?=
 =?utf-8?B?M0FCWStxd09UdlNoTGNvbFZNbjV3R3g4RXFJY0FpK3Z0bU9vYnZGU3ZTdlh6?=
 =?utf-8?B?Nm5IZGxFWENBaUV2Y1cwSUdDRUNmR3pGQkVTcnJQM0VSR3dpTEFjOVFhdUoz?=
 =?utf-8?B?K3NLZnhBdVFTVXhuMnJWeVZVRnlEdWRNRjhnQjNod0VxKzBRNEpCV3JzU2tJ?=
 =?utf-8?B?cml4eVJnWkM3aUdLTUxzd0MwZXdheGFOZUJYWDVDbWdZbExjeGl0REdzYXN2?=
 =?utf-8?B?TW1oSHRYaUs4SXBjUGhBeWNObEJ3eG10M2F4Zjc2T0FDa3Z1TnVraS8yRFJp?=
 =?utf-8?B?NVU1SFZES3lqYS82WGVlQkRVbnFuNjJ2amJqU3FxbXdESDF3bnFSbkx5WlY2?=
 =?utf-8?B?UEgrMjlnclMvbXZNUVlLTVlTcmh6WkZ5cThVZDhxUVJsb3RWMFRNSTZLRERZ?=
 =?utf-8?B?eGFSc0dpTkhVQzlRa3hrSmhWdUpvTkIvNExnc0lxZnFJQzdpYTFkRFE4blM2?=
 =?utf-8?B?eDVjamZUV0IzcGd2UytnSGV2K2NsemxWYWpHdG1hRXJRTUMrK0tKN3pLMWRy?=
 =?utf-8?B?YStSa080bWFjeHBGcGhFS3hoYUJleDUxZmY4NEJjcTZkQWd4OWthYnQ1U0ZZ?=
 =?utf-8?B?NEh4VDZJQXFWSjE4N3N2MjV2ZDB2aEF2dGFuRHRZR0RIVjkwRm9mempyeThM?=
 =?utf-8?B?WmlXOEVtcnFaTzBvdFA0ekEwcGk5a2VYWk5qRkc0akhRblpqazFFaXYwblV1?=
 =?utf-8?B?RVdqOFlNSHZVT242WXhaempYQTBHODJQZUlMMXBWVGhJMlNXendWRFlka0Z1?=
 =?utf-8?B?dlN0ZThXeG05a1ZBclUyOEw2R1EwQWRsM0pQUnErVGhqaEt2NFk4RU9SV01x?=
 =?utf-8?B?RFFVQitXYWcyaE5lSlBvK2FNS014dkZXdUttQkVnTUlDY0Y0cXU4N3JEWG1i?=
 =?utf-8?B?aFRrTkxlcncxaUtJTEI1UUdBRjl3WEtYL3ovdGVSbHRLSEZBbWVacUl2TG9i?=
 =?utf-8?B?UndyZnpHdjJGQ0xoaE11czA4ZXova3JPSFV3RE16U3lneExONytWVS8wNFVW?=
 =?utf-8?B?ZXR3WU9rWjlWVXdDaGwwQzVTbWpCSzFZZEx4VmlhdWovSDVwVHM3ODh1ZXRo?=
 =?utf-8?B?NXFWK3RwZXpnZUk3SHFkbXpJSktYTTVDNDhHUXpvZ1FOaThaaU94TEtkVW1o?=
 =?utf-8?B?VVJHNlpRNGIzT3ZSbjJSVGc1cURBS2Vyd3Nnb0lKQm5QT2x3R1FseE1ySkwr?=
 =?utf-8?B?WHNZWVhPdmlUeHdLbUlKZEtuSVMyQ1BZZUFtcVhRZXA4WWNkalNVeVkxYzV6?=
 =?utf-8?B?NUh4TEVkVEFRelFWN3hkdE5sZWtabEkyUGU3WS9QdDhoVEt0aUZid1pNdzAr?=
 =?utf-8?B?Z21PeWtXQ011TDdkOGVoZXBENFFHelhoRDNXQjZGdURLNzZiTWQ0MXlLZms2?=
 =?utf-8?B?dzJWWVJoa29jVUJlMSt4bUJxc1FCVEh6dXNNYVppbzJCSGxYdWdVNE9Xa0dY?=
 =?utf-8?B?dDViaGVwWWc2aGU1UzFPWHU5TldpNzVLTmhnYXFuNlRSSFU4c1BlTUJDNFBN?=
 =?utf-8?B?blNsdEswblpwWXlLL05nUW9JRjhVQXdMSmZZSkViaFdOR3I3NEV5NU9nWXp3?=
 =?utf-8?B?UDd4d29GeTdKUlFwbGNmeFhtUzBGaWdEam8vdzF3aTBMVGUwTUk0SU1XRGhv?=
 =?utf-8?B?NmNHWDAzMFRVZ0Y5azZTaFVSd1BHNXd6K1cwZ2xFYUlXRnRkbXVncjFWb1B5?=
 =?utf-8?B?bFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3bd5ff7b-84b4-4684-0cbc-08da8c6f5192
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 23:11:36.5693
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gr3SmwwAM3kehZUNbGkM987XPFwaGpHDgXKP6civTyU3mNktK1zpqAuQ8xn+QMY5IAJacmrPgPcar9oeOxTA2Ak3Boeir8R+1PQOUZ7WyTs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6061
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 9/1/2022 3:16 PM, Jarkko Sakkinen wrote:
> On Wed, Aug 31, 2022 at 11:09:02AM -0700, Reinette Chatre wrote:
>> On 8/30/2022 7:28 PM, Jarkko Sakkinen wrote:
>>> On Tue, Aug 30, 2022 at 03:55:47PM -0700, Reinette Chatre wrote:
>>>> On 8/29/2022 8:12 PM, Jarkko Sakkinen wrote:

>>>> There seems to be at least three patches merged into one here:
>>>> 1) Update SGX selftests to create enclaves with provided size dedicated
>>>>    to EDMM (this change causes a lot of noise and distracts from the test
>>>>    addition).
>>>> 2) The mrenclave_ecreate() fix (which is still incomplete).
>>>> 3) The actual test addition.
>>>
>>> I would agree on this on a kernel patch but not for kselftest patch. It
>>> does not really give useful value here. This adds a test and that is a
>>> good enough granularity in my opinion, unless some major architecture
>>> work is required as precursory. It is not the case here.
>>
>> I must say that for many good reasons this goes against one of the
>> fundamental rules of kernel patches: separate logical changes into
>> separate patches. This is your domain though so of course the work
>> within it follows your guidance and I will not pursue it further.
> 
> I don't consider kselftest patch exactly same as kernel patch

You are not alone.

> but I can split this. What would be good enough?

I identified three candidate patches in my original response that
is quoted above, but as I mentioned I understand the sentiment
and this is your domain so I will not insist on it.

Reinette