Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757536AbXFOUVx (ORCPT ); Fri, 15 Jun 2007 16:21:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755019AbXFOUVo (ORCPT ); Fri, 15 Jun 2007 16:21:44 -0400 Received: from sovereign.computergmbh.de ([85.214.69.204]:14488 "EHLO sovereign.computergmbh.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752331AbXFOUVn (ORCPT ); Fri, 15 Jun 2007 16:21:43 -0400 Date: Fri, 15 Jun 2007 22:21:42 +0200 (CEST) From: Jan Engelhardt To: Cyrill Gorcunov cc: "Kok, Auke" , Randy Dunlap , Chris Friesen , dave young , Willy Tarreau , LKML , Linus Torvalds Subject: Re: coding style In-Reply-To: <20070615194140.GE8151@cvg> Message-ID: References: <46721F18.8090303@intel.com> <20070615173206.GA8151@cvg> <4672D246.2040306@nortel.com> <20070615110326.b0762b7a.randy.dunlap@oracle.com> <20070615191804.GC8151@cvg> <4672E6B3.1080205@intel.com> <20070615194140.GE8151@cvg> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1340 Lines: 38 On Jun 15 2007 23:41, Cyrill Gorcunov wrote: > >Dunno who wrote that part :(. Jan, look: > > Now, some people will claim that having 8-character indentations makes > the code move too far to the right, and makes it hard to read on a > 80-character terminal screen. The answer to that is that if you need > more than 3 levels of indentation, you're screwed anyway, and should fix > your program. > >your opinion? Is it a bug too? Don't get me wrong I'm just trying to clarify >coding style. Linux maintainers will enforce \t "being"[1] 8, and will also enforce the 80-column limit[2]. (Assuming maintainer != developer) To [1]: There is actually no substance in how wide a tab is. The developer may set a tab width of 4, the maintainer may have his tab width set to 12, and the end user to 6. As far as I interpret CodingStyle, it reads: Use \ts for indent, spaces for align, and make sure your code fits into 80 columns when the tab width would be 8. (You can test that by adjusting your tab width temporarily) To [2]: There's always code slipping in that disobeys this ;-) Jan -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/