Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alistair Popple <apopple@nvidia.com>
To:     linux-mm@kvack.org, akpm@linux-foundation.org
Cc:     Peter Xu <peterx@redhat.com>, Nadav Amit <nadav.amit@gmail.com>,
        Alistair Popple <apopple@nvidia.com>,
        huang ying <huang.ying.caritas@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "Sierra Guiza, Alejandro (Alex)" <alex.sierra@amd.com>,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        John Hubbard <jhubbard@nvidia.com>,
        David Hildenbrand <david@redhat.com>,
        Ralph Campbell <rcampbell@nvidia.com>,
        Matthew Wilcox <willy@infradead.org>,
        Karol Herbst <kherbst@redhat.com>,
        Lyude Paul <lyude@redhat.com>, Ben Skeggs <bskeggs@redhat.com>,
        Logan Gunthorpe <logang@deltatee.com>, paulus@ozlabs.org,
        linuxppc-dev@lists.ozlabs.org, stable@vger.kernel.org
Subject: [PATCH v4 2/4] mm/migrate_device.c: Add missing flush_cache_page()
Date:   Fri,  2 Sep 2022 10:35:52 +1000
Message-Id: <5676f30436ab71d1a587ac73f835ed8bd2113ff5.1662078528.git-series.apopple@nvidia.com>
In-Reply-To: <9f801e9d8d830408f2ca27821f606e09aa856899.1662078528.git-series.apopple@nvidia.com>
References: <9f801e9d8d830408f2ca27821f606e09aa856899.1662078528.git-series.apopple@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?236XCLhMfKzBKE+M4Vk88cHmtZs7H9OBEE6zxBZwSRUm9hX5ZwXnoUvoDMf4?=
 =?us-ascii?Q?sQHeig5A0d3D1zRbs5oow52t56gLkkMG9Tn0P8vAU+SdY5vOrZSYuvDftCjQ?=
 =?us-ascii?Q?YWAzIzkF48a7k9n4wGemZsMeCT080tVQ9rO60nu75+BPuFtPzBTx3L1Wwgbh?=
 =?us-ascii?Q?DCAmwiGSnvjZFjctlrxqsf92kFooAJ5if3638gDP8C4yQyjueB4S9MWEaO7o?=
 =?us-ascii?Q?lmWTaRshCQ1Sh5MjOdO/0qCoR+wObVsIE7Fs4pB+rCeqLMRIQMjTgOHF2HQW?=
 =?us-ascii?Q?h9Ep+ztBcLvkytS7ABwVjSOY7PUtQhjf2Rme0xuLXfSGWiEUpJyFqx5Oanqi?=
 =?us-ascii?Q?Cs8BDIOnx2oHt5OR4CzAZv1Fz6gGp8ApCW77WA5j5Zv+lSjsYuOgkQYAf0sl?=
 =?us-ascii?Q?SbajbxYLefG9ZeSg2YZ3QKg3B8r0p8A8qpctdufr1ewqPpoZ74GYLnrWlIX3?=
 =?us-ascii?Q?ZOhmuBm7YS3Q8T887Cdcca3AixrL5/FyllVQ+545vx4vgldbDW3EAzOOa2aJ?=
 =?us-ascii?Q?gd/0JiTZKO8A7OTtdPpFB2VbsyBm2/ZYrgCSTAz87J1s/vI/TwfBJy3TxZJB?=
 =?us-ascii?Q?gLcIxQBZRGYNXG0IJ3yTG4iqNQPKVKJtWDs4KE9O7h+IsUK9Lto+sO5tuhvW?=
 =?us-ascii?Q?rp9HA6B2aw/WduPJGLtRtNBoR2iFPcgpUiT9qwqcum/cNmSJ05MOVCUjLwvx?=
 =?us-ascii?Q?L7ivI/nJF/ezyGs17uPJtUN6IsF+obT5wOtLxVzyNxIGyU9pCy3caNKr0AzF?=
 =?us-ascii?Q?gMDVn3k06GivZm5i4d/tAmgnqzEMuuMVFwWVc+kbuPqQOYKPZvxXMdL5gXF5?=
 =?us-ascii?Q?zTKP2VkBhwS/xYm3qGBWzu/jLYvQ2kCg6HydexVTqGlhXrUE5kKmJRE9npQq?=
 =?us-ascii?Q?0N/wKoEKpimKFSCfm0uXM14bJAydi0qYHjAfmb1w5RdhKZ6Y3voyscbbzbq7?=
 =?us-ascii?Q?3fylpiinMuDkVo8CJMcsnBXYTbzhTCSzKjZpcUbQydDztbsgLzJ1ktlLQTck?=
 =?us-ascii?Q?k2HUoXsK7KxFCG3vFaoMX9Ixbisq9zBEla0sZLjsxB/o5yRta6QeN8ZTXMB6?=
 =?us-ascii?Q?xB/SWgkwTTFQ4vqsnjareu8bqRG0d1RNYVd1g1qT9TCY+rZdulLrV6IkBMkP?=
 =?us-ascii?Q?uejXGNZr5WM3Dp56iIQIrJRhEmEcUfVBl6vz6MIlbi6CXIi417WVo0I8MBTK?=
 =?us-ascii?Q?lDT/uVzYIrkLWZ/gLrE9M5270HDwnJW4J5P9eZPnfV5jZOUbepaQkzHfJdW7?=
 =?us-ascii?Q?kQWuuJPucYxjgxo+N9ehI8sez6YojKuazHImnPHVj67zm0Hpmdk0KdN4nrwI?=
 =?us-ascii?Q?LKeUr7UfNZ6f2p4szDQKNUIvxZrHqdJ9GcZHI9fNx2+aqNqOxyIRGqdV9FJK?=
 =?us-ascii?Q?n4N4TSeDDYGsUsKRRhq+Psg5zsyj3kpv+w/hjH98ZrpweQPgbggkm0pimhzA?=
 =?us-ascii?Q?uoE7VsSyP9Ne3RWfz5tYUD6mOOxPsYPoNfSxn6hRuWGJJqn848URBjPagHzF?=
 =?us-ascii?Q?N4mBbOyQGR74djd88Q6weqNxQvvj+ylNPxFjCMffjdqtErMOe9s5wgWrdDh5?=
 =?us-ascii?Q?cQMVmmbpBhWGJ9Yue7w5gM8mONuoT+LRZqmru+/Z?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 490f612b-ec56-46fc-cd5d-08da8c7b2c6b
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 00:36:28.1881
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XPqO3ZNFmxVy8krYKt2oNJSeakaO/db5aSVpR7Qq6pW6b0mjEIjzZiDcUgcLZrdvkoaeveSLVsAIW3H72CXMwQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5086
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Currently we only call flush_cache_page() for the anon_exclusive case,
however in both cases we clear the pte so should flush the cache.

Signed-off-by: Alistair Popple <apopple@nvidia.com>
Fixes: 8c3328f1f36a ("mm/migrate: migrate_vma() unmap page from vma while collecting pages")
Cc: stable@vger.kernel.org

---

New for v4
---
 mm/migrate_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/migrate_device.c b/mm/migrate_device.c
index 6a5ef9f..4cc849c 100644
--- a/mm/migrate_device.c
+++ b/mm/migrate_device.c
@@ -193,9 +193,9 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp,
 			bool anon_exclusive;
 			pte_t swp_pte;
 
+			flush_cache_page(vma, addr, pte_pfn(*ptep));
 			anon_exclusive = PageAnon(page) && PageAnonExclusive(page);
 			if (anon_exclusive) {
-				flush_cache_page(vma, addr, pte_pfn(*ptep));
 				ptep_clear_flush(vma, addr, ptep);
 
 				if (page_try_share_anon_rmap(page)) {
-- 
git-series 0.9.1