Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH next v2 2/2] dt-bindings: i2c: add entry for
 hisilicon,hisi-i2c
To:     Yicong Yang <yangyicong@huawei.com>, <yangyicong@hisilicon.com>,
        <wsa@kernel.org>
CC:     <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <xuwei5@huawei.com>
References: <20220825092412.307052-1-chenweilong@huawei.com>
 <20220825092412.307052-2-chenweilong@huawei.com>
 <ffa076ea-2675-05ab-00bb-30b77ef13cba@huawei.com>
From:   chenweilong <chenweilong@huawei.com>
Message-ID: <c9f34071-38ae-868f-1f9a-1630d96af727@huawei.com>
Date:   Fri, 2 Sep 2022 09:00:20 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <ffa076ea-2675-05ab-00bb-30b77ef13cba@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

OK, I'll repost after correction.

tks.
On 2022/8/31 17:53, Yicong Yang wrote:
> [+cc xuwei for device tree expertise]
>
> On 2022/8/25 17:24, Weilong Chen wrote:
>> Add the new compatible for hisi common i2c.
>>
> s/hisi/HiSilicon
>
>> Signed-off-by: Weilong Chen <chenweilong@huawei.com>
>> ---
>>  .../bindings/i2c/hisilicon,hisi-i2c.yaml      | 50 +++++++++++++++++++
>>  1 file changed, 50 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/i2c/hisilicon,hisi-i2c.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/hisilicon,hisi-i2c.yaml b/Documentation/devicetree/bindings/i2c/hisilicon,hisi-i2c.yaml
>> new file mode 100644
>> index 000000000000..ea967abfe144
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/i2c/hisilicon,hisi-i2c.yaml
>> @@ -0,0 +1,50 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/i2c/hisilicon,hisi-i2c.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>> +
>> +title: Hisilicon common IIC controller Device Tree Bindings
>> +
> It's ok to have "HiSilicon common IIC controller"
>
>> +maintainers:
>> +  - yangyicong@huawei.com
>> +
>> +allOf:
>> +  - $ref: /schemas/i2c/i2c-controller.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    const: hisilicon,hisi-i2c
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  clk_rate:
>> +    maxItems: 1
>> +
>> +  clock-frequency:
>> +    default: 100000
>> +
> I think it misses some properties here?
>
> - i2c-sda-hold-time-ns
> - sda_fall_ns
> - scl_rise_ns
> ...
>
> Do we need to mention them here?
>
> Thanks.
>
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +  - clk_rate
>> +  - clock-frequency
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    i2c1: i2c@5038B0000{
>> +      compatible = "hisilicon,hisi-i2c";
>> +      #address-cells = <1>;
>> +      #size-cells = <0>;
>> +      reg = <0x5 0x038B0000 0 0x10000>;
>> +      interrupts = <0x0 120 0x4>;
>> +      clk_rate = <0x0 0xEE6B280>;
>> +      clock-frequency = <400000>;
>> +    };
>>
> .