Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Sep 2022 20:15:53 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Rik van Riel <riel@surriel.com>, Borislav Petkov <bp@alien8.de>,
        "Dave Hansen" <dave.hansen@intel.com>
CC:     <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
        <kernel-team@fb.com>
Subject: Re: [PATCH 0/3] Print CPU at segfault time
Message-ID: <YxF1afJ8oEr6KAA9@iweiny-mobl>
References: <20220811024903.178925-1-ira.weiny@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220811024903.178925-1-ira.weiny@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7qO6FWpLFcKq0ZkuRS2/XBcjRCohILgrMGQuVLhePelzoYOeJA7lUx5y1Xl8?=
 =?us-ascii?Q?Eb7PmoedSvRRRL45iwXvtw6URkYogMf2QhuE18Mcb2BwrkW3bcqV/bxetNHJ?=
 =?us-ascii?Q?gJKg10bzwued0NtdAp+USDGoehhCqoST1teIR4gh0TS6PfSwD/MQS1RenYP5?=
 =?us-ascii?Q?Q3cL6zw7qp4YElV7su/rmaMXmMQLbuAPzVrNBEtKFeev/fvzHE13fU/ozFr8?=
 =?us-ascii?Q?XbtV/TVat2ET4hOZfQCpqbtRerFosvPJ7xAFcaHS6SnDte66zN+iskyNJznf?=
 =?us-ascii?Q?FcvCujOVbHDe32CH2Pl92e+T/U0N/tnv+l+DljNXlveZ7krF5lSIz1HNQPDl?=
 =?us-ascii?Q?e1IAWDurMea89Q6tvRGk7MuYd6rRWCcY/tuskC5TtjAF7cnm2c7BTvNv8m1a?=
 =?us-ascii?Q?iaC3SwBe8BUVJtv6qoz0iaMVADve5AgRZt2t3eR3SGNCjrtCR4INMqyW2U9V?=
 =?us-ascii?Q?lvrrRc0HFraaNlUX8RLhwN2GbrjOGhGANtUXgLmZRzgkLuWG51UpBubu/DXX?=
 =?us-ascii?Q?vGIVh/lDesHnNG7WlCWKq49NoMVCd/pZu3BpvaP6RZ9BSCFsulyTUOilBrl8?=
 =?us-ascii?Q?jf5ez+JGvxPaLbcj9R52VofVMBBy+gJLM29J0PSOBSYxkeFOWs84DOoFHElp?=
 =?us-ascii?Q?UlI7l2ORlIKk61CS5DlAzzls5R91UHP8B8ERHK/xY194d/MkYZUdvpR6OS5U?=
 =?us-ascii?Q?16jAHiIg5mEKAE95bwdTx5QUHzK6nAI1w9NObghsL+eQKCn1mbGBPI8PPlTX?=
 =?us-ascii?Q?QXjkQV/OH0rTkE9o67zFUQ6fPggAiJdIDn5zs4M8tCnlsDcC/DGutFLBz7Qf?=
 =?us-ascii?Q?/cS6tjNZEdtDXX+dJpWMT8WMidq3xTJWxN9VIhb6OK2VSe7XJtFdv4fqAXxy?=
 =?us-ascii?Q?P+e5C4rz+tPGLv8WCr1eWnnAkY2w9dNly/Mzq3XT2oQhhgTc6BvXtKOMlD4T?=
 =?us-ascii?Q?DR8lPX2VwzPBWn62npPma1Q5z/cGjaOoP3ft9Z5Ph3V6ny2lujBBmucVIr41?=
 =?us-ascii?Q?AgAs7U5+KmJBsa7WQQu0TmodLCVDJNt5Twcwpva749LGjYBKO4TToFxMoKm5?=
 =?us-ascii?Q?loyvKRAzrANejtRK6xRg6Mum38w0vSZPwZ+tlupTSBlUrN4P1fwVpDrejGCS?=
 =?us-ascii?Q?TYHEweoR+k1H0bIFeV1iC/bygnVEjtUsirXcjT/KSMa2Wc4GqcrLobXddTrk?=
 =?us-ascii?Q?RyJwwvI3uAevIx7HoFpKZvJ8KL2v0mNAh6eesFmmJ7pXVHk2eTasO438X64W?=
 =?us-ascii?Q?W27F70/QIYSV4NzNT6H5thPSthkwecnYK36SraW8qqJHvcvnrJIYdjdDvu6i?=
 =?us-ascii?Q?kUShkXyPYIWJuhLBIbA9rr6N40u0sAL8F7M2Kq9cRxyvVbiRSjaWfEx+c1jR?=
 =?us-ascii?Q?hvGWrxWDYvmU5F3q7ofRj+V2iHtKvC1752WwDJJCrXCNfERU/9DDuuHb/9tn?=
 =?us-ascii?Q?n++AyRFljAT1F/IIBDP/ztqjRWlIo2e8+9BjHHBLuJXUxMevTt3CzDezAGWD?=
 =?us-ascii?Q?4RjJ3Fae6ACP5WgRG2uR95Dg9u0Je9JBehgw754k5tZ1kR2KkqvnYlV/yEWd?=
 =?us-ascii?Q?KAiJfViT4nPeab5SreGERQgV197fWg60ErQerh59?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6badefe3-055b-4d9d-6eec-08da8c917437
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 03:15:57.5689
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qqO9IQQ2m0egHQDaInRVC+f1YO54RIJZTYop4GEjOR3o4aZF+mynAxuxbNbIwqWp+TyTaFuTAqgdTRu4ZZGbow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3933
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 10, 2022 at 07:49:00PM -0700, Ira wrote:
> From: Ira Weiny <ira.weiny@intel.com>

Any feedback on this series?  Or has Rik's patches been accepted instead?

Ira

> 
> Changes from RFC:
> 	Drop patch 1 as I misunderstood the code and it is not needed for this
> 		use case
> 	Combine patch 2 and 5 into a patch 3 which stores the CPU only for page
> 		faults
> 
> Rik reported that the knowledge of which CPU's are seeing faults can help in
> determining which CPUs are failing in a large data center.[1]
> 
> Storing the CPU at exception entry time allows this print to report the CPU
> which actually took the exception.  This still may not be the CPU which is
> failing but it should be closer.
> 
> Dave and Boris recognized that the auxiliary pt_regs work I did for the PKS
> series could help to store this value and avoid passing the CPU throughout the
> fault handler call stack.
> 
> The patches I sent for RFC had a lot more overhead than is needed to report the
> CPU in a page fault.[2]  After the discussions the generic save/restore of the
> auxiliary pt_regs is overkill for the current use case.  Skip that overhead and
> only store the CPU in the page fault path.
> 
> [1] https://lore.kernel.org/all/20220805101644.2e674553@imladris.surriel.com/
> [2] https://lore.kernel.org/lkml/20220805173009.3128098-1-ira.weiny@intel.com/
> 
> Ira Weiny (2):
>   x86/entry: Add auxiliary pt_regs space
>   x86/mm: Store CPU info on exception entry
> 
> Rik van Riel (1):
>   x86,mm: print likely CPU at segfault time
> 
>  arch/x86/Kconfig                 |  4 ++++
>  arch/x86/entry/calling.h         | 19 +++++++++++++++++++
>  arch/x86/entry/entry_64.S        | 22 ++++++++++++++++++++++
>  arch/x86/entry/entry_64_compat.S |  6 ++++++
>  arch/x86/include/asm/ptrace.h    | 19 +++++++++++++++++++
>  arch/x86/kernel/asm-offsets_64.c | 15 +++++++++++++++
>  arch/x86/kernel/head_64.S        |  6 ++++++
>  arch/x86/mm/fault.c              | 18 ++++++++++++++++++
>  8 files changed, 109 insertions(+)
> 
> 
> base-commit: d4252071b97d2027d246f6a82cbee4d52f618b47
> -- 
> 2.35.3
>