Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp1470791rwe; Thu, 1 Sep 2022 20:31:47 -0700 (PDT) X-Google-Smtp-Source: AA6agR7Ij59POUD9UQ+ajUAqJIw4KZzPQbUddexn5hmkojXmUM8kc+EyNgcsJ7yFq+ZfQ92zd4m7 X-Received: by 2002:a17:902:e552:b0:16d:d3c0:85fb with SMTP id n18-20020a170902e55200b0016dd3c085fbmr32662813plf.38.1662089507702; Thu, 01 Sep 2022 20:31:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662089507; cv=none; d=google.com; s=arc-20160816; b=W3oUnesjhWlUdszpW4I5lCGc3k42Ri0znwMWcZi1WwWTM9lWWclzwCGDlUaVIrbp4Z wAGSn2bN0kI30f3vA3XOM34MPDvc7xxiqLfM6jSnhXhEeWbpjSvasAacSecqDCtgCugm cxRDr3K6dANHM9FYryEIR8BedaQ9t7q90Ia30lkTnlklWgFLuLaqFkhbLmHOzjoNMNz3 g+oiEmFMPLXH3HUm5KlhHqqc5O2Luz6OwpnxA/nbtDDCWhe/iQeb3j/EmAdHVa34SLiA 62jnc6j+rS9ICpUygNQJTJO7eWKtGwxcbvE7eEQ84H4H3eA/+B4JrkZgE+88nDmt+E+W SrnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=llabfkYgD0lfrS8s+xvXW9T5xckUR4BABPfISa4/KzM=; b=Qx9cpDLYxlllnykshHSZsjsLUtnmy5FQpnA1cRbFZMd+grHwN1sLVkUpn8iOTBuBBb i29l7O0tUSHg4K2VNrGW43oa9updd2xtaSUMiJt6yVZVCjItAV4pcAizYgPLJFs/AKqj iLG7NoVsVZDIiF+Mfe9JiBt+prK23RIReEOeC8Wt6pDohH04qDflDO4LtWyLgs0iYD53 GInEj0b4296MRXAySS1iBo9E3S2e/dhTwdZ6aR2QPGIksdBrkokr+Dami9oSAmIcHD0h WGdfhidAkChj1FlsyaULxaqFCMhR1U+hMYdDekAjX9GyBJNKSXtPpZk0itzvnM5s7fnm uDnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Qvnk9aGn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ob2-20020a17090b390200b001fb05ee5d16si7117061pjb.99.2022.09.01.20.31.35; Thu, 01 Sep 2022 20:31:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Qvnk9aGn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231394AbiIBD1v (ORCPT + 99 others); Thu, 1 Sep 2022 23:27:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235175AbiIBD1g (ORCPT ); Thu, 1 Sep 2022 23:27:36 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 874E2A0622; Thu, 1 Sep 2022 20:27:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E5636B829B7; Fri, 2 Sep 2022 03:27:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1416CC433C1; Fri, 2 Sep 2022 03:27:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662089252; bh=qSAS0T0MuBmaWeT8uG5lNnET4yd1Q33sgQdS6DbDcJo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qvnk9aGn58J554jGx93rrg65XFeihTphkgWxYKbWYj+w8dYmNgGUwSWflA4AdmhUg AbVqcYUucbQnz/XNnCf9toUpbL1FvSoz5iThdvfUBVbT9xcgJ7y930xmQ81edGrzb0 TP/dJuUwCZxQ3SgFlCQSOFNt8bP5c4mjOkrAp9p5u5iZsq3hcIeIjziNHJ1a8PY3SX g64TdCOTQ43CVy3z1fs/wpko3HvbEZC/wUG8rZ+GiiC958/B7ga4p01wl+tPNWovoR EaDg0ltOoemE0r+kTJdaEGn4BFVQ9Bd6d766ultH2RxUxLLnALCVt273hjYLNJ78eQ gRXrdlGXfJXmA== Date: Fri, 2 Sep 2022 06:27:27 +0300 From: Jarkko Sakkinen To: Alexei Starovoitov Cc: Roberto Sassu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , David Howells , Steven Rostedt , Ingo Molnar , Paul Moore , James Morris , "Serge E . Hallyn" , Shuah Khan , bpf , keyrings@vger.kernel.org, LSM List , "open list:KERNEL SELFTEST FRAMEWORK" , LKML , Daniel =?iso-8859-1?Q?M=FCller?= , Kumar Kartikeya Dwivedi , Roberto Sassu Subject: Re: [PATCH v14 05/12] KEYS: Move KEY_LOOKUP_ to include/linux/key.h and set KEY_LOOKUP_FLAGS_ALL Message-ID: References: <20220830161716.754078-1-roberto.sassu@huaweicloud.com> <20220830161716.754078-6-roberto.sassu@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 31, 2022 at 08:33:38AM -0700, Alexei Starovoitov wrote: > On Wed, Aug 31, 2022 at 2:24 AM Roberto Sassu > wrote: > > > > > > > > > > +#define KEY_LOOKUP_CREATE 0x01 > > > > > +#define KEY_LOOKUP_PARTIAL 0x02 > > > > > +#define KEY_LOOKUP_FLAGS_ALL (KEY_LOOKUP_CREATE | > > > > > KEY_LOOKUP_PARTIAL) > > > > > > > > IMHO this could be just KEY_LOOKUP_ALL. > > Since this is supposed to be kernel internal flags > please make them enum, so that bpf progs can auto-adjust > (with the help of CORE) to changes in this enum. > With #define there is no way for bpf prog to know > when #define changed in the future kernels. Isn't enum also Rust compatibility requirement, or do I remember incorrectly? Anyway, good suggestion. BR, Jarkko