Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <87pmge5q70.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
        tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: rsnd: Add check for rsnd_mod_power_on
In-Reply-To: <20220902013030.3691266-1-jiasheng@iscas.ac.cn>
References: <20220902013030.3691266-1-jiasheng@iscas.ac.cn>
User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0
Content-Type: text/plain; charset=US-ASCII
Date:   Fri, 2 Sep 2022 04:57:08 +0000
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PokR/MGpdA6cUm2XxAtxTTiUFOW5B9w9/pwKt4bmOlQ9KV1oFUOs30eMrZEL?=
 =?us-ascii?Q?JsrmERmakDYtxC6g9WXApKgYUokPqiIBdRLYiph2BA9dg/pGzF4vM9hSW6et?=
 =?us-ascii?Q?s2vSZumO/XLKMbixyWRTJW9Ny8wSAVvBvXyFBKKtCMCxPIs2kauJ4+L77rAR?=
 =?us-ascii?Q?CwZjo/BTbfRBF0GYhrkLcNUnIs3T+FaxNXJY0A3SHGcbkmau3tpKjfUgWKzK?=
 =?us-ascii?Q?R2LH1XIZXZPGsW57yD+3ep2xIEaKnejELTDFW98LyC4sNAEEAGlsq9rbiS3F?=
 =?us-ascii?Q?s+tckWskxxNAWVsRhVf5akZX8IU70rJUOCHODvulVUogdW8fmEEouutDXdfS?=
 =?us-ascii?Q?th55Tf1uwjBW9FTIgq87YYC9Z/AKvra2YH5T+2RKa5529yCpNbbwZQ8AGXzD?=
 =?us-ascii?Q?g7QPeFbVmStV9qLChdrVnPPwA7CcB2afFCky7gM9TbWbPBgO8V082aor9pTJ?=
 =?us-ascii?Q?Vz9FMlIFgwYzSRpy1PQsJxjq9blTcqdfBqWbF9neY6dqzGg1zliAHuKc+05r?=
 =?us-ascii?Q?5JnCyKYAREMUEYNxHW/ERaa0Wvf425SV2QSAzmWBm4huXrvyir0D+E7fdkQ1?=
 =?us-ascii?Q?tp38tp+40AsERLSGSnXXrQE7LgiQUwPU08ibW1XvuF8eyuO3D36QbIr3QQBP?=
 =?us-ascii?Q?QhPrMA4+CZV2p9tVFI+MMQpesP0y7ZCfYugZxZmDgnrnZADJ6HYB2S189K4I?=
 =?us-ascii?Q?BM3KctUukrKEkezGd1yV+4A3KpaEnpGrvyBv6JENxXaoxRoIcPzo2AApTxZG?=
 =?us-ascii?Q?nvjofiLQvPv7e06xlc2hMuP4AJ6VqqmUKtDbwYusbQk0TQg5MELsZwBVUB0z?=
 =?us-ascii?Q?k5UJWNg8ACioV4lh4oHctx0VsKP5swfOpxJFmY5zNDPmv3PkKKD7wcw8Yq9h?=
 =?us-ascii?Q?sSV9kybCyKBJlwRmSd6Fv/ZAXzwYVMWap06qmOCm/PJKKgJwv/M0pHSXbDP6?=
 =?us-ascii?Q?15c4ugheG6puI20tGpUTUd54FZxcNAURaeLEF7cHag+ln7TiVrFMs3ueDCfe?=
 =?us-ascii?Q?+nf7HnWqgyA0fjtErR8Z2F0/DDCM1JL2s0CJjsmvGNhi6je59LcCfjKvSds+?=
 =?us-ascii?Q?mFQH6W2XakbwWRPzsGM/ZknrFQc7rMNf+1gDtrBtBUhVIDX7QBB8UdP2FloV?=
 =?us-ascii?Q?CesP1b7pFr/ccQ6oaz8+22StRTI/3SwskYPDMz890gTLu4u2EFrjL22rGeKf?=
 =?us-ascii?Q?csP6uAS9LlJxHK2pLZWg0Jgg16TbsCYdE1LHbzo783GWYmv9iMxat0LN8YDD?=
 =?us-ascii?Q?GnZC6efa2+pgcVLu9sO7EwN/zt4yEXnq4E3Qf2ayNmMH9hOhN/mWvttFwWmj?=
 =?us-ascii?Q?p4vKz9/i+hvmnjMrPLH7AcUhNf84geN+Is49x3H9XV6865ea1qzj4KnwV0Gf?=
 =?us-ascii?Q?jBZp/kDLLHZ+SrxnvjJqEjbLCv7Y19w+f1Zvo0HVjwazEAmcqWX9oa9kpBRY?=
 =?us-ascii?Q?Nh9DuXUPgZCd/m2k1A/c+Zt5ROCYFYVh9mpCg51XxoYYe4mVOOFSwStKjObP?=
 =?us-ascii?Q?g3IBl2jItyDYOCAdMwp+YpOcK8GAsC+toJ+xEAalsjyYLORBN+q5r+kuS4OI?=
 =?us-ascii?Q?S1pLUYJQGgjIHzsGTIp4WiD/QSaE1bU07Z9euckFbuIcj/2wmpbTZn9UyL1O?=
 =?us-ascii?Q?j0U5cTmWS/JUt+Yn/R1wNgc=3D?=
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07546e86-05a9-4e2e-4a43-08da8c9f96aa
X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 04:57:08.4745
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qofK4q9sExtVU361UCQ2L1tV3ew8TkwGhWGIbg96k8L1ZPTGJwV+vxpaTNp3nKyzG6XXauLghtZ9iJKGuOcYY2RTj2ZOt2NPMhJxkKHWeldgMJpvLL324p8c7oqdag+R
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB8113
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi

> As rsnd_mod_power_on() can return negative numbers,
> it should be better to check the return value and
> deal with the exception.
> 
> Fixes: e7d850dd10f4 ("ASoC: rsnd: use mod base common method on SSI-parent")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thank you for your help !!

Best regards
---
Kuninori Morimoto