Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220828205723.20834-1-joelselvaraj.oss@gmail.com>
 <20220828205723.20834-2-joelselvaraj.oss@gmail.com> <d9b5e312-4999-4410-03be-299e95bbe8b2@linaro.org>
In-Reply-To: <d9b5e312-4999-4410-03be-299e95bbe8b2@linaro.org>
From:   Joel Selvaraj <joelselvaraj.oss@gmail.com>
Date:   Fri, 2 Sep 2022 00:20:42 -0500
Message-ID: <CAF+P-ZoAooPFEK8dueEnQg5d5+K4QRmj-W0WsjyUV-btgBfYnw@mail.gmail.com>
Subject: Re: [PATCH v4 1/4] dt-bindings: arm: qcom: update beryllium
 compatible property
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Marijn Suijten <marijn.suijten@somainline.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Krzysztof Kozlowski,

> The board compatibles are not that important for ABI yet this creates
> precedence, so I am against it. Simple renaming should not be a reason
> to change compatibles.

So what should I do now?
1. Retain "xiaomi,beryllium" for tianma and "xiaomi,beryllium-ebbg" for ebbg?
2. If adding new compatible is not an issue, can I do
"xiaomi,beryllium-tianma", "xiaomi,beryllium", "qcom,sdm845" - for tianma
"xiaomi,beryllium-ebbg", "xiaomi,beryllium", "qcom,sdm845" - for ebbg

Kindly let me know if any other possible solution is present.

Thank you,
Joel Selvaraj