Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Jankowski, Konrad0" <konrad0.jankowski@intel.com>
To:     ivecera <ivecera@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     Paolo Abeni <pabeni@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@lists.osuosl.org>,
        open list <linux-kernel@vger.kernel.org>,
        "Piotrowski, Patryk" <patryk.piotrowski@intel.com>,
        Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Vitaly Grinberg <vgrinber@redhat.com>,
        "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net v2] iavf: Detach device during reset
 task
Thread-Topic: [Intel-wired-lan] [PATCH net v2] iavf: Detach device during
 reset task
Thread-Index: AQHYvEjp4Yu/q51mJ0mt3lC1j4/Tc63Lq1nQ
Date:   Fri, 2 Sep 2022 06:05:28 +0000
Message-ID: <DM8PR11MB562163A58A2B970434338D2EAB7A9@DM8PR11MB5621.namprd11.prod.outlook.com>
References: <20220830081627.1205872-1-ivecera@redhat.com>
In-Reply-To: <20220830081627.1205872-1-ivecera@redhat.com>
Accept-Language: pl-PL, en-US
Content-Language: en-US
dlp-version: 11.6.500.17
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?259cyaadjsm9ES7g4ox9+AfF7GsM+YqeY1Wl/MkQHYnubC8xIQTof9Q8jopE?=
 =?us-ascii?Q?QpxUsgiGVtSsu141DErEBrEYFFcKabgz1istVvtXz19slG6qUkqxMHpWB/Zp?=
 =?us-ascii?Q?zrWV8VAQdwYQCcVjRYKGR0m2plO386AqLLZYQV4iWpEf/b27GwoilPbER3RO?=
 =?us-ascii?Q?ztSLS4eFfhM9fycqmY8kvsh2zgbDvrWL7ATMko0sS3C2BDIHmw8GqBc5pkdD?=
 =?us-ascii?Q?q9PXwW2GPXR4uciczGNNxon+4WsQvpdCAmBl+J3IaRFtvzp91jlU4yu6MuAn?=
 =?us-ascii?Q?OPp/lvd167bSMXwOMHOJTuX3spOtm1z+MK/Fkn3YiAi11VO19+8WSFTTZ9Ir?=
 =?us-ascii?Q?SjjYnE2ddD1o9FD0TWcA7fRSxlQE5zS4Jgc+Tnv91I5fBzHuQhWhyIbss7SM?=
 =?us-ascii?Q?B9N04cCTmoYzqUFYXzoqDLDv9vgaB3sWTS21ZnRERyRGM0da6CU9Cd0yCWEy?=
 =?us-ascii?Q?+tS+wxme6O2MKS6TMBhweYbt3k2aYry7GMZ6fHvZSQxKtUtbwOxE0IOeh0Sv?=
 =?us-ascii?Q?HMkHWZ87/UqahrqyWvzcUJarENKdLGdKFwNYjKLrRl/mj5AsVl4KsVTlu5eG?=
 =?us-ascii?Q?ibacifZ3Vr8ja08AlfRgQCZKXlNUSWtGp4akZ5z+6OYw3L+vv/7Ar98riZKi?=
 =?us-ascii?Q?sInK1WBbg89seIIjqf9+nLADau3NcK9khn75YYGU4clSrpsOEqX0Zwbh38Cy?=
 =?us-ascii?Q?f2uSjdVdBOXEAIubPkmWtJo6nQr/c5Ip2hU49rsBFUXXw8iOZnnLJImhYrs9?=
 =?us-ascii?Q?8qnHhh8MdMVzkmnkcZMeAxOgr4toImZRB6DMfDlU8vXbrpSJ87B51QqWB8w3?=
 =?us-ascii?Q?P6ZRv5NV6ivbM+GcOHihBmJ44MjPUJW4lqC5teCHB+5ecUlX49h3Zxlwhk0V?=
 =?us-ascii?Q?bnqPNSm1z5Ej80kfTbhFaRTLpNAyw+n3UN1tYodrcnO/Frs3AdxnhMojnfdA?=
 =?us-ascii?Q?yOKXLidGnw2oEJENHkSnA1T0iEL0GwOWjm/9YsR0wQNae7i0EFjISv4iCFWc?=
 =?us-ascii?Q?JawBr1n17aUlrCNIm9KpAgNJBpNUxMT96zx4DREhKuRkJJ7Qmeba8kRcKeYS?=
 =?us-ascii?Q?UVysaRYqbxoxcdqHFMVpWOiIB0O3lvSZPBzIyOwK+TN77Y4oCbf69xt0FsxS?=
 =?us-ascii?Q?l0mXzTGHxue8U1+ZLD/ZUrGANrz89GhWBFtTx4+kS6Tx7xcuF6scSvlRXXhJ?=
 =?us-ascii?Q?IeapKVrKAHdwOeY6U2I8Y/JmkgHG15qLnazvtXrp7qnofLRBKQ2Cf3gh0rAO?=
 =?us-ascii?Q?4YbwIA9M4o9k0EqQf5uJKLzSwjDAAPX/ZBbXYekpOknCRC2gvP1sGD6DQmrS?=
 =?us-ascii?Q?RLYIRImiLEQZ+OeQF/UskcJ0Nro5wqpLV7b60qQy4zharcZlRNwlmX7+RYjQ?=
 =?us-ascii?Q?b1qwbsHCDUgfmCGG2rs5kLjUoHNxu6bkQPyKa/xULtBWlq4IPH2pX2cPQqU0?=
 =?us-ascii?Q?+hLMG+DW9sT0Ap5W4603ULCiYKKs1obdUnmUAvSxquOI6QX5KW7OThESGWTH?=
 =?us-ascii?Q?pe4iUnXZSLu3sJmKZsyBIfVBVDSL1awtZlj8zLy8ReMOglkEBmDranO8f2bA?=
 =?us-ascii?Q?+lb83hAO4MPMXsLCq+w2ue8GcTGza8dPRiXO75sYBjLiUnKIi5umbv/ghlNR?=
 =?us-ascii?Q?xg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5621.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99792f8b-bdd9-465e-c634-08da8ca9230e
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2022 06:05:29.1254
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BMIwJ8De5yBc9jdK02rJb/n3K1Ry+Ixsph00sfMOM9zGXPLJOMaQJ3Q5W2gkOUyG4BNh+ncUhEHIYD0LlvwbWEeK92zbE+310pZivVVOlVI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR11MB4423
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Ivan Vecera
> Sent: Tuesday, August 30, 2022 10:16 AM
> To: netdev@vger.kernel.org
> Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet
> <edumazet@google.com>; moderated list:INTEL ETHERNET DRIVERS <intel-
> wired-lan@lists.osuosl.org>; open list <linux-kernel@vger.kernel.org>;
> Piotrowski, Patryk <patryk.piotrowski@intel.com>; Jeff Kirsher
> <jeffrey.t.kirsher@intel.com>; Jakub Kicinski <kuba@kernel.org>; Vitaly
> Grinberg <vgrinber@redhat.com>; David S. Miller <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH net v2] iavf: Detach device during rese=
t
> task
>=20
> iavf_reset_task() takes crit_lock at the beginning and holds it during wh=
ole
> call. The function subsequently calls
> iavf_init_interrupt_scheme() that grabs RTNL. Problem occurs when
> userspace initiates during the reset task any ndo callback that runs unde=
r
> RTNL like iavf_open() because some of that functions tries to take crit_l=
ock.
> This leads to classic A-B B-A deadlock scenario.
>=20
> To resolve this situation the device should be detached in
> iavf_reset_task() prior taking crit_lock to avoid subsequent ndos running
> under RTNL and reattach the device at the end.
>=20
> Fixes: 62fe2a865e6d ("i40evf: add missing rtnl_lock() around
> i40evf_set_interrupt_capability")
> Cc: Jacob Keller <jacob.e.keller@intel.com>
> Cc: Patryk Piotrowski <patryk.piotrowski@intel.com>
> Cc: SlawomirX Laba <slawomirx.laba@intel.com>
> Tested-by: Vitaly Grinberg <vgrinber@redhat.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
>  drivers/net/ethernet/intel/iavf/iavf_main.c | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index f39440ad5c50..10aa99dfdcdb 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c

Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>