Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 02 Sep 2022 08:58:39 +0200
Message-ID: <87pmgew9cw.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Pattara Teerapong <pteerapong@chromium.org>
Cc:     alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: aloop: Fix random zeros in capture data when using jiffies timer
In-Reply-To: <20220901144036.4049060-1-pteerapong@chromium.org>
References: <20220901144036.4049060-1-pteerapong@chromium.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 01 Sep 2022 16:40:36 +0200,
Pattara Teerapong wrote:
> 
> In loopback_jiffies_timer_pos_update(), we are getting jiffies twice.
> First time for playback, second time for capture. Jiffies can be updated
> between these two calls and if the capture jiffies is larger, extra zeros
> will be filled in the capture buffer.
> 
> Change to get jiffies once and use it for both playback and capture.
> 
> Signed-off-by: Pattara Teerapong <pteerapong@chromium.org>

Thanks, applied.


Takashi