Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e8a06f76-9414-6391-0582-667cf817dbcc@intel.com>
Date:   Fri, 2 Sep 2022 09:46:25 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.0
Subject: Re: [PATCH v3 1/2] lib/string_helpers: Introduce
 tokenize_user_input()
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
CC:     ALSA Development Mailing List <alsa-devel@alsa-project.org>,
        Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
        Jaroslav Kysela <perex@perex.cz>,
        <amadeuszx.slawinski@linux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= <peter.ujfalusi@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Andy Shevchenko <andy@kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        Matthew Wilcox <willy@infradead.org>
References: <20220901175022.334824-1-cezary.rojewski@intel.com>
 <20220901175022.334824-2-cezary.rojewski@intel.com>
 <CAHp75VfO7_ASHGdpkcb1dwvhyHPT31eYuAkCm2q7B+2WmtZC4g@mail.gmail.com>
Content-Language: en-US
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <CAHp75VfO7_ASHGdpkcb1dwvhyHPT31eYuAkCm2q7B+2WmtZC4g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZU9rdEJJTGllQjM0NzFLWnFXcEhZeFQwUTM2ZStja0F0WUJWWFVNYzdYMFdK?=
 =?utf-8?B?N0VXNnNpTlo4QmhOeUZyQXZyNnZVdmxXSUVhd0dvWDBBMlIweFNhSVFxWWFK?=
 =?utf-8?B?dHBBUVAxMVNPQW01UWFlT2IwS2QxSTBsWWFQMzlWYnRsVzA0dk5ZUkxBQmJG?=
 =?utf-8?B?ZGM5RGY2QkRSV3kzZko3eHlPMUNDZ0RabUVuVkM4RDV2NVllUExGajl1WDZq?=
 =?utf-8?B?bHZvZnRuYysvdVJBVXFCMStSanFCdDBtdzB6R1JqTmZ3VG9wZnVWNjZMR3NU?=
 =?utf-8?B?ZGgxaXUyL3I4VGZXRVJlamk1UmdqWWFRUVJFRXBadUIxNWdnczhqZnJGYlB1?=
 =?utf-8?B?SXFINkVoRzd6endKM00xNXBSL0FlbWN1c2hHTk5YTDRTblFEdzZ3WC9seVV5?=
 =?utf-8?B?bUIwa1pTODNkZTJjWWFFZEgyQmV2RmlQOCsyOCs2UGdrNDlURmRDNHdkQ21B?=
 =?utf-8?B?QU1WR0dvTUc1WitkZTNTU0RZZllsOEUvNzlmUjMxU2NZZ29CWGtFYUFJYVlG?=
 =?utf-8?B?OXhwYnBCOXpZTnJXdGtBVWc4MWJJWTBmV1pXeGtsUkI2T2NKcXQ2bnphaWxn?=
 =?utf-8?B?c2RqYTRuQ0cxNzNZQUhsVWd5YVptL1ZjMTUvOElsTHNMVy8yN3grTytjb1ho?=
 =?utf-8?B?Uy91L0lFcUhDNHVueXFsWFhPQXp0ZmhEYWNGMGZadVpyNzBoVVlqQlZOUEYv?=
 =?utf-8?B?SWpDS2E5Y3dtaGw1eFZlQ0k2aEE2WEtmWG9xY3l4dXJQNFpjLzREMUh5ZHNz?=
 =?utf-8?B?MXluZFVpOGVMOEVKYnY0eHVGQTR5MFJIbVJRQXZ4M0FvWDhlanhYRUxoS0RC?=
 =?utf-8?B?SGxWbDlmQ2o2dTl1WnBoaExod2lSeUk5WVZLZmk1eFhiNkxCaHdNUDlKVnRp?=
 =?utf-8?B?blgvNm1jcER6U2FsSW90Zk9XaUtFaml1ekVJaDFZbnJJUDJkTnZWVDY4dlQ4?=
 =?utf-8?B?Zkc3ZzVNU3BSV1FjSG45REZsREF0SzArVkRXODBnVEVYeUZmZlVZaTBQOWJz?=
 =?utf-8?B?RVR4U3hhLzhVK1ZtSHArbUdNMmdNVTlMaVFCUm9VcUg2UE9oak9WQUlIckxS?=
 =?utf-8?B?aWtHUTNKbG9SVkVqSGNGUkJRZSttTU5HbjdjVnkyQWhxSkc0S096NUM4VjZ6?=
 =?utf-8?B?MGRGNkJBeDZJeldRYURNVG56T056RE9lcjU1YndoajVRSk1iZTYwT2ltZm52?=
 =?utf-8?B?K09DdWZjVkd2S0lQU2xZcnloUTRmSUFTZzJZM1JuVFBhcUJodDRJYmpaU1hz?=
 =?utf-8?B?QzZiajhENFN6ZVJlOXpzaHZ0a0t0RHZYK1ZSNWhWQm1DTm5Hck9kbDVualEy?=
 =?utf-8?B?UU1ZRTRZd2x1Ykx5WUZPclhXdzlnY0UyNlhzbXVXeEc2cGxLSHUralRnY0c0?=
 =?utf-8?B?QnlwMnViaUl4VDRqRlN5ajl2SGQ2MEpNTm9MYW5aZWZic1E4WVBDZFh2cG9K?=
 =?utf-8?B?NS9tZUo4VzNSdDdNTmZqc1NSbkdBd3FoWE5OcllsRWk4Z2pYMnVKVnNBRlhB?=
 =?utf-8?B?TThzY0xWVEszcUZnRFBUTkh2K3pCQVFIdUVyd3BLbVlaNEVsQTFTSldoS3gz?=
 =?utf-8?B?eHZocTIxdUhBeGVEUHpCeU5HTmZ0bGVzVE5zZ0JVRDlLNC81RzBydmlWejVM?=
 =?utf-8?B?dUhRT1dBczMrZS9HNHplYjJhSHltRGNxRDhPWDQ1NnlMNVZac0lRQWkrKzMv?=
 =?utf-8?B?d3RyTUl4cnB0YlZPdUNoUlVaNE9zQWVGUFRoT1BNdk9kTHpocnplR1BmRmhE?=
 =?utf-8?B?UVBPZXlqMnB3bWZodzlIWUt5djFPVHU2ZmNZakhTNDh6b0NCNzQ4TStFcVhh?=
 =?utf-8?B?SGhZVkJ6elFucUlRRVYwaHp1eXcwMytBL2dOTHY1WDVLSlQyTWpFUGJLNngr?=
 =?utf-8?B?VUtUSnZxUmVTQlhOdEFaL3UwZzJzdDYxRFdLU0J3OEM3SVRLZ05pV0tkK0xy?=
 =?utf-8?B?NnluVlZSN25QNnVQKzBXdmNqQ0dZN24weFZNR3owQUZ1cVdDQ1phc1hTeGpj?=
 =?utf-8?B?TklYWHB1c2U3SUpmK1ZSeW9XK1htSjlNbjVnY0J5ejZIR3Z4c2ltWCtHQVVM?=
 =?utf-8?B?czdYb1FUcjhVa1g4MXNkZDYyeXFxUXZYcnNQYW9NTEtFbko0dkVkWWZQMGJu?=
 =?utf-8?B?SHo3RXFNTEsxcHpUb0dFclRKcFdXazhjeE9YM1FMWmUwUlRyL3BFWUZPSzV4?=
 =?utf-8?B?dkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: accdfada-df98-48db-792c-08da8cb7429f
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 07:46:35.3352
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MV9LSzCb2zk/99kJEQszRqFlAFPSPeDb3vB5aTvb8kEaZoTUz8yRRf9xXxEuOdccb4Twh8WGGw2LhLVKEUklQiQxOqsVjH5UozxNK6CHTM0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4315
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-09-01 9:34 PM, Andy Shevchenko wrote:
> On Thu, Sep 1, 2022 at 8:40 PM Cezary Rojewski
> <cezary.rojewski@intel.com> wrote:

...

>> +int tokenize_user_input(const char __user *from, size_t count, int **tkns);
> 
> Not sure how I can deduct from the name what function is actually
> doing. Suggested new name: int_array_parse_user().
> 
> int int_array_parse_user(const char __user *from, size_t count, int **array);
> 
> (Note that we have _user suffix for many APIs in the kernel that does
> interact with user space memory)


That's why I've added '_user_' in the middle! Anyway, I guess the 
expectation is that it's a suffix - precisely at the end of the name.

Could we reorder it a bit: "parse_int_array_user"?

>> + * @tkns:      Returned pointer to sequence of integers
> 
> array

Ack.

> If you are okay with this, you may add my
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>