Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Sep 2022 17:23:01 +0900
From:   Jiho Chu <jiho.chu@samsung.com>
To:     Mark Brown <broonie@kernel.org>
Cc:     gregkh@linuxfoundation.org, arnd@arndb.de,
        linux-kernel@vger.kernel.org, yelini.jeong@samsung.com,
        myungjoo.ham@samsung.com
Subject: Re: [PATCH 1/9] trinity: Add base driver
Message-Id: <20220902172301.b41588d3342b87e7c415bdc6@samsung.com>
In-Reply-To: <YxD7kWBl88kMbdi5@sirena.org.uk>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20220725065308.2457024-1-jiho.chu@samsung.com>
        <CGME20220725065309epcas1p4565e7bb0fea1aaf3e5e300de00774c2a@epcas1p4.samsung.com>
        <20220725065308.2457024-2-jiho.chu@samsung.com>
        <YxD7kWBl88kMbdi5@sirena.org.uk>
Precedence: bulk

On Thu, 1 Sep 2022 19:36:01 +0100
Mark Brown <broonie@kernel.org> wrote:

> On Mon, Jul 25, 2022 at 03:53:00PM +0900, Jiho Chu wrote:
> 
> > +	drv->opened = drv->opened - 1;
> > +	if (drv->opened == 0) {
> > +		/* wait already submitted requests */
> > +		if (drv->desc->drain_reqs)
> > +			drv->desc->drain_reqs(drv);
> 
> > +		drv->desc->set_state(drv, TRINITY_STATE_PAUSE);
> 
> > +	mutex_lock(&drv->lock);
> > +	/** remove PAUSE set on the CP of the NPU */
> > +	if (drv->opened == 0) {
> > +		ret = trinity_wait_ready(drv);
> > +		if (ret != 0)
> > +			goto out;
> > +	}
> > +	drv->opened = drv->opened + 1;
> 
> Would it perhaps be cleaner to hold a runtime PM reference on the
> device for each file and deal with the power up/down of the hardware in
> the runtime PM callbacks?

Hi, Mark.
This open count will be removed as Greg's review.
Anyway, the PM callback for suspend/resume is defined on device_driver struct.

@@ -1400,6 +1833,7 @@ static struct platform_driver trinity_triv2 = {
                        .name = "triv2",
                        .owner = THIS_MODULE,
                        .of_match_table = of_match_ptr(trinity_match),
+                       .pm = &triv2_dev_pm_ops,
                },
 };

Thanks.
Jiho Chu