Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Sep 2022 11:54:46 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     cgel.zte@gmail.com
Cc:     Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        paskripkin@gmail.com, gregkh@linuxfoundation.org,
        straube.linux@gmail.com, martin@kaiser.cx, lu.fengchang@zte.com.cn,
        makvihas@gmail.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, Zeal-Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] Driver: r8188eu: Remove the unneeded result
 variable Return 0 instead of storing it in another redundant variable.
Message-ID: <20220902085446.GN2071@kadam>
References: <20220902032628.316333-1-lu.fengchang@zte.com.cn>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220902032628.316333-1-lu.fengchang@zte.com.cn>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wjnvDErbmuv6YobmHjr0gX5HWN1SqeMloktzEDXf3uoNlIhB+ekQCqAe5mg1?=
 =?us-ascii?Q?chLmoVw7pgADp34lozT62HoVfdm2302gAcJHB4PsOf6RqoMr8hd+YHpzjQW1?=
 =?us-ascii?Q?jnAeKy/YQg0/kkg+SXwm3Hx3hxFm+dVMLLt+djCfFlqCWoLWxooVJOhdOrkH?=
 =?us-ascii?Q?iqRWFHyZdaVK5gXsIgLIjNSlgfFkWO5u+LLmGJGHR83Jp4TiONn9ea0AwI2U?=
 =?us-ascii?Q?xCypNRk1lSLY30b2VyzhFmvfAkaGUhqJiyFWI8VF/d0P4G4mDp6yG5xqRUFs?=
 =?us-ascii?Q?rGzLvwkBVndsxxwDTcYOFWTsJYLuv9etXCc2VH5yBxVTIpqFQpLuJpU2+Oib?=
 =?us-ascii?Q?CD671Y4WV5WskpQUnQ79n9dxkrIeYKakmMv3rOSkwc18kEvwrevCYgxt4c5N?=
 =?us-ascii?Q?lOamTun3nrEsRS3P/heaH+cVHNPJdjq48W9YA0wOtmNLw7J3SzhvlXLDvaUQ?=
 =?us-ascii?Q?w8i6D17WL5Ee/s35ncNFfIewhk9RgUq9cdTa6L5bKstDumgyP0iVPbHhQUvi?=
 =?us-ascii?Q?m09r72VbiWLY0u/bqU8Y1TGidJdKoQsT6cjoKGrJhXg2Dh0U685EChfC9Cem?=
 =?us-ascii?Q?INWM9MljZoO+Mm65p10Q6eJ5dToeVDY0xp15ej+LToQqLPfVHGCu+g1oOfwy?=
 =?us-ascii?Q?nf+v0aEcjIul+0AT62EotuDTxN6SJW/DnIeF8Nmz3JcW1et6seP9svZGptyW?=
 =?us-ascii?Q?5e9JQcdOK+I8zCzeImgauvsdcJJVMI0SAU8LrpjJzUabPhDkFqs/aWvNgO0O?=
 =?us-ascii?Q?qlDpmImBTprzn6SIfjtS6LMZcFfBrYUdgxbOV6COFMkgnAiPSqnxoGCuA6yl?=
 =?us-ascii?Q?QMaV1jrpR3r9AlVQGkfSuVJr/ZQG+xZiW5qwtSpQ8KHRBQPzIWYj7sjjsqDb?=
 =?us-ascii?Q?PzHi6XA17OM2DsiSrVQGNtbdAZM4Bbv4XuvE274G+nrv1QXWVzWhYmaBsYiU?=
 =?us-ascii?Q?3s9NF2hKvOmyrpVhLDpZT6pE4aLr5daZ1amjcDuqwZyZcJhovU02b6kMziSU?=
 =?us-ascii?Q?L31+SoAw1a4i95Oh50XqhELesfhPvhStLzY/b16fKtjxYnMeUwxB3G7MYsPk?=
 =?us-ascii?Q?OFtr5wEgaiwI144juWtCmRyx4mP0gOUzzz5EgmmRo9ZRND4CUPqXujrdZmnC?=
 =?us-ascii?Q?jWjL/8zKfCKYcviGiSSZzWEG/DlwaOo2UcK/L5fl1HJTLBpldwrPG9he6LH8?=
 =?us-ascii?Q?w9nMOkF/Wn6ACwtAZT15W++ji4kG7coNF93HXnbi/1ZObjcNBf4UySUOK4vv?=
 =?us-ascii?Q?t+etSnGBCZhJvYpTfcAploq0T8TLJVwW+2CHTBkNln+2QP0iz7aRdrJ64ByA?=
 =?us-ascii?Q?uWFB8oXMriKK9bXnHqAfCSpHsljAsyUdVALcN5kujx4Q2QgtYx9dMzy4VjH3?=
 =?us-ascii?Q?Ne++10SCmrE3iu7CRnTvthW9Mqe7zc9OpgINcLDjnKbBC887FfmFYYIXXWtp?=
 =?us-ascii?Q?Vg6qGEWYgQ7MHCMYLHApmlCirYvPkaZqDF84qiHlw0D+2GB+P0VkPP6L4Op3?=
 =?us-ascii?Q?qwzfmRcJ0FFrUnZHDE1IC3WmTQ7y8GpK67u0asxXrzayrhKDQwvzsAHb5+pB?=
 =?us-ascii?Q?ngnQtWGIQm0Ak9QYw3YgfXXUxn/BJnXDIiZmIUn67sjFyGgKEjkaTCLDqRa3?=
 =?us-ascii?Q?Mg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 72abccea-0d7e-4cd4-a99b-08da8cc0d52e
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 08:55:06.7842
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cPx0XXZVLVq0SOM5YKlUJApiTg3JuT+R4OzLzLg+dNwwxpio75zg1ddgkTMG8bCr0Yt7CR3o0t45d0iKcXCXeE+9+oPfQuYlJwzVrusq3aA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6481
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-09-01_12,2022-08-31_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 malwarescore=0
 suspectscore=0 spamscore=0 adultscore=0 mlxlogscore=650 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2209020041
X-Proofpoint-GUID: f4kl0-j37UFlFGQZgcN6kVEwzoXiUFdg
X-Proofpoint-ORIG-GUID: f4kl0-j37UFlFGQZgcN6kVEwzoXiUFdg
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 02, 2022 at 03:26:28AM +0000, cgel.zte@gmail.com wrote:
> From: lufengchang <lu.fengchang@zte.com.cn>
> 
> Reported-by: Zeal-Robot <zealci@zte.com.cn>
> Signed-off-by: lufengchang <lu.fengchang@zte.com.cn>
> ---

There is a lot wrong with the format of this patch.
1) The subsystem prefix
2) The blank line after the subject
3) Line wrapping at 75 chars
4) Your name is not capitalized
5) Greg doesn't like Zeal-Robot tags.

regards,
dan carpenter