Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220901175022.334824-1-cezary.rojewski@intel.com>
 <20220901175022.334824-2-cezary.rojewski@intel.com> <CAHp75VfO7_ASHGdpkcb1dwvhyHPT31eYuAkCm2q7B+2WmtZC4g@mail.gmail.com>
 <e8a06f76-9414-6391-0582-667cf817dbcc@intel.com>
In-Reply-To: <e8a06f76-9414-6391-0582-667cf817dbcc@intel.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 2 Sep 2022 12:04:19 +0300
Message-ID: <CAHp75VdCwJMSzVD0_tniFOwshR-5mJqgwL58=aV99XFXgK5Obw@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] lib/string_helpers: Introduce tokenize_user_input()
To:     Cezary Rojewski <cezary.rojewski@intel.com>
Cc:     ALSA Development Mailing List <alsa-devel@alsa-project.org>,
        Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
        Jaroslav Kysela <perex@perex.cz>,
        amadeuszx.slawinski@linux.intel.com,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        =?UTF-8?Q?P=C3=A9ter_Ujfalusi?= <peter.ujfalusi@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Andy Shevchenko <andy@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Matthew Wilcox <willy@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Sep 2, 2022 at 10:46 AM Cezary Rojewski
<cezary.rojewski@intel.com> wrote:
> On 2022-09-01 9:34 PM, Andy Shevchenko wrote:
> > On Thu, Sep 1, 2022 at 8:40 PM Cezary Rojewski
> > <cezary.rojewski@intel.com> wrote:

...

> >> +int tokenize_user_input(const char __user *from, size_t count, int **tkns);
> >
> > Not sure how I can deduct from the name what function is actually
> > doing. Suggested new name: int_array_parse_user().
> >
> > int int_array_parse_user(const char __user *from, size_t count, int **array);
> >
> > (Note that we have _user suffix for many APIs in the kernel that does
> > interact with user space memory)
>
> That's why I've added '_user_' in the middle! Anyway, I guess the
> expectation is that it's a suffix - precisely at the end of the name.
>
> Could we reorder it a bit: "parse_int_array_user"?

Most of the exported functions that have 'parse' word, have it after
namespace, but in this case there is no dedicated namespace and it
also will be in alignment with parse_options_str. That said, go for
it.

-- 
With Best Regards,
Andy Shevchenko